ewilliams28/turnstone
1
0
Fork 0
mirror of https://github.com/turnstonelabs/turnstone.git synced 2026-08-12 23:12:23 -06:00
Code Issues Packages Projects Releases Wiki Activity

fix(ui): wrap interactive reminder spans in .msg-body + exclude system-nudge from anchor lookup

Browse Source 
Closes round-1 review findings q-3 + q-4 (minor, merged) and bug-3 + bug-4
(nit, merged).

* **q-3 + q-4:** The new ``.msg.user-reminder .msg-body { white-space:
  pre-wrap }`` rule was a no-op on the interactive UI because that
  frontend's ``_buildDefaultReminderBubble`` appended label + text spans
  directly to the outer ``.msg.user-reminder`` element with no
  ``.msg-body`` wrapper.  Coord rendered the same shape with a wrapper.
  The two implementations diverging on DOM structure also meant a
  shared-helper extraction was harder than necessary.  Reconciled by
  wrapping interactive's spans in ``.msg-body`` to match coord; the CSS
  rule now applies to both UIs and the shared-extraction follow-up to
  ``shared_static/cards.js`` is mechanical (deferred per the review
  report — out of scope for this commit).

* **bug-3 + bug-4:** The reminder anchor lookup ``.msg.user`` also
  matched ``.msg.user.system-nudge`` markers because the marker carries
  both classes.  A non-wake reminder fired between a wake marker and
  the next real user message would anchor below the wake marker rather
  than the previous real user message.  Edge case (``/history`` reload
  corrects), but the fix is mechanical: change the selector to
  ``.msg.user:not(.system-nudge)`` in both files.

(cherry picked from commit 869135d97a)
This commit is contained in:
Patrick Buckley
2026-05-06 22:15:45 -07:00
parent 0e2ea122eb
commit eb92e61755
2 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
turnstone/console/static/coordinator/coordinator.js
+3 -1
View File
@@ -492,7 +492,9 @@
appendReminderBubble(reminders, marker);
return;
}
const userMsgs = messagesEl.querySelectorAll(".msg.user");
const userMsgs = messagesEl.querySelectorAll(
".msg.user:not(.system-nudge)",
);
const anchor = userMsgs.length ? userMsgs[userMsgs.length - 1] : null;
appendReminderBubble(reminders, anchor);
}
turnstone/ui/static/app.js
+8 -3
View File
@@ -753,6 +753,8 @@ function _buildWatchResultBubble(r) {
function _buildDefaultReminderBubble(r) {
var el = document.createElement("div");
el.className = "msg user-reminder";
var body = document.createElement("div");
body.className = "msg-body";
var labelEl = document.createElement("span");
labelEl.className = "msg-user-reminder-label";
labelEl.textContent =
@@ -760,8 +762,9 @@ function _buildDefaultReminderBubble(r) {
var textEl = document.createElement("span");
textEl.className = "msg-user-reminder-text";
textEl.textContent = r.text || "";
el.appendChild(labelEl);
el.appendChild(textEl);
body.appendChild(labelEl);
body.appendChild(textEl);
el.appendChild(body);
return el;
}
@@ -803,7 +806,9 @@ Pane.prototype.addUserReminder = function (reminders, source) {
if (source === "system_nudge") {
anchor = this.addSystemNudgeMarker();
} else {
var userBubbles = this.messagesEl.querySelectorAll(".msg.user");
var userBubbles = this.messagesEl.querySelectorAll(
".msg.user:not(.system-nudge)",
);
anchor = userBubbles.length ? userBubbles[userBubbles.length - 1] : null;
}
for (var i = 0; i < reminders.length; i++) {