ewilliams28/turnstone
1
0
Fork 0
mirror of https://github.com/turnstonelabs/turnstone.git synced 2026-08-12 23:12:23 -06:00
Code Issues Packages Projects Releases Wiki Activity

fix(ui): hide saved-workstreams pagination during dashboard load/error

Browse Source 
Addresses #603 review: the pagination control is a sibling of the cards
container, so loadDashboard()'s "Loading…" / "Failed to load" states (which
replaceChildren only the cards) left stale Prev/Next visible and still wired
to the previous _wsSavedItems cache — in the error state clicking them would
resurrect the old cards over "Failed to load". Route both transient states
through a _setSavedWsMessage() helper that clears the cards and hides the
pagination in lockstep; a successful load re-renders both via
renderSavedWorkstreams.
This commit is contained in:
Patrick Buckley
2026-05-29 12:30:34 -07:00
parent 757561db9a
commit 48fc381ab6
1 changed files with 15 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
turnstone/ui/static/app.js
+15 -6
View File
@@ -4071,12 +4071,23 @@ function toggleDashboard() {
else showDashboard();
}
// Paint a transient message (loading / error) into the saved-workstreams
// area. Clears any cards AND hides the pagination control \u2014 it's a sibling
// of the cards container, so a bare replaceChildren on the cards alone would
// leave stale Prev/Next visible and still wired to the previous list cache.
// A successful load re-shows both via renderSavedWorkstreams.
function _setSavedWsMessage(text) {
document
.getElementById("dashboard-saved-cards")
.replaceChildren(makeEmptyState(text));
const pag = document.getElementById("ws-pagination");
if (pag) pag.style.display = "none";
}
function loadDashboard() {
const tableEl = document.getElementById("dash-ws-table");
tableEl.replaceChildren(makeEmptyState("Loading\u2026"));
document
.getElementById("dashboard-saved-cards")
.replaceChildren(makeEmptyState("Loading\u2026"));
_setSavedWsMessage("Loading\u2026");
const dashP = authFetch("/v1/api/dashboard").then(function (r) {
return r.json();
});
@@ -4100,9 +4111,7 @@ function loadDashboard() {
})
.catch(function () {
tableEl.replaceChildren(makeEmptyState("Failed to load"));
document
.getElementById("dashboard-saved-cards")
.replaceChildren(makeEmptyState("Failed to load"));
_setSavedWsMessage("Failed to load");
});
}