mirror of
https://github.com/open-policy-agent/opa.git
synced 2026-08-12 19:32:48 -06:00
Kunal Behbudzade
ab2187089a
### Why the changes in this PR are needed? Fixes #8894. `opa fmt` expands a one-line `if` condition into a block whenever the rule head's *value* expression spans multiple lines, even though the condition itself is a single simple term. For example: ```rego foo := sprintf( "%d", [1], ) if allow ``` was reformatted to: ```rego foo := sprintf( "%d", [1], ) if { allow } ``` ### What are the changes in this PR? The inline-`if` path in `writeRule` decides whether to keep `if <term>` on one line by comparing the body term's row to the rule head's row: ```go if rule.Body[0].Location.Row == rule.Head.Location.Row { ``` `rule.Head.Location.Row` is the head's **start** row. Once the head value wraps onto later lines, the single body term sits on a later row than the head start, the equality fails, and formatting falls through to the block form. The fix compares against the head's **end** row instead (start row plus the number of newlines in the head's location text), so a single body term on the same line as `if` stays inline regardless of how many lines the head value occupies. Single-line heads are unaffected (end row == start row), and genuinely multi-statement bodies still expand as before (they don't hit the `len(rule.Body) == 1` branch). ### Notes to assist PR review: Added `v1/format/testfiles/v1/test_issue_8894.rego` (+`.formatted`) with the exact repro from the issue; it fails on `master` (expands to a block) and passes with this change. The rest of the format golden suite is unchanged. Signed-off-by: Kunalbehbud <b.kunal2002@gmail.com>
Open Policy Agent
Open Policy Agent (OPA) is an open source, general-purpose policy engine that enables unified, context-aware policy enforcement across the entire stack.
OPA is proud to be a graduated project in the Cloud Native Computing Foundation (CNCF) landscape. For details read the CNCF announcement.
Get started with OPA
- Write your first Rego policy with the Rego Playground or use it to share your work with others for feedback and support. Have a look at the Access Control examples if you're not sure where to start.
- Install the VS Code extension to get started locally with live diagnostics, debugging and formatting. See Editor and IDE Support for other supported editors.
- Go to the OPA Documentation to learn about the Rego language as well as how to deploy and integrate OPA.
- Check out the learning resources in the Learning Rego section of the ecosystem directory.
- Follow the Running OPA instructions to get started with the OPA CLI locally.
- See Docker Hub for container images and the GitHub releases for binaries.
- Check out the OPA Roadmap to see a high-level snapshot of OPA features in-progress and planned.
Want to talk about OPA or get support?
- Join the OPA Slack to talk to other OPA users and maintainers. See
#helpfor support. - Check out the Community Discussions to ask questions.
- See the Support page for commercial support options.
Interested to learn what others are doing with OPA?
- Browse community projects on the OPA Ecosystem Directory - don't forget to list your own!
- Check out the ADOPTERS.md file for a list of production adopters. Does your organization use OPA in production? Support the OPA project by submitting a PR to add your organization to the list with a short description of your OPA use cases!
Want to integrate OPA?
- See the high-level Go SDK or the low-level Go API
to integrate OPA with services written in Go.
- See the REST API reference to integrate OPA with services written in other languages.
- See the integration docs for more options.
Want to contribute to OPA?
- Read the Contributing Guide to learn how to make your first contribution.
- Use #contributors in Slack to talk to other contributors and OPA maintainers.
- File a GitHub Issue to request features or report bugs.
How does OPA work?
OPA gives you a high-level declarative language to author and enforce policies across your stack.
With OPA, you define rules that govern how your system should behave. These rules exist to answer questions like:
- Can user X call operation Y on resource Z?
- What clusters should workload W be deployed to?
- What tags must be set on resource R before it's created?
You integrate services with OPA so that these kinds of policy decisions do not have to be hardcoded in your service. Services integrate with OPA by executing queries when policy decisions are needed.
When you query OPA for a policy decision, OPA evaluates the rules and data (which you give it) to produce an answer. The policy decision is sent back as the result of the query.
For example, in a simple API authorization use case:
- You write rules that allow (or deny) access to your service APIs.
- Your service queries OPA when it receives API requests.
- OPA returns allow (or deny) decisions to your service.
- Your service enforces the decisions by accepting or rejecting requests accordingly.
For concrete examples of how to integrate OPA with systems like Kubernetes, Terraform, Docker, SSH, and more, see openpolicyagent.org.
Presentations
- Open Policy Agent (OPA) Intro & Deep Dive @ Kubecon EU 2026: video
- Open Policy Agent (OPA) Intro & Deep Dive @ Kubecon NA 2025: video
- Open Policy Agent (OPA) Intro & Deep Dive @ Kubecon EU 2025: video
- Open Policy Agent (OPA) Intro & Deep Dive @ Kubecon NA 2024: video
- Open Policy Agent (OPA) Intro & Deep Dive @ Kubecon EU 2024: video
- Open Policy Agent (OPA) Intro & Deep Dive @ Kubecon NA 2023: video
- Open Policy Agent (OPA) Intro & Deep Dive @ Kubecon EU 2023: video
- Running Policy in Hard to Reach Places with WASM & OPA @ CN Wasm Day EU 2023: video
- OPA maintainers talk @ Kubecon NA 2022: video
- Open Policy Agent (OPA) Intro & Deep Dive @ Kubecon EU 2022: video
- Open Policy Agent Intro @ KubeCon EU 2021: Video
- Using Open Policy Agent to Meet Evolving Policy Requirements @ KubeCon NA 2020: video
- Applying Policy Throughout The Application Lifecycle with Open Policy Agent @ CloudNativeCon 2019: video
- Open Policy Agent Introduction @ CloudNativeCon EU 2018: video, slides
- Rego Deep Dive @ CloudNativeCon EU 2018: video, slides
- How Netflix Is Solving Authorization Across Their Cloud @ CloudNativeCon US 2017: video, slides.
- Policy-based Resource Placement in Kubernetes Federation @ LinuxCon Beijing 2017: slides, screencast
- Enforcing Bespoke Policies In Kubernetes @ KubeCon US 2017: video, slides
- Istio's Mixer: Policy Enforcement with Custom Adapters @ CloudNativeCon US 2017: video, slides
Security
A third party security audit was performed by Cure53, you can see the full report here.
Please report vulnerabilities by email to open-policy-agent-security. We will send a confirmation message to acknowledge that we have received the report and then we will send additional messages to follow up once the issue has been investigated.