Anders Eknert 2378494a23 Modernize fixes and some string building improvements (#8993) ...

Mostly automated fixes from running:
```
go run golang.org/x/tools/go/analysis/passes/modernize/cmd/modernize@latest --fix ./...
```

But carefully reviewed, and several fixes reverted as they looked like
they potentially could be less performant, and in a few cases due to
bugs in the analyzer that changed semantics of the code. Will report
these upstream.

Mostly good fixes though!

Signed-off-by: Anders Eknert <anders.eknert@apple.com>

2026-08-10 12:49:15 +02:00

..

builtins

topdown: fix precision loss for integers larger than 64 bits in arithmetic and aggregates (#8887)

2026-07-17 09:04:08 -05:00

cache

Modernize fixes and some string building improvements (#8993)

2026-08-10 12:49:15 +02:00

copypropagation

topdown/copypropagation: avoid circular reference through call

2026-07-25 12:18:17 +02:00

durationparser

Add support for days, weeks and years in parse_duration_ns (#8463)

2026-04-13 20:20:51 +00:00

lineage

build: bump Go version requirement to 1.24 (#7839)

2025-08-24 09:02:09 +02:00

print

Preparing for v1 API

2024-12-12 15:09:03 +01:00

testdata

v1 API

2024-12-12 15:27:34 +01:00

aggregates_bench_test.go

topdown: fix "a", "a" in {"a"} not returning true (#8747)

2026-06-26 10:04:30 +02:00

aggregates.go

topdown: fix precision loss for integers larger than 64 bits in arithmetic and aggregates (#8887)

2026-07-17 09:04:08 -05:00

arithmetic.go

topdown: Fix false modulo by zero for multiples of 2^64 (#8989)

2026-08-10 11:32:21 +02:00

array.go

perf: json.patch + interning improvements (#8289)

2026-02-10 20:57:12 +00:00

binary.go

perf: avoid allocating in binary and/or when possible (#8689)

2026-05-21 23:00:34 +02:00

bindings_alloc_bench_test.go

topdown: fix BenchmarkFunctionArgumentCounts query (#8327)

2026-02-16 10:35:00 +01:00

bindings_test.go

perf(topdown): optimize bindings allocation with dynamic pre-sizing (#8233)

2026-02-13 11:11:27 +00:00

bindings.go

perf(topdown): optimize bindings allocation with dynamic pre-sizing (#8233)

2026-02-13 11:11:27 +00:00

bits.go

Preparing for v1 API

2024-12-12 15:09:03 +01:00

builtins_test.go

perf(topdown): reduce allocs in float sum/product (#8235)

2026-01-18 09:05:27 +01:00

builtins.go

Modernize fixes and some string building improvements (#8993)

2026-08-10 12:49:15 +02:00

cache_bench_test.go

Use Go 1.22+ int ranges (#7328)

2025-01-30 09:57:27 +01:00

cache_test.go

Preparing for v1 API

2024-12-12 15:09:03 +01:00

cache.go

topdown+util: add generic SliceStack/GroupStack, unify refStack/functionMocksStack/saveStack

2026-07-14 08:30:20 +02:00

cancel.go

Preparing for v1 API

2024-12-12 15:09:03 +01:00

casts.go

Simplify interning (#7714)

2025-06-23 11:40:00 +02:00

cidr_test.go

build: bump Go version requirement to 1.24 (#7839)

2025-08-24 09:02:09 +02:00

cidr.go

perf(topdown): pre-alloc in various builtins

2026-01-12 09:28:16 +01:00

comparison.go

ast: Clean up code for value comparisons (#8737)

2026-06-04 13:08:57 +00:00

comprehension_bindings_bench_test.go

topdown: fix BenchmarkFunctionArgumentCounts query (#8327)

2026-02-16 10:35:00 +01:00

comprehension_comparison_bench_test.go

topdown: fix BenchmarkFunctionArgumentCounts query (#8327)

2026-02-16 10:35:00 +01:00

crypto_test.go

Modernize analyzer fixes (#7965)

2025-10-10 17:51:02 +02:00

crypto.go

builtins: Add StringOperandByteSlice helper

2025-11-18 16:02:12 +01:00

doc.go

Preparing for v1 API

2024-12-12 15:09:03 +01:00

encoding_bench_test.go

builtins: Add StringOperandByteSlice helper

2025-11-18 16:02:12 +01:00

encoding.go

perf(topdown): pre-alloc in various builtins

2026-01-12 09:28:16 +01:00

enumerate_bench_test.go

Modernize fixes and some string building improvements (#8993)

2026-08-10 12:49:15 +02:00

errors_jsonv2.go

Add support for Go 1.27 & jsonv2 (#8947)

2026-07-30 17:41:28 +01:00

errors_test.go

perf: String() implementations using appenders (#8192)

2026-01-08 10:14:53 +01:00

errors.go

Add array.flatten built-in function (#8232)

2026-01-27 21:46:11 +00:00

eval_bench_test.go

perf: Allocate less in array unification (#8351)

2026-02-23 13:20:27 +00:00

eval_test.go

ast: Clean up code for value comparisons (#8737)

2026-06-04 13:08:57 +00:00

eval.go

Various style fixes

2026-07-24 10:15:07 +02:00

evaluated_test.go

topdown: change labels aggregation and merge logic (#8656)

2026-05-18 09:33:39 +00:00

evaluated.go

ast: support rule annotations from external sources, tweak performance (#8666)

2026-05-18 15:46:32 +02:00

example_test.go

Use any in place of interface{} (#7566)

2025-05-12 13:57:48 +02:00

exported_test.go

topdown: and/or expression evaluation (#8793)

2026-06-26 14:07:16 +02:00

external_source_test.go

ast+topdown: parametrized (prefix) external rule sources (#8881)

2026-07-13 19:50:02 +02:00

glob_bench_test.go

Modernize fixes and some string building improvements (#8993)

2026-08-10 12:49:15 +02:00

glob_test.go

build: bump Go version requirement to 1.24 (#7839)

2025-08-24 09:02:09 +02:00

glob.go

Simplify interning (#7714)

2025-06-23 11:40:00 +02:00

graphql_bench_test.go

e2e/authz,topdown: fix benchmarks (#7980)

2025-10-15 12:47:08 +02:00

graphql_test.go

build(deps): github.com/vektah/gqlparser/v2 from 2.5.30 to 2.5.31

2025-11-10 10:06:21 +01:00

graphql.go

Linter configuration cleanup (#8397)

2026-03-06 22:07:35 +00:00

http_fixup_darwin.go

go: cleanup old build flags

2026-02-12 08:42:05 +01:00

http_fixup.go

go: cleanup old build flags

2026-02-12 08:42:05 +01:00

http_slow_test.go

Add support for Go 1.27 & jsonv2 (#8947)

2026-07-30 17:41:28 +01:00

http_test.go

Modernize fixes and some string building improvements (#8993)

2026-08-10 12:49:15 +02:00

http.go

Modernize fixes and some string building improvements (#8993)

2026-08-10 12:49:15 +02:00

input_test.go

Use any in place of interface{} (#7566)

2025-05-12 13:57:48 +02:00

input.go

Add perfsprint linter (#7334)

2025-01-31 20:24:05 +01:00

instrumentation.go

ast+rego+topdown: external rule source support (#8600)

2026-05-05 09:48:50 +02:00

json_bench_test.go

internal/edittree: Add recursive tree node recycling. (#8693)

2026-06-01 15:42:59 -04:00

json_test.go

Preparing for v1 API

2024-12-12 15:09:03 +01:00

json.go

internal/edittree: Add recursive tree node recycling. (#8693)

2026-06-01 15:42:59 -04:00

jsonschema_test.go

fix: treat empty JSON Schema enum as unsatisfiable (#8934)

2026-08-10 11:30:21 +01:00

jsonschema.go

Enable pattern validation in json.verify_schema and json.match_schema (#8686)

2026-05-21 18:36:14 +02:00

net_test.go

Modernize fixes and some string building improvements (#8993)

2026-08-10 12:49:15 +02:00

net.go

perf(topdown): pre-alloc in various builtins

2026-01-12 09:28:16 +01:00

numbers_bench_test.go

Modernize analyzer fixes (#7965)

2025-10-10 17:51:02 +02:00

numbers_test.go

build: bump Go version requirement to 1.24 (#7839)

2025-08-24 09:02:09 +02:00

numbers.go

fix(topdown): correct operand in cheap range step (#8194)

2026-01-08 23:50:33 +01:00

object_bench_test.go

ast: Clean up code for value comparisons (#8737)

2026-06-04 13:08:57 +00:00

object_test.go

Preparing for v1 API

2024-12-12 15:09:03 +01:00

object.go

topdown: remove dst.Compare(src) shortcut

2026-06-05 10:28:58 +02:00

parse_bytes.go

Modernize fixes and some string building improvements (#8993)

2026-08-10 12:49:15 +02:00

parse_units.go

Limit exponent size in parse_bytes/parse_units to prevent timeout bypass (#8524)

2026-04-23 13:41:16 +00:00

parse.go

Preparing for v1 API

2024-12-12 15:09:03 +01:00

print_test.go

String interpolation (#8109)

2025-12-16 11:47:04 +01:00

print.go

Template string performance improvements and more (#8143)

2025-12-18 11:04:18 +00:00

providers.go

perf: json.patch + interning improvements (#8289)

2026-02-10 20:57:12 +00:00

query_test.go

build: bump Go version requirement to 1.24 (#7839)

2025-08-24 09:02:09 +02:00

query.go

topdown+util: add generic SliceStack/GroupStack, unify refStack/functionMocksStack/saveStack

2026-07-14 08:30:20 +02:00

reachable.go

fix: reachable_paths does not return all reachable paths (#8510)

2026-04-14 10:45:43 -05:00

regex_bench_test.go

Modernize fixes and some string building improvements (#8993)

2026-08-10 12:49:15 +02:00

regex_template_test.go

Add perfsprint linter (#7334)

2025-01-31 20:24:05 +01:00

regex_template.go

Use Go 1.22+ int ranges (#7328)

2025-01-30 09:57:27 +01:00

regex_test.go

build: bump Go version requirement to 1.24 (#7839)

2025-08-24 09:02:09 +02:00

regex.go

topdown: re-introduce cancellation-awareness for regex.replace()

2026-01-08 13:58:19 +01:00

resolver.go

perf(topdown): pre-alloc in various builtins

2026-01-12 09:28:16 +01:00

rules_bindings_bench_test.go

topdown: fix BenchmarkFunctionArgumentCounts query (#8327)

2026-02-16 10:35:00 +01:00

runtime_test.go

build: bump Go version requirement to 1.24 (#7839)

2025-08-24 09:02:09 +02:00

runtime.go

Simplify interning (#7714)

2025-06-23 11:40:00 +02:00

save_test.go

Preparing for v1 API

2024-12-12 15:09:03 +01:00

save.go

Various style fixes

2026-07-24 10:15:07 +02:00

semver.go

New custom SemVer implementation (#8010)

2025-11-04 09:09:50 +01:00

sets_bench_test.go

Modernize analyzer fixes (#7965)

2025-10-10 17:51:02 +02:00

sets_test.go

Preparing for v1 API

2024-12-12 15:09:03 +01:00

sets.go

perf(topdown): optimize union builtin

2026-01-08 10:24:13 +01:00

sink.go

perf: avoid extra allocation in sink if no cancel

2025-12-02 16:56:58 +01:00

strings_bench_test.go

perf: avoid allocations with custom Atoi and Atoi64 helpers (#8758)

2026-07-02 10:14:17 +00:00

strings.go

Modernize fixes and some string building improvements (#8993)

2026-08-10 12:49:15 +02:00

subset.go

Simplify interning (#7714)

2025-06-23 11:40:00 +02:00

template_dce_test.go

vendor a method-less text/template to restore whole-binary linker DCE (#8844)

2026-07-07 21:08:19 +02:00

template_string_test.go

Template string performance improvements and more (#8143)

2025-12-18 11:04:18 +00:00

template_string.go

Template string performance improvements and more (#8143)

2025-12-18 11:04:18 +00:00

template.go

vendor a method-less text/template to restore whole-binary linker DCE (#8844)

2026-07-07 21:08:19 +02:00

test.go

cmd+tester: Parameterized tests (#7366)

2025-02-17 22:08:27 +01:00

time_test.go

Add support for days, weeks and years in parse_duration_ns (#8463)

2026-04-13 20:20:51 +00:00

time.go

Add support for days, weeks and years in parse_duration_ns (#8463)

2026-04-13 20:20:51 +00:00

tokens_bench_test.go

build: bump Go version requirement to 1.24 (#7839)

2025-08-24 09:02:09 +02:00

tokens_test.go

build(deps): bump the dependencies group across 2 directories with 9 updates (#8575)

2026-04-30 10:49:52 +02:00

tokens.go

build(deps): bump the dependencies group across 2 directories with 9 updates (#8575)

2026-04-30 10:49:52 +02:00

topdown_bench_test.go

Modernize fixes and some string building improvements (#8993)

2026-08-10 12:49:15 +02:00

topdown_logical_test.go

topdown: and/or expression evaluation (#8793)

2026-06-26 14:07:16 +02:00

topdown_partial_bench_test.go

Modernize analyzer fixes (#7965)

2025-10-10 17:51:02 +02:00

topdown_partial_test.go

topdown/copypropagation: avoid circular reference through call

2026-07-25 12:18:17 +02:00

topdown_test.go

ast, topdown: Add not AST node type (#8427)

2026-03-30 18:12:57 +02:00

trace_test.go

topdown: and/or expression evaluation (#8793)

2026-06-26 14:07:16 +02:00

trace.go

Modernize fixes and some string building improvements (#8993)

2026-08-10 12:49:15 +02:00

type_name.go

Simplify interning (#7714)

2025-06-23 11:40:00 +02:00

type.go

Simplify interning (#7714)

2025-06-23 11:40:00 +02:00

uri.go

builtins: Add uri.parse and uri.is_valid built in functions (#8578)

2026-04-29 13:08:15 +00:00

uuid_test.go

build: bump Go version requirement to 1.24 (#7839)

2025-08-24 09:02:09 +02:00

uuid.go

perf: more interning (#7636)

2025-05-28 23:19:31 +02:00

walk.go

perf: json.patch + interning improvements (#8289)

2026-02-10 20:57:12 +00:00