ewilliams28/releases
1
0
Fork 0
mirror of https://github.com/open-policy-agent/opa.git synced 2026-08-12 19:32:48 -06:00
Code Issues Packages Projects Releases Wiki Activity

perf: avoid allocating in binary and/or when possible (#8689)

Browse Source 
Avoid allocation in `&` and `|` calls when either of the operands is an
empty set.

Signed-off-by: Anders Eknert <anders.eknert@apple.com>
This commit is contained in:
Anders Eknert
2026-05-21 23:00:34 +02:00
committed by GitHub
parent f9155842bc
commit d425213923
1 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
v1/topdown/binary.go
+12 -2
View File
@@ -10,7 +10,6 @@ import (
)
func builtinBinaryAnd(_ BuiltinContext, operands []*ast.Term, iter func(*ast.Term) error) error {
s1, err := builtins.SetOperand(operands[0].Value, 1)
if err != nil {
return err
@@ -21,6 +20,10 @@ func builtinBinaryAnd(_ BuiltinContext, operands []*ast.Term, iter func(*ast.Ter
return err
}
if s1.Len() == 0 || s2.Len() == 0 {
return iter(ast.InternedEmptySet)
}
i := s1.Intersect(s2)
if i.Len() == 0 {
return iter(ast.InternedEmptySet)
@@ -30,7 +33,6 @@ func builtinBinaryAnd(_ BuiltinContext, operands []*ast.Term, iter func(*ast.Ter
}
func builtinBinaryOr(_ BuiltinContext, operands []*ast.Term, iter func(*ast.Term) error) error {
s1, err := builtins.SetOperand(operands[0].Value, 1)
if err != nil {
return err
@@ -41,6 +43,14 @@ func builtinBinaryOr(_ BuiltinContext, operands []*ast.Term, iter func(*ast.Term
return err
}
if s1.Len() == 0 {
return iter(operands[1])
}
if s2.Len() == 0 {
return iter(operands[0])
}
return iter(ast.NewTerm(s1.Union(s2)))
}