ewilliams28/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-08-27 21:07:01 -06:00
Code Issues Packages Projects Releases Wiki Activity

perf(tests): reuse model manifest selection imports (#131194)

Browse Source
This commit is contained in:
Peter Steinberger
2026-08-27 14:34:03 -07:00
committed by GitHub
parent d5d2167bff
commit ef858c0f1b
1 changed files with 25 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/agents/model-selection-manifest-workspace.test.ts
+25 -39
View File
@@ -1,6 +1,12 @@
// Verifies configured model selection uses manifest policy only in scoped contexts.
import { beforeEach, describe, expect, it, vi } from "vitest";
import type { OpenClawConfig } from "../config/types.openclaw.js";
import {
buildAllowedModelSet,
buildConfiguredModelCatalog,
buildModelAliasIndex,
resolveConfiguredModelRef,
} from "./model-selection-shared.js";
const loadManifestMetadataSnapshotMock = vi.hoisted(() => vi.fn());
const getCurrentPluginMetadataSnapshotMock = vi.hoisted(() => vi.fn());
@@ -26,7 +32,6 @@ vi.mock("./provider-model-normalization.runtime.js", () => ({
describe("configured model manifest workspace scope", () => {
beforeEach(() => {
vi.resetModules();
loadManifestMetadataSnapshotMock.mockReset();
getCurrentPluginMetadataSnapshotMock.mockReset();
getActivePluginRegistryWorkspaceDirFromStateMock.mockReset();
@@ -47,10 +52,9 @@ describe("configured model manifest workspace scope", () => {
});
});
it("does not reuse workspace manifest policies without a workspace context", async () => {
it("does not reuse workspace manifest policies without a workspace context", () => {
// Workspace plugin normalization must not leak into unscoped callers; they
// can only use the current global metadata snapshot.
const { buildConfiguredModelCatalog } = await import("./model-selection-shared.js");
const cfg = {
models: {
providers: {
@@ -74,8 +78,7 @@ describe("configured model manifest workspace scope", () => {
expect(loadManifestMetadataSnapshotMock).not.toHaveBeenCalled();
});
it("uses manifest policies when the workspace context is explicit", async () => {
const { buildConfiguredModelCatalog } = await import("./model-selection-shared.js");
it("uses manifest policies when the workspace context is explicit", () => {
const cfg = {
models: {
providers: {
@@ -100,7 +103,7 @@ describe("configured model manifest workspace scope", () => {
expect(getCurrentPluginMetadataSnapshotMock).not.toHaveBeenCalled();
});
it("uses an unscoped current snapshot without falling back to a metadata scan", async () => {
it("uses an unscoped current snapshot without falling back to a metadata scan", () => {
getCurrentPluginMetadataSnapshotMock.mockReturnValue({
plugins: [
{
@@ -114,7 +117,6 @@ describe("configured model manifest workspace scope", () => {
},
],
});
const { buildConfiguredModelCatalog } = await import("./model-selection-shared.js");
const cfg = {
models: {
providers: {
@@ -134,9 +136,8 @@ describe("configured model manifest workspace scope", () => {
expect(loadManifestMetadataSnapshotMock).not.toHaveBeenCalled();
});
it("builds configured catalog facts once when resolving allowed models", async () => {
it("builds configured catalog facts once when resolving allowed models", () => {
getCurrentPluginMetadataSnapshotMock.mockReturnValue({ plugins: [] });
const { buildAllowedModelSet } = await import("./model-selection-shared.js");
const cfg = {
models: {
providers: {
@@ -156,10 +157,9 @@ describe("configured model manifest workspace scope", () => {
expect(loadManifestMetadataSnapshotMock).not.toHaveBeenCalled();
});
it("does not load manifest metadata for empty configured model aliases", async () => {
it("does not load manifest metadata for empty configured model aliases", () => {
// Alias indexing is a hot config path. Empty inputs should avoid manifest
// scans entirely.
const { buildModelAliasIndex } = await import("./model-selection-shared.js");
const cfg = {} as unknown as OpenClawConfig;
const aliases = buildModelAliasIndex({ cfg, defaultProvider: "anthropic" });
@@ -170,8 +170,7 @@ describe("configured model manifest workspace scope", () => {
expect(loadManifestMetadataSnapshotMock).not.toHaveBeenCalled();
});
it("does not load manifest metadata for wildcard-only configured model aliases", async () => {
const { buildModelAliasIndex } = await import("./model-selection-shared.js");
it("does not load manifest metadata for wildcard-only configured model aliases", () => {
const cfg = {
agents: {
defaults: {
@@ -190,8 +189,7 @@ describe("configured model manifest workspace scope", () => {
expect(loadManifestMetadataSnapshotMock).not.toHaveBeenCalled();
});
it("does not load manifest metadata for configured model entries without aliases", async () => {
const { buildModelAliasIndex } = await import("./model-selection-shared.js");
it("does not load manifest metadata for configured model entries without aliases", () => {
const cfg = {
agents: {
defaults: {
@@ -210,8 +208,7 @@ describe("configured model manifest workspace scope", () => {
expect(loadManifestMetadataSnapshotMock).not.toHaveBeenCalled();
});
it("indexes selected-agent default-provider aliases without cold manifest discovery", async () => {
const { buildModelAliasIndex } = await import("./model-selection-shared.js");
it("indexes selected-agent default-provider aliases without cold manifest discovery", () => {
const cfg = {
agents: {
ownership: "explicit",
@@ -237,8 +234,7 @@ describe("configured model manifest workspace scope", () => {
expect(normalizeProviderModelIdWithRuntimeMock.mock.calls.length).toBe(0);
});
it("resolves selected-agent default-provider aliases without cold manifest discovery", async () => {
const { resolveConfiguredModelRef } = await import("./model-selection-shared.js");
it("resolves selected-agent default-provider aliases without cold manifest discovery", () => {
const cfg = {
agents: {
ownership: "explicit",
@@ -266,7 +262,7 @@ describe("configured model manifest workspace scope", () => {
it.each(["current", "supplied"] as const)(
"preserves %s prepared manifest policy for default-provider aliases",
async (source) => {
(source) => {
const manifestPlugins = [
{
modelIdNormalization: {
@@ -279,7 +275,6 @@ describe("configured model manifest workspace scope", () => {
if (source === "current") {
getCurrentPluginMetadataSnapshotMock.mockReturnValue({ plugins: manifestPlugins });
}
const { buildModelAliasIndex } = await import("./model-selection-shared.js");
const cfg = {
agents: { defaults: { models: { "openai/legacy": { alias: "Legacy" } } } },
} as unknown as OpenClawConfig;
@@ -299,14 +294,13 @@ describe("configured model manifest workspace scope", () => {
},
);
it("preserves workspace manifest policy for default-provider aliases", async () => {
it("preserves workspace manifest policy for default-provider aliases", () => {
getActivePluginRegistryWorkspaceDirFromStateMock.mockReturnValue("/workspace/a");
loadManifestMetadataSnapshotMock.mockReturnValue({
plugins: [
{ modelIdNormalization: { providers: { openai: { aliases: { ops: "workspace-ops" } } } } },
],
});
const { buildModelAliasIndex } = await import("./model-selection-shared.js");
const cfg = {
agents: { defaults: { models: { "openai/ops": { alias: "Operations" } } } },
} as unknown as OpenClawConfig;
@@ -318,8 +312,7 @@ describe("configured model manifest workspace scope", () => {
expect(loadManifestMetadataSnapshotMock.mock.calls[0]?.[0]?.workspaceDir).toBe("/workspace/a");
});
it("preserves provider-owned manifest discovery for non-default aliases", async () => {
const { buildModelAliasIndex } = await import("./model-selection-shared.js");
it("preserves provider-owned manifest discovery for non-default aliases", () => {
const cfg = {
agents: { defaults: { models: { "custom/ops": { alias: "Operations" } } } },
} as unknown as OpenClawConfig;
@@ -346,7 +339,7 @@ describe("configured model manifest workspace scope", () => {
["openai/legacy", { alias: "Legacy" }],
],
},
])("normalizes mixed aliases consistently with $name", async ({ models }) => {
])("normalizes mixed aliases consistently with $name", ({ models }) => {
loadManifestMetadataSnapshotMock.mockReturnValue({
plugins: [
{
@@ -359,7 +352,6 @@ describe("configured model manifest workspace scope", () => {
},
],
});
const { buildModelAliasIndex } = await import("./model-selection-shared.js");
const cfg = {
agents: { defaults: { models: Object.fromEntries(models) } },
} as unknown as OpenClawConfig;
@@ -377,8 +369,7 @@ describe("configured model manifest workspace scope", () => {
expect(loadManifestMetadataSnapshotMock).toHaveBeenCalledTimes(1);
});
it("preserves manifest discovery for default-provider configured API-owner mappings", async () => {
const { buildModelAliasIndex } = await import("./model-selection-shared.js");
it("preserves manifest discovery for default-provider configured API-owner mappings", () => {
const cfg = {
agents: { defaults: { models: { "openai/ops": { alias: "Operations" } } } },
models: { providers: { openai: { api: "custom-owner", models: [] } } },
@@ -390,8 +381,7 @@ describe("configured model manifest workspace scope", () => {
expect(loadManifestMetadataSnapshotMock.mock.calls.length).toBe(1);
});
it("does not load manifest metadata for statically resolved primary models", async () => {
const { resolveConfiguredModelRef } = await import("./model-selection-shared.js");
it("does not load manifest metadata for statically resolved primary models", () => {
const cases: Array<{ cfg: OpenClawConfig; expected: { provider: string; model: string } }> = [
{
cfg: {
@@ -423,8 +413,7 @@ describe("configured model manifest workspace scope", () => {
}
});
it("does not load manifest metadata for non-alias primary models with configured aliases", async () => {
const { resolveConfiguredModelRef } = await import("./model-selection-shared.js");
it("does not load manifest metadata for non-alias primary models with configured aliases", () => {
const cfg = {
agents: {
defaults: {
@@ -447,7 +436,7 @@ describe("configured model manifest workspace scope", () => {
expect(loadManifestMetadataSnapshotMock).not.toHaveBeenCalled();
});
it("uses manifest-normalized configured refs to infer providers for bare defaults", async () => {
it("uses manifest-normalized configured refs to infer providers for bare defaults", () => {
loadManifestMetadataSnapshotMock.mockReturnValue({
plugins: [
{
@@ -463,7 +452,6 @@ describe("configured model manifest workspace scope", () => {
},
],
});
const { resolveConfiguredModelRef } = await import("./model-selection-shared.js");
const cfg = {
agents: {
defaults: {
@@ -485,7 +473,7 @@ describe("configured model manifest workspace scope", () => {
expect(loadManifestMetadataSnapshotMock).toHaveBeenCalledTimes(1);
});
it("reuses resolved manifest plugins while resolving configured model aliases", async () => {
it("reuses resolved manifest plugins while resolving configured model aliases", () => {
loadManifestMetadataSnapshotMock.mockReturnValue({
plugins: [
{
@@ -504,7 +492,6 @@ describe("configured model manifest workspace scope", () => {
},
],
});
const { resolveConfiguredModelRef } = await import("./model-selection-shared.js");
const cfg = {
agents: {
defaults: {
@@ -527,7 +514,7 @@ describe("configured model manifest workspace scope", () => {
expect(loadManifestMetadataSnapshotMock).toHaveBeenCalledTimes(1);
});
it("reuses resolved manifest plugins while resolving direct primary models", async () => {
it("reuses resolved manifest plugins while resolving direct primary models", () => {
loadManifestMetadataSnapshotMock.mockReturnValue({
plugins: [
{
@@ -546,7 +533,6 @@ describe("configured model manifest workspace scope", () => {
},
],
});
const { resolveConfiguredModelRef } = await import("./model-selection-shared.js");
const cfg = {
agents: {
defaults: {