ewilliams28/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-08-27 21:07:01 -06:00
Code Issues Packages Projects Releases Wiki Activity

fix(config): clarify retired skill workshop plugin warning (#91757)

Browse Source
This commit is contained in:
Dallin Romney
2026-06-09 16:26:02 -07:00
committed by GitHub
parent f0d8048aa3
commit ec0f311f7f
2 changed files with 15 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/config/config.plugin-validation.test.ts
+7 -4
View File
@@ -1362,13 +1362,16 @@ describe("config plugin validation", () => {
expectRemovedPluginWarnings(res, removedId, removedId);
});
// Regression for #90244: skill-workshop was extracted into a built-in tool;
// upgraded configs that still reference plugins.entries.skill-workshop must warn,
// not block startup with "plugin not found".
it("warns for removed skill-workshop plugin id instead of failing validation", () => {
const removedId = "skill-workshop";
const res = validateRemovedPluginConfig(removedId);
expectRemovedPluginWarnings(res, removedId, removedId);
expect(res.ok).toBe(true);
const message =
"plugin removed: skill-workshop (stale plugin config ignored; Skill Workshop is built into OpenClaw skills now. Use skills.workshop settings and openclaw skills workshop commands, then remove this plugins config entry)";
expectPathMessage(res.warnings, `plugins.entries.${removedId}`, message);
expectPathMessage(res.warnings, "plugins.allow", message);
expectPathMessage(res.warnings, "plugins.deny", message);
expectPathMessage(res.warnings, "plugins.slots.memory", message);
});
it("does not auto-allow config-loaded overrides of bundled web search plugin ids", () => {
src/config/validation.ts
+8 -1
View File
@@ -57,6 +57,13 @@ const LEGACY_REMOVED_PLUGIN_IDS = new Set([
]);
const BLOCKED_PLUGIN_CANDIDATE_PREFIX = "blocked plugin candidate:";
function formatRemovedPluginConfigWarning(pluginId: string): string {
if (pluginId === "skill-workshop") {
return "plugin removed: skill-workshop (stale plugin config ignored; Skill Workshop is built into OpenClaw skills now. Use skills.workshop settings and openclaw skills workshop commands, then remove this plugins config entry)";
}
return `plugin removed: ${pluginId} (stale config entry ignored; remove it from plugins config)`;
}
type UnknownIssueRecord = Record<string, unknown>;
type ConfigPathSegment = string | number;
type ExplicitPluginReferences = {
@@ -1717,7 +1724,7 @@ function validateConfigObjectWithPluginsBase(
if (LEGACY_REMOVED_PLUGIN_IDS.has(pluginId)) {
warnings.push({
path: pathLocal,
message: `plugin removed: ${pluginId} (stale config entry ignored; remove it from plugins config)`,
message: formatRemovedPluginConfigWarning(pluginId),
});
return;
}