fix(codex): trust native start effort response

This commit is contained in:
Dallin Romney
2026-08-21 18:51:34 -07:00
parent 3925bd89fa
commit d78ae8b700
2 changed files with 8 additions and 14 deletions
@@ -3465,8 +3465,7 @@ describe("Codex app-server supervised branch lifecycle", () => {
"native-provider",
typeof reasoningEffort === "string" ? reasoningEffort : null,
);
const { reasoningEffort: _reasoningEffort, ...withoutReasoningEffort } = response;
return withoutReasoningEffort;
return response;
}
if (method === "thread/resume") {
const config = (requestParams as { config?: Record<string, unknown> }).config;
@@ -29,12 +29,11 @@ import type {
CodexTurnEnvironmentParams,
JsonObject,
} from "./protocol.js";
import {
resolveCodexBindingReasoningEffort,
type CodexAppServerBindingIdentity,
type CodexAppServerBindingStore,
type CodexAppServerPendingSupervisionBranch,
type CodexAppServerThreadBinding,
import type {
CodexAppServerBindingIdentity,
CodexAppServerBindingStore,
CodexAppServerPendingSupervisionBranch,
CodexAppServerThreadBinding,
} from "./session-binding.js";
import {
CodexThreadBindingConflictAfterCleanupError,
@@ -236,10 +235,6 @@ export async function materializePendingSupervisionBranch(
modelProvider: nativeModelProvider,
operation: "thread/start response",
});
const nativeReasoningEffort = resolveCodexBindingReasoningEffort(
startResponse.reasoningEffort,
probeResponse.reasoningEffort,
);
if (params.restrictedToolSurface) {
await params.lifecycleTiming.measure("restricted-tool-surface-mcp-attestation", () =>
attestCodexRestrictedToolSurfaceMcpServersDisabled(
@@ -312,7 +307,7 @@ export async function materializePendingSupervisionBranch(
...params.bindingPatch,
model: nativeModel,
modelProvider: bindingModelProvider,
reasoningEffort: nativeReasoningEffort,
reasoningEffort: startResponse.reasoningEffort,
historyCoveredThrough,
},
});
@@ -373,7 +368,7 @@ export async function materializePendingSupervisionBranch(
pendingSupervisionBranch: undefined,
model: nativeModel,
modelProvider: bindingModelProvider,
reasoningEffort: nativeReasoningEffort,
reasoningEffort: startResponse.reasoningEffort,
historyCoveredThrough,
lifecycle: { action: "forked" },
};