fix(ui): avoid nested activity main landmark (#127789)

Co-authored-by: Amp <amp@ampcode.com>
This commit is contained in:
Peter Steinberger
2026-08-21 23:08:38 -07:00
committed by GitHub
parent 9d33b0b727
commit c8d6604261
2 changed files with 17 additions and 2 deletions
@@ -46,6 +46,21 @@ function props(overrides: Partial<Parameters<typeof renderSessionActivityView>[0
};
}
describe("session activity semantics", () => {
beforeEach(() => {
document.body.innerHTML = "";
});
it("leaves the page main landmark to the app shell", () => {
const container = document.createElement("div");
document.body.append(container);
render(renderSessionActivityView(props()), container);
expect(container.querySelectorAll("main")).toHaveLength(0);
});
});
describe("session activity people filter", () => {
beforeEach(() => {
document.body.innerHTML = "";
@@ -458,7 +458,7 @@ export function renderSessionActivityView(props: SessionActivityViewProps) {
</div>
${renderPeopleControl(props, people, selectedPerson, projection.timeCount)}
</div>
<main class="activity-feed__main">
<div class="activity-feed__main">
${props.filters.personId
? identity
? renderIdentityHeader(props.context, identity, props.rows)
@@ -490,7 +490,7 @@ export function renderSessionActivityView(props: SessionActivityViewProps) {
</section>`}
`
: nothing}
</main>
</div>
</div>
`;
}