ewilliams28/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-08-27 04:47:03 -06:00
Code Issues Packages Projects Releases Wiki Activity

fix(gateway): rate-limit cron mutations (#128287)

Browse Source 
Co-authored-by: Amp <amp@ampcode.com>
This commit is contained in:
Peter Steinberger
2026-08-23 10:29:24 -07:00
committed by GitHub
parent b0dafb2551
commit bca206d794
2 changed files with 21 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/gateway/methods/core-descriptors.ts
+4 -4
View File
@@ -342,10 +342,10 @@ const CORE_GATEWAY_METHOD_SPECS = [
["cron.status", "cron", "operator.read", "<=2026.7"],
["cron.scratch.get", "cron", "operator.admin", "2026.7"],
["cron.scratch.set", "cron", "operator.admin", "2026.7"],
["cron.add", "cron", "operator.admin", "<=2026.7"],
["cron.update", "cron", "operator.admin", "<=2026.7"],
["cron.remove", "cron", "operator.admin", "<=2026.7"],
["cron.run", "cron", "operator.admin", "<=2026.7"],
["cron.add", "cron", "operator.admin", "<=2026.7", { controlPlaneWrite: true }],
["cron.update", "cron", "operator.admin", "<=2026.7", { controlPlaneWrite: true }],
["cron.remove", "cron", "operator.admin", "<=2026.7", { controlPlaneWrite: true }],
["cron.run", "cron", "operator.admin", "<=2026.7", { controlPlaneWrite: true }],
["cron.runs", "cron", "operator.read", "<=2026.7"],
["gateway.identity.get", "system", "operator.read", "<=2026.7"],
// Deprecated read-only compatibility preview; new restart flows request the
src/gateway/server-methods-list.test.ts
+17
View File
@@ -203,6 +203,23 @@ describe("listGatewayMethods", () => {
expect(descriptor?.controlPlaneWrite).toBeUndefined();
});
it("classifies cron mutations as control-plane writes", () => {
const descriptors = createCoreGatewayMethodDescriptors(coreGatewayHandlers);
for (const method of ["cron.add", "cron.update", "cron.remove", "cron.run"]) {
expect(descriptors.find((descriptor) => descriptor.name === method)).toMatchObject({
name: method,
scope: "operator.admin",
controlPlaneWrite: true,
});
}
for (const method of ["cron.get", "cron.list", "cron.status", "cron.runs"]) {
expect(
descriptors.find((descriptor) => descriptor.name === method)?.controlPlaneWrite,
).toBeUndefined();
}
});
it("does not advertise hidden core handlers", () => {
const methods = listGatewayMethods();
expect(methods).not.toContain("node.runnerInventory.update");