test: settle plugin repair noops

This commit is contained in:
Shakker
2026-05-12 20:33:44 +01:00
parent d18bbfe7ae
commit b60ae89aa4
@@ -617,7 +617,7 @@ describe("repairMissingConfiguredPluginInstalls", () => {
expect(mocks.installPluginFromClawHub).not.toHaveBeenCalled();
expect(mocks.installPluginFromNpmSpec).not.toHaveBeenCalled();
expect(mocks.writePersistedInstalledPluginIndexInstallRecords).not.toHaveBeenCalled();
expect(result).toMatchObject({ changes: [], warnings: [] });
expect(result).toEqual({ changes: [], warnings: [], records: {} });
});
it("removes stale managed install records when the configured plugin is bundled", async () => {
@@ -876,7 +876,7 @@ describe("repairMissingConfiguredPluginInstalls", () => {
expect(mocks.installPluginFromClawHub).not.toHaveBeenCalled();
expect(mocks.installPluginFromNpmSpec).not.toHaveBeenCalled();
expect(mocks.writePersistedInstalledPluginIndexInstallRecords).not.toHaveBeenCalled();
expect(result).toMatchObject({ changes: [], warnings: [] });
expect(result).toEqual({ changes: [], warnings: [], records });
},
);
@@ -1057,7 +1057,7 @@ describe("repairMissingConfiguredPluginInstalls", () => {
expect(mocks.installPluginFromClawHub).not.toHaveBeenCalled();
expect(mocks.installPluginFromNpmSpec).not.toHaveBeenCalled();
expect(mocks.writePersistedInstalledPluginIndexInstallRecords).not.toHaveBeenCalled();
expect(result).toMatchObject({ changes: [], warnings: [] });
expect(result).toEqual({ changes: [], warnings: [], records: {} });
});
it("does not install configured plugins when plugins are globally disabled", async () => {
@@ -1115,7 +1115,7 @@ describe("repairMissingConfiguredPluginInstalls", () => {
expect(mocks.installPluginFromClawHub).not.toHaveBeenCalled();
expect(mocks.installPluginFromNpmSpec).not.toHaveBeenCalled();
expect(mocks.writePersistedInstalledPluginIndexInstallRecords).not.toHaveBeenCalled();
expect(result).toMatchObject({ changes: [], warnings: [] });
expect(result).toEqual({ changes: [], warnings: [], records: {} });
});
it("does not install plugins merely listed in plugins.allow", async () => {
@@ -1132,7 +1132,7 @@ describe("repairMissingConfiguredPluginInstalls", () => {
expect(mocks.installPluginFromNpmSpec).not.toHaveBeenCalled();
expect(mocks.writePersistedInstalledPluginIndexInstallRecords).not.toHaveBeenCalled();
expect(result).toMatchObject({ changes: [], warnings: [] });
expect(result).toEqual({ changes: [], warnings: [], records: {} });
});
it("installs a missing third-party downloadable plugin from npm only", async () => {
@@ -1398,10 +1398,7 @@ describe("repairMissingConfiguredPluginInstalls", () => {
expect(mocks.installPluginFromNpmSpec).not.toHaveBeenCalled();
expect(mocks.writePersistedInstalledPluginIndexInstallRecords).not.toHaveBeenCalled();
expect(result).toMatchObject({
changes: [],
warnings: [],
});
expect(result).toEqual({ changes: [], warnings: [], records: {} });
});
it("does not install a blocked downloadable plugin from explicit channel ids", async () => {
@@ -1428,7 +1425,7 @@ describe("repairMissingConfiguredPluginInstalls", () => {
expect(mocks.installPluginFromClawHub).not.toHaveBeenCalled();
expect(mocks.installPluginFromNpmSpec).not.toHaveBeenCalled();
expect(result).toMatchObject({ changes: [], warnings: [] });
expect(result).toEqual({ changes: [], warnings: [], records: {} });
});
it("does not install a channel catalog plugin when a configured plugin already owns that channel", async () => {
@@ -1486,7 +1483,7 @@ describe("repairMissingConfiguredPluginInstalls", () => {
expect(mocks.installPluginFromClawHub).not.toHaveBeenCalled();
expect(mocks.installPluginFromNpmSpec).not.toHaveBeenCalled();
expect(mocks.writePersistedInstalledPluginIndexInstallRecords).not.toHaveBeenCalled();
expect(result).toMatchObject({ changes: [], warnings: [] });
expect(result).toEqual({ changes: [], warnings: [], records: {} });
});
it("still installs a channel catalog plugin when the configured owner is blocked by the allowlist", async () => {
@@ -2339,6 +2336,6 @@ describe("repairMissingConfiguredPluginInstalls", () => {
expect(mocks.installPluginFromClawHub).not.toHaveBeenCalled();
expect(mocks.installPluginFromNpmSpec).not.toHaveBeenCalled();
expect(mocks.writePersistedInstalledPluginIndexInstallRecords).not.toHaveBeenCalled();
expect(result).toMatchObject({ changes: [], warnings: [] });
expect(result).toEqual({ changes: [], warnings: [], records: {} });
});
});