ewilliams28/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-08-24 11:25:50 -06:00
Code Issues Packages Projects Releases Wiki Activity

fix(release): serialize root package generation

Browse Source
This commit is contained in:
Vincent Koc
2026-07-10 16:06:58 -07:00
committed by Vincent Koc
parent 00848e2bcb
commit a5582cc02b
2 changed files with 35 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/release-preflight.mjs
+3 -2
View File
@@ -27,7 +27,7 @@ const releaseTasks = [
name: "npm shrinkwraps",
scopes: ["dependencies", "version"],
fix: ["deps:shrinkwrap:changed:generate"],
fixAfter: ["plugin-versions"],
fixAfter: ["plugin-versions", "plugin-sdk-exports"],
check: ["deps:shrinkwrap:check"],
},
{
@@ -35,7 +35,7 @@ const releaseTasks = [
name: "plugin inventory",
scopes: ["plugins", "version"],
fix: ["plugins:inventory:gen"],
fixAfter: ["plugin-versions"],
fixAfter: ["plugin-versions", "plugin-sdk-exports"],
check: ["plugins:inventory:check"],
},
{
@@ -65,6 +65,7 @@ const releaseTasks = [
name: "plugin SDK exports",
scopes: ["plugin-sdk"],
fix: ["plugin-sdk:sync-exports"],
fixAfter: ["plugin-versions"],
check: ["plugin-sdk:check-exports"],
},
{
test/scripts/release-preflight.test.ts
+32 -2
View File
@@ -35,9 +35,10 @@ afterEach(() => {
cleanupTempDirs(tempDirs);
});
function makeFakePnpm(): { binDir: string; logPath: string } {
function makeFakePnpm(): { binDir: string; eventsPath: string; logPath: string } {
const root = makeTempDir(tempDirs, "openclaw-release-preflight-");
const binDir = join(root, "bin");
const eventsPath = join(root, "pnpm-events.log");
const logPath = join(root, "pnpm.log");
mkdirSync(binDir);
const pnpmPath = join(binDir, "pnpm");
@@ -48,17 +49,19 @@ import { appendFileSync } from "node:fs";
const command = process.argv.slice(2).join(" ");
appendFileSync(process.env.OPENCLAW_RELEASE_PREFLIGHT_PNPM_LOG, command + "\\n");
appendFileSync(process.env.OPENCLAW_RELEASE_PREFLIGHT_PNPM_EVENTS, "start " + command + "\\n");
const delayMs = Number(process.env.OPENCLAW_RELEASE_PREFLIGHT_DELAY_MS ?? "0");
if (delayMs > 0) {
Atomics.wait(new Int32Array(new SharedArrayBuffer(4)), 0, 0, delayMs);
}
appendFileSync(process.env.OPENCLAW_RELEASE_PREFLIGHT_PNPM_EVENTS, "end " + command + "\\n");
const failures = new Set((process.env.OPENCLAW_RELEASE_PREFLIGHT_FAIL_COMMANDS ?? "").split(";").filter(Boolean));
process.exit(failures.has(command) ? 7 : 0);
`,
{ mode: 0o755 },
);
chmodSync(pnpmPath, 0o755);
return { binDir, logPath };
return { binDir, eventsPath, logPath };
}
function runPreflight(
@@ -76,6 +79,7 @@ function runPreflight(
...(fakePnpm
? {
OPENCLAW_RELEASE_PREFLIGHT_PNPM_LOG: fakePnpm.logPath,
OPENCLAW_RELEASE_PREFLIGHT_PNPM_EVENTS: fakePnpm.eventsPath,
PATH: `${fakePnpm.binDir}${delimiter}${process.env.PATH ?? ""}`,
}
: {}),
@@ -149,6 +153,7 @@ describe("scripts/release-preflight.mjs", () => {
env: {
...process.env,
OPENCLAW_RELEASE_PREFLIGHT_FAIL_COMMANDS: "deps:shrinkwrap:changed:generate",
OPENCLAW_RELEASE_PREFLIGHT_PNPM_EVENTS: fakePnpm.eventsPath,
OPENCLAW_RELEASE_PREFLIGHT_PNPM_LOG: fakePnpm.logPath,
PATH: `${fakePnpm.binDir}${delimiter}${process.env.PATH ?? ""}`,
},
@@ -161,6 +166,31 @@ describe("scripts/release-preflight.mjs", () => {
);
});
it("serializes the root package writer before generated-artifact readers", () => {
const fakePnpm = makeFakePnpm();
const root = makeReleaseFixture();
const result = runPreflight(
["--fix", "--jobs", "8"],
fakePnpm,
{
OPENCLAW_RELEASE_PREFLIGHT_DELAY_MS: "40",
},
root,
);
const events = readPnpmLog(fakePnpm.eventsPath);
expect(result.status).toBe(0);
expect(events.indexOf("end plugins:sync")).toBeLessThan(
events.indexOf("start plugin-sdk:sync-exports"),
);
expect(events.indexOf("end plugin-sdk:sync-exports")).toBeLessThan(
events.indexOf("start deps:shrinkwrap:changed:generate"),
);
expect(events.indexOf("end plugin-sdk:sync-exports")).toBeLessThan(
events.indexOf("start plugins:inventory:gen"),
);
});
it("runs only version-owned generators and checks for version prep", () => {
const fakePnpm = makeFakePnpm();
const root = makeReleaseFixture();