ewilliams28/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-08-12 21:53:00 -06:00
Code Issues Packages Projects Releases Wiki Activity

test(codex): keep fingerprint backport focused

Browse Source
This commit is contained in:
Vincent Koc
2026-07-11 16:45:12 -07:00
parent 491e42e6d5
commit 7b9220777f
1 changed files with 0 additions and 103 deletions
Download Patch File Download Diff File Expand all files Collapse all files
extensions/codex/src/app-server/thread-lifecycle.user-mcp-servers.test.ts
-103
View File
@@ -527,109 +527,6 @@ describe("startOrResumeThread — user mcp.servers projection (regression: #8081
expect(startParams?.config?.mcp_servers).toBeUndefined();
});
it("starts a new thread when a user MCP Authorization bearer changes without storing the bearer", async () => {
const sessionFile = path.join(tempDir, "session.jsonl");
registerCodexTestSessionIdentity(sessionFile, "session-1", "agent:main:session-1");
const workspaceDir = path.join(tempDir, "workspace");
const createConfig = (authorization: string) =>
({
mcp: {
servers: {
ducktape: {
transport: "streamable-http",
url: "https://agents.ducktape.xyz/mcp",
headers: {
Authorization: authorization,
"x-tenant": "keep",
},
},
},
},
}) as unknown as EmbeddedRunAttemptParams["config"];
const request = vi.fn(async (method: string, _params: unknown) => {
if (method === "thread/start") {
return threadStartResult("thread-with-current-bearer");
}
if (method === "thread/resume") {
return threadResumeResult("thread-with-stale-bearer");
}
throw new Error(`unexpected method: ${method}`);
});
await startOrResumeThread({
client: { request } as never,
params: createParams(sessionFile, workspaceDir, createConfig("Bearer access-token-one")),
cwd: workspaceDir,
dynamicTools: [],
appServer: createAppServerOptions(),
});
const firstBinding = await readCodexAppServerBinding(sessionFile);
expect(firstBinding?.userMcpServersFingerprint).toMatch(/^sha256:[a-f0-9]{64}$/);
expect(firstBinding?.userMcpServersFingerprint).not.toContain("access-token-one");
request.mockClear();
await startOrResumeThread({
client: { request } as never,
params: createParams(sessionFile, workspaceDir, createConfig("Bearer access-token-two")),
cwd: workspaceDir,
dynamicTools: [],
appServer: createAppServerOptions(),
});
expect(request.mock.calls.map(([method]) => method)).toEqual(["thread/start"]);
const startParams = request.mock.calls[0]?.[1] as {
config?: { mcp_servers?: Record<string, { http_headers?: Record<string, string> }> };
};
expect(startParams?.config?.mcp_servers?.ducktape?.http_headers?.Authorization).toBe(
"Bearer access-token-two",
);
const secondBinding = await readCodexAppServerBinding(sessionFile);
expect(secondBinding?.userMcpServersFingerprint).toMatch(/^sha256:[a-f0-9]{64}$/);
expect(secondBinding?.userMcpServersFingerprint).not.toContain("access-token-two");
expect(secondBinding?.userMcpServersFingerprint).not.toBe(
firstBinding?.userMcpServersFingerprint,
);
});
it("omits MCP OAuth servers instead of sending bearers to a remote app-server", async () => {
const sessionFile = path.join(tempDir, "session.jsonl");
const workspaceDir = path.join(tempDir, "workspace");
const request = vi.fn(async (method: string, _params: unknown) => {
if (method === "thread/start") {
return threadStartResult("thread-without-oauth-mcp");
}
throw new Error(`unexpected method: ${method}`);
});
await startOrResumeThread({
client: { request } as never,
params: createParams(sessionFile, workspaceDir, {
mcp: {
servers: {
ducktape: {
transport: "streamable-http",
url: "https://agents.ducktape.xyz/mcp",
auth: "oauth",
oauth: { authProfileId: "ducktape:mcp" },
},
},
},
} as unknown as EmbeddedRunAttemptParams["config"]),
cwd: workspaceDir,
dynamicTools: [],
appServer: {
...createAppServerOptions(),
connectionClass: "remote",
},
});
const startParams = request.mock.calls[0]?.[1] as {
config?: { mcp_servers?: Record<string, unknown> };
};
expect(startParams?.config?.mcp_servers).toBeUndefined();
});
it("resends user MCP config when resuming a thread with the matching fingerprint", async () => {
const sessionFile = path.join(tempDir, "session.jsonl");
const workspaceDir = path.join(tempDir, "workspace");