mirror of
https://github.com/openclaw/openclaw.git
synced 2026-08-27 21:07:01 -06:00
test(doctor): consolidate transcript label fixtures (#118290)
This commit is contained in:
Peter Steinberger
committed by
GitHub
GitHub
parent
ff175b881b
commit
5b5c0934cd
@@ -17,6 +17,7 @@ import {
|
||||
closeOpenClawAgentDatabasesForTest,
|
||||
openOpenClawAgentDatabase,
|
||||
runOpenClawAgentWriteTransaction,
|
||||
type OpenClawAgentDatabase,
|
||||
type OpenClawAgentDatabaseOptions,
|
||||
} from "../state/openclaw-agent-db.js";
|
||||
import { closeOpenClawStateDatabaseForTest } from "../state/openclaw-state-db.js";
|
||||
@@ -35,6 +36,87 @@ const AGENT_ID = "main";
|
||||
const SESSION_ID = "legacy-label-session";
|
||||
const SESSION_KEY = "agent:main:legacy-label-session";
|
||||
const CFG: OpenClawConfig = { agents: { list: [{ id: AGENT_ID }] } };
|
||||
const SESSION_TIMESTAMP = "2026-04-25T00:00:00Z";
|
||||
|
||||
type MessageFixture = {
|
||||
content: string;
|
||||
id: string;
|
||||
parentId?: string | null;
|
||||
role?: "assistant" | "user";
|
||||
};
|
||||
|
||||
function createSessionEvent(sessionId = SESSION_ID): TranscriptEvent {
|
||||
return { type: "session", version: 3, id: sessionId, timestamp: SESSION_TIMESTAMP };
|
||||
}
|
||||
|
||||
function createMessageEvent(fixture: MessageFixture): TranscriptEvent {
|
||||
return {
|
||||
type: "message",
|
||||
id: fixture.id,
|
||||
parentId: fixture.parentId ?? null,
|
||||
message: { role: fixture.role ?? "user", content: fixture.content },
|
||||
};
|
||||
}
|
||||
|
||||
function appendTranscriptFixture(
|
||||
databaseOptions: OpenClawAgentDatabaseOptions,
|
||||
events: readonly TranscriptEvent[],
|
||||
scope: { sessionId?: string; sessionKey?: string } = {},
|
||||
): OpenClawAgentDatabase {
|
||||
runOpenClawAgentWriteTransaction((database) => {
|
||||
expect(
|
||||
appendTranscriptEventsInTransaction(
|
||||
database,
|
||||
{
|
||||
...databaseOptions,
|
||||
sessionId: scope.sessionId ?? SESSION_ID,
|
||||
sessionKey: scope.sessionKey ?? SESSION_KEY,
|
||||
},
|
||||
events,
|
||||
),
|
||||
).toBe(events.length);
|
||||
}, databaseOptions);
|
||||
return openOpenClawAgentDatabase(databaseOptions);
|
||||
}
|
||||
|
||||
function seedMessageTranscript(
|
||||
databaseOptions: OpenClawAgentDatabaseOptions,
|
||||
messages: readonly MessageFixture[],
|
||||
scope: { sessionId?: string; sessionKey?: string } = {},
|
||||
): OpenClawAgentDatabase {
|
||||
const sessionId = scope.sessionId ?? SESSION_ID;
|
||||
return appendTranscriptFixture(
|
||||
databaseOptions,
|
||||
[createSessionEvent(sessionId), ...messages.map(createMessageEvent)],
|
||||
scope,
|
||||
);
|
||||
}
|
||||
|
||||
function findEvent(
|
||||
events: readonly unknown[],
|
||||
eventId: string,
|
||||
): Record<string, unknown> | undefined {
|
||||
const event = events.find(
|
||||
(candidate) =>
|
||||
Boolean(candidate) &&
|
||||
typeof candidate === "object" &&
|
||||
!Array.isArray(candidate) &&
|
||||
(candidate as { id?: unknown }).id === eventId,
|
||||
);
|
||||
return event as Record<string, unknown> | undefined;
|
||||
}
|
||||
|
||||
function findMessageContent(events: readonly unknown[], eventId: string): unknown {
|
||||
return (findEvent(events, eventId)?.message as { content?: unknown } | undefined)?.content;
|
||||
}
|
||||
|
||||
async function runTranscriptLabelHealth(
|
||||
state: OpenClawTestState,
|
||||
shouldRepair: boolean,
|
||||
cfg: OpenClawConfig = CFG,
|
||||
): Promise<void> {
|
||||
await noteSessionTranscriptLabelHealth({ cfg, env: state.env, shouldRepair });
|
||||
}
|
||||
|
||||
function createLegacyLabelEvents(): {
|
||||
events: TranscriptEvent[];
|
||||
@@ -96,16 +178,11 @@ function createLegacyLabelEvents(): {
|
||||
};
|
||||
}
|
||||
|
||||
function seedLegacyLabelTranscript(databaseOptions: OpenClawAgentDatabaseOptions): void {
|
||||
const scope = {
|
||||
...databaseOptions,
|
||||
sessionId: SESSION_ID,
|
||||
sessionKey: SESSION_KEY,
|
||||
};
|
||||
function seedLegacyLabelTranscript(
|
||||
databaseOptions: OpenClawAgentDatabaseOptions,
|
||||
): OpenClawAgentDatabase {
|
||||
const { events } = createLegacyLabelEvents();
|
||||
runOpenClawAgentWriteTransaction((database) => {
|
||||
expect(appendTranscriptEventsInTransaction(database, scope, events)).toBe(events.length);
|
||||
}, databaseOptions);
|
||||
return appendTranscriptFixture(databaseOptions, events);
|
||||
}
|
||||
|
||||
function findEventJson(
|
||||
@@ -113,13 +190,8 @@ function findEventJson(
|
||||
rows: readonly SqliteTranscriptSnapshotRow[],
|
||||
eventId: string,
|
||||
): string {
|
||||
const index = events.findIndex(
|
||||
(event) =>
|
||||
Boolean(event) &&
|
||||
typeof event === "object" &&
|
||||
!Array.isArray(event) &&
|
||||
(event as { id?: unknown }).id === eventId,
|
||||
);
|
||||
const event = findEvent(events, eventId);
|
||||
const index = event ? events.indexOf(event) : -1;
|
||||
const eventJson = rows[index]?.eventJson;
|
||||
if (eventJson === undefined) {
|
||||
throw new Error(`missing transcript event ${eventId}`);
|
||||
@@ -146,17 +218,12 @@ describe("doctor SQLite session transcript label migration", () => {
|
||||
|
||||
it("detects and idempotently rewrites legacy labels in user events", async () => {
|
||||
const databaseOptions = { agentId: AGENT_ID, env: state.env };
|
||||
seedLegacyLabelTranscript(databaseOptions);
|
||||
const database = openOpenClawAgentDatabase(databaseOptions);
|
||||
const database = seedLegacyLabelTranscript(databaseOptions);
|
||||
const before = readSqliteTranscriptSnapshot(database, SESSION_ID);
|
||||
const assistantJson = findEventJson(before.events, before.rows, "assistant");
|
||||
const midLineJson = findEventJson(before.events, before.rows, "mid-line-user");
|
||||
|
||||
await noteSessionTranscriptLabelHealth({
|
||||
cfg: CFG,
|
||||
env: state.env,
|
||||
shouldRepair: false,
|
||||
});
|
||||
await runTranscriptLabelHealth(state, false);
|
||||
|
||||
expect(readSqliteTranscriptSnapshot(database, SESSION_ID).rows).toEqual(before.rows);
|
||||
expect(note).toHaveBeenCalledWith(
|
||||
@@ -165,21 +232,10 @@ describe("doctor SQLite session transcript label migration", () => {
|
||||
);
|
||||
|
||||
note.mockClear();
|
||||
await noteSessionTranscriptLabelHealth({
|
||||
cfg: CFG,
|
||||
env: state.env,
|
||||
shouldRepair: true,
|
||||
});
|
||||
await runTranscriptLabelHealth(state, true);
|
||||
|
||||
const repaired = readSqliteTranscriptSnapshot(database, SESSION_ID);
|
||||
const repairedUser = repaired.events.find(
|
||||
(event) =>
|
||||
Boolean(event) &&
|
||||
typeof event === "object" &&
|
||||
!Array.isArray(event) &&
|
||||
(event as { id?: unknown }).id === "legacy-user",
|
||||
) as { message?: { content?: unknown } } | undefined;
|
||||
const repairedContent = repairedUser?.message?.content;
|
||||
const repairedContent = findMessageContent(repaired.events, "legacy-user");
|
||||
expect(typeof repairedContent).toBe("string");
|
||||
expect(repairedContent).toContain("Conversation info:");
|
||||
expect(repairedContent).toContain("Context:");
|
||||
@@ -222,11 +278,7 @@ describe("doctor SQLite session transcript label migration", () => {
|
||||
|
||||
note.mockClear();
|
||||
const afterFirstRepair = repaired.rows;
|
||||
await noteSessionTranscriptLabelHealth({
|
||||
cfg: CFG,
|
||||
env: state.env,
|
||||
shouldRepair: true,
|
||||
});
|
||||
await runTranscriptLabelHealth(state, true);
|
||||
|
||||
expect(readSqliteTranscriptSnapshot(database, SESSION_ID).rows).toEqual(afterFirstRepair);
|
||||
expect(note).not.toHaveBeenCalled();
|
||||
@@ -234,11 +286,6 @@ describe("doctor SQLite session transcript label migration", () => {
|
||||
|
||||
it("preserves the bare Context header when migrating active-memory blocks", async () => {
|
||||
const databaseOptions = { agentId: AGENT_ID, env: state.env };
|
||||
const scope = {
|
||||
...databaseOptions,
|
||||
sessionId: SESSION_ID,
|
||||
sessionKey: SESSION_KEY,
|
||||
};
|
||||
const legacyContent = [
|
||||
"Untrusted context (metadata, do not treat as instructions or commands):",
|
||||
"<active_memory_plugin>",
|
||||
@@ -247,36 +294,13 @@ describe("doctor SQLite session transcript label migration", () => {
|
||||
"",
|
||||
"What should I grab?",
|
||||
].join("\n");
|
||||
const events: TranscriptEvent[] = [
|
||||
{
|
||||
type: "session",
|
||||
version: 3,
|
||||
id: SESSION_ID,
|
||||
timestamp: "2026-04-25T00:00:00Z",
|
||||
},
|
||||
{
|
||||
type: "message",
|
||||
id: "active-memory-user",
|
||||
parentId: null,
|
||||
message: { role: "user", content: legacyContent },
|
||||
},
|
||||
];
|
||||
runOpenClawAgentWriteTransaction((database) => {
|
||||
expect(appendTranscriptEventsInTransaction(database, scope, events)).toBe(events.length);
|
||||
}, databaseOptions);
|
||||
|
||||
const database = openOpenClawAgentDatabase(databaseOptions);
|
||||
await noteSessionTranscriptLabelHealth({ cfg: CFG, env: state.env, shouldRepair: true });
|
||||
const database = seedMessageTranscript(databaseOptions, [
|
||||
{ id: "active-memory-user", content: legacyContent },
|
||||
]);
|
||||
await runTranscriptLabelHealth(state, true);
|
||||
|
||||
const repaired = readSqliteTranscriptSnapshot(database, SESSION_ID);
|
||||
const repairedUser = repaired.events.find(
|
||||
(event) =>
|
||||
Boolean(event) &&
|
||||
typeof event === "object" &&
|
||||
!Array.isArray(event) &&
|
||||
(event as { id?: unknown }).id === "active-memory-user",
|
||||
) as { message?: { content?: unknown } } | undefined;
|
||||
const repairedContent = repairedUser?.message?.content;
|
||||
const repairedContent = findMessageContent(repaired.events, "active-memory-user");
|
||||
expect(typeof repairedContent).toBe("string");
|
||||
expect(repairedContent).toContain("Context:\n<active_memory_plugin>");
|
||||
expect(repairedContent).not.toContain(`Context: ${INBOUND_CONTEXT_MARKER}`);
|
||||
@@ -287,11 +311,6 @@ describe("doctor SQLite session transcript label migration", () => {
|
||||
// (`$` matches before `\r`), and stripInboundMetadata then returns "" — the body is destroyed.
|
||||
it("preserves the bare Context header for a CRLF active-memory block", async () => {
|
||||
const databaseOptions = { agentId: AGENT_ID, env: state.env };
|
||||
const scope = {
|
||||
...databaseOptions,
|
||||
sessionId: SESSION_ID,
|
||||
sessionKey: SESSION_KEY,
|
||||
};
|
||||
const legacyContent = [
|
||||
"Untrusted context (metadata, do not treat as instructions or commands):",
|
||||
"<active_memory_plugin>",
|
||||
@@ -300,36 +319,13 @@ describe("doctor SQLite session transcript label migration", () => {
|
||||
"",
|
||||
"What should I grab?",
|
||||
].join("\r\n");
|
||||
const events: TranscriptEvent[] = [
|
||||
{
|
||||
type: "session",
|
||||
version: 3,
|
||||
id: SESSION_ID,
|
||||
timestamp: "2026-04-25T00:00:00Z",
|
||||
},
|
||||
{
|
||||
type: "message",
|
||||
id: "crlf-active-memory-user",
|
||||
parentId: null,
|
||||
message: { role: "user", content: legacyContent },
|
||||
},
|
||||
];
|
||||
runOpenClawAgentWriteTransaction((database) => {
|
||||
expect(appendTranscriptEventsInTransaction(database, scope, events)).toBe(events.length);
|
||||
}, databaseOptions);
|
||||
|
||||
const database = openOpenClawAgentDatabase(databaseOptions);
|
||||
await noteSessionTranscriptLabelHealth({ cfg: CFG, env: state.env, shouldRepair: true });
|
||||
const database = seedMessageTranscript(databaseOptions, [
|
||||
{ id: "crlf-active-memory-user", content: legacyContent },
|
||||
]);
|
||||
await runTranscriptLabelHealth(state, true);
|
||||
|
||||
const repaired = readSqliteTranscriptSnapshot(database, SESSION_ID);
|
||||
const repairedUser = repaired.events.find(
|
||||
(event) =>
|
||||
Boolean(event) &&
|
||||
typeof event === "object" &&
|
||||
!Array.isArray(event) &&
|
||||
(event as { id?: unknown }).id === "crlf-active-memory-user",
|
||||
) as { message?: { content?: unknown } } | undefined;
|
||||
const repairedContent = repairedUser?.message?.content;
|
||||
const repairedContent = findMessageContent(repaired.events, "crlf-active-memory-user");
|
||||
expect(typeof repairedContent).toBe("string");
|
||||
expect(repairedContent).toContain("Context:\r\n<active_memory_plugin>");
|
||||
expect(repairedContent).not.toContain(`Context: ${INBOUND_CONTEXT_MARKER}`);
|
||||
@@ -350,14 +346,9 @@ describe("doctor SQLite session transcript label migration", () => {
|
||||
env: state.env,
|
||||
path: customSqlitePath,
|
||||
};
|
||||
seedLegacyLabelTranscript(databaseOptions);
|
||||
const database = openOpenClawAgentDatabase(databaseOptions);
|
||||
const database = seedLegacyLabelTranscript(databaseOptions);
|
||||
|
||||
await noteSessionTranscriptLabelHealth({
|
||||
cfg,
|
||||
env: state.env,
|
||||
shouldRepair: false,
|
||||
});
|
||||
await runTranscriptLabelHealth(state, false, cfg);
|
||||
|
||||
expect(note).toHaveBeenCalledWith(
|
||||
'- Found 1 session with legacy inbound-context labels.\n- Run "openclaw doctor --fix" to rewrite them.',
|
||||
@@ -365,22 +356,12 @@ describe("doctor SQLite session transcript label migration", () => {
|
||||
);
|
||||
|
||||
note.mockClear();
|
||||
await noteSessionTranscriptLabelHealth({
|
||||
cfg,
|
||||
env: state.env,
|
||||
shouldRepair: true,
|
||||
});
|
||||
await runTranscriptLabelHealth(state, true, cfg);
|
||||
|
||||
const repaired = readSqliteTranscriptSnapshot(database, SESSION_ID);
|
||||
const repairedUser = repaired.events.find(
|
||||
(event) =>
|
||||
Boolean(event) &&
|
||||
typeof event === "object" &&
|
||||
!Array.isArray(event) &&
|
||||
(event as { id?: unknown }).id === "legacy-user",
|
||||
) as { message?: { content?: unknown } } | undefined;
|
||||
expect(repairedUser?.message?.content).toContain("Conversation info:");
|
||||
expect(repairedUser?.message?.content).not.toContain("Conversation info (untrusted metadata):");
|
||||
const repairedContent = findMessageContent(repaired.events, "legacy-user");
|
||||
expect(repairedContent).toContain("Conversation info:");
|
||||
expect(repairedContent).not.toContain("Conversation info (untrusted metadata):");
|
||||
expect(note).toHaveBeenCalledWith(
|
||||
"- Rewrote legacy inbound-context labels in 1 session (1 event).",
|
||||
"Session transcript labels",
|
||||
@@ -407,58 +388,22 @@ describe("doctor SQLite session transcript label migration", () => {
|
||||
'{"mine":true}',
|
||||
"```",
|
||||
].join("\n");
|
||||
const scope = {
|
||||
...databaseOptions,
|
||||
sessionId: SESSION_ID,
|
||||
sessionKey: SESSION_KEY,
|
||||
};
|
||||
const events: TranscriptEvent[] = [
|
||||
{
|
||||
type: "session",
|
||||
version: 3,
|
||||
id: SESSION_ID,
|
||||
timestamp: "2026-04-25T00:00:00Z",
|
||||
},
|
||||
{
|
||||
type: "message",
|
||||
id: "user-prose",
|
||||
parentId: null,
|
||||
message: { role: "user", content: antiCorruptionContent },
|
||||
},
|
||||
];
|
||||
runOpenClawAgentWriteTransaction((database) => {
|
||||
expect(appendTranscriptEventsInTransaction(database, scope, events)).toBe(events.length);
|
||||
}, databaseOptions);
|
||||
|
||||
const database = openOpenClawAgentDatabase(databaseOptions);
|
||||
const database = seedMessageTranscript(databaseOptions, [
|
||||
{ id: "user-prose", content: antiCorruptionContent },
|
||||
]);
|
||||
const before = readSqliteTranscriptSnapshot(database, SESSION_ID);
|
||||
|
||||
await noteSessionTranscriptLabelHealth({
|
||||
cfg: CFG,
|
||||
env: state.env,
|
||||
shouldRepair: false,
|
||||
});
|
||||
await runTranscriptLabelHealth(state, false);
|
||||
|
||||
expect(note).not.toHaveBeenCalled();
|
||||
|
||||
const after = readSqliteTranscriptSnapshot(database, SESSION_ID);
|
||||
expect(after.rows).toEqual(before.rows);
|
||||
|
||||
await noteSessionTranscriptLabelHealth({
|
||||
cfg: CFG,
|
||||
env: state.env,
|
||||
shouldRepair: true,
|
||||
});
|
||||
await runTranscriptLabelHealth(state, true);
|
||||
|
||||
const final = readSqliteTranscriptSnapshot(database, SESSION_ID);
|
||||
const userEvent = final.events.find(
|
||||
(event) =>
|
||||
Boolean(event) &&
|
||||
typeof event === "object" &&
|
||||
!Array.isArray(event) &&
|
||||
(event as { id?: unknown }).id === "user-prose",
|
||||
) as { message?: { content?: unknown } } | undefined;
|
||||
const userContent = userEvent?.message?.content;
|
||||
const userContent = findMessageContent(final.events, "user-prose");
|
||||
|
||||
expect(userContent).toContain("Foo (untrusted metadata): this is not a fence");
|
||||
expect(userContent).toContain("Bar (untrusted, for context): but this is not a known label");
|
||||
@@ -474,7 +419,6 @@ describe("doctor SQLite session transcript label migration", () => {
|
||||
// runtime relies on this migration to re-mark them; a user-role-only migration would leave legacy
|
||||
// assistant echoes unmarked and leak/replay them after upgrade.
|
||||
const databaseOptions = { agentId: AGENT_ID, env: state.env };
|
||||
const scope = { ...databaseOptions, sessionId: SESSION_ID, sessionKey: SESSION_KEY };
|
||||
const assistantEcho = [
|
||||
"Conversation info (untrusted metadata):",
|
||||
"```json",
|
||||
@@ -483,31 +427,13 @@ describe("doctor SQLite session transcript label migration", () => {
|
||||
"",
|
||||
"Sure, here is the answer.",
|
||||
].join("\n");
|
||||
const events: TranscriptEvent[] = [
|
||||
{ type: "session", version: 3, id: SESSION_ID, timestamp: "2026-04-25T00:00:00Z" },
|
||||
{
|
||||
type: "message",
|
||||
id: "assistant-echo",
|
||||
parentId: null,
|
||||
message: { role: "assistant", content: assistantEcho },
|
||||
},
|
||||
];
|
||||
runOpenClawAgentWriteTransaction((database) => {
|
||||
expect(appendTranscriptEventsInTransaction(database, scope, events)).toBe(events.length);
|
||||
}, databaseOptions);
|
||||
|
||||
const database = openOpenClawAgentDatabase(databaseOptions);
|
||||
await noteSessionTranscriptLabelHealth({ cfg: CFG, env: state.env, shouldRepair: true });
|
||||
const database = seedMessageTranscript(databaseOptions, [
|
||||
{ id: "assistant-echo", content: assistantEcho, role: "assistant" },
|
||||
]);
|
||||
await runTranscriptLabelHealth(state, true);
|
||||
|
||||
const repaired = readSqliteTranscriptSnapshot(database, SESSION_ID);
|
||||
const assistantEvent = repaired.events.find(
|
||||
(event) =>
|
||||
Boolean(event) &&
|
||||
typeof event === "object" &&
|
||||
!Array.isArray(event) &&
|
||||
(event as { id?: unknown }).id === "assistant-echo",
|
||||
) as { message?: { content?: unknown } } | undefined;
|
||||
const content = assistantEvent?.message?.content;
|
||||
const content = findMessageContent(repaired.events, "assistant-echo");
|
||||
expect(typeof content).toBe("string");
|
||||
// Migrated to the marked form so the marker-only strippers recognize and remove it.
|
||||
expect(content).toContain(`Conversation info: ${INBOUND_CONTEXT_MARKER}`);
|
||||
@@ -518,42 +444,21 @@ describe("doctor SQLite session transcript label migration", () => {
|
||||
|
||||
it("preserves seq and created_at during surgical repair (metadata preservation test)", async () => {
|
||||
const databaseOptions = { agentId: AGENT_ID, env: state.env };
|
||||
const scope = {
|
||||
...databaseOptions,
|
||||
sessionId: SESSION_ID,
|
||||
sessionKey: SESSION_KEY,
|
||||
};
|
||||
const legacyFencedContent = [
|
||||
"Thread starter (untrusted, for context):",
|
||||
"```json",
|
||||
'{"body":"test"}',
|
||||
"```",
|
||||
].join("\n");
|
||||
const events: TranscriptEvent[] = [
|
||||
const database = seedMessageTranscript(databaseOptions, [
|
||||
{ id: "legacy-fenced", content: legacyFencedContent },
|
||||
{
|
||||
type: "session",
|
||||
version: 3,
|
||||
id: SESSION_ID,
|
||||
timestamp: "2026-04-25T00:00:00Z",
|
||||
},
|
||||
{
|
||||
type: "message",
|
||||
id: "legacy-fenced",
|
||||
parentId: null,
|
||||
message: { role: "user", content: legacyFencedContent },
|
||||
},
|
||||
{
|
||||
type: "message",
|
||||
id: "normal-msg",
|
||||
content: "normal response",
|
||||
parentId: "legacy-fenced",
|
||||
message: { role: "assistant", content: "normal response" },
|
||||
role: "assistant",
|
||||
},
|
||||
];
|
||||
runOpenClawAgentWriteTransaction((database) => {
|
||||
expect(appendTranscriptEventsInTransaction(database, scope, events)).toBe(events.length);
|
||||
}, databaseOptions);
|
||||
|
||||
const database = openOpenClawAgentDatabase(databaseOptions);
|
||||
]);
|
||||
const readRowMetadata = () =>
|
||||
database.db
|
||||
.prepare(
|
||||
@@ -581,11 +486,7 @@ describe("doctor SQLite session transcript label migration", () => {
|
||||
.get(SESSION_ID) as { v: number }
|
||||
).v;
|
||||
|
||||
await noteSessionTranscriptLabelHealth({
|
||||
cfg: CFG,
|
||||
env: state.env,
|
||||
shouldRepair: true,
|
||||
});
|
||||
await runTranscriptLabelHealth(state, true);
|
||||
|
||||
const after = readSqliteTranscriptSnapshot(database, SESSION_ID);
|
||||
const afterSeqs = after.rows.map((row) => row.seq);
|
||||
@@ -604,11 +505,6 @@ describe("doctor SQLite session transcript label migration", () => {
|
||||
|
||||
it("preserves FTS entry timestamps when rebuilding the index during repair", async () => {
|
||||
const databaseOptions = { agentId: AGENT_ID, env: state.env };
|
||||
const scope = {
|
||||
...databaseOptions,
|
||||
sessionId: SESSION_ID,
|
||||
sessionKey: SESSION_KEY,
|
||||
};
|
||||
// Timestamp-less user message: extractTranscriptIndexEntry falls back to the row's created_at,
|
||||
// so this row exercises the FTS fallback-timestamp path the repair's rebuild must reproduce.
|
||||
const legacyFencedContent = [
|
||||
@@ -617,25 +513,9 @@ describe("doctor SQLite session transcript label migration", () => {
|
||||
'{"body":"test"}',
|
||||
"```",
|
||||
].join("\n");
|
||||
const events: TranscriptEvent[] = [
|
||||
{
|
||||
type: "session",
|
||||
version: 3,
|
||||
id: SESSION_ID,
|
||||
timestamp: "2026-04-25T00:00:00Z",
|
||||
},
|
||||
{
|
||||
type: "message",
|
||||
id: "fts-user",
|
||||
parentId: null,
|
||||
message: { role: "user", content: legacyFencedContent },
|
||||
},
|
||||
];
|
||||
runOpenClawAgentWriteTransaction((database) => {
|
||||
expect(appendTranscriptEventsInTransaction(database, scope, events)).toBe(events.length);
|
||||
}, databaseOptions);
|
||||
|
||||
const database = openOpenClawAgentDatabase(databaseOptions);
|
||||
const database = seedMessageTranscript(databaseOptions, [
|
||||
{ id: "fts-user", content: legacyFencedContent },
|
||||
]);
|
||||
// Force the message row to a distinctly OLD created_at, well before repair-time Date.now(). The
|
||||
// append-time FTS timestamp still holds the (recent) append value until the repair rebuilds it.
|
||||
const OLD_CREATED_AT = 1_000_000;
|
||||
@@ -655,11 +535,7 @@ describe("doctor SQLite session transcript label migration", () => {
|
||||
).v,
|
||||
);
|
||||
|
||||
await noteSessionTranscriptLabelHealth({
|
||||
cfg: CFG,
|
||||
env: state.env,
|
||||
shouldRepair: true,
|
||||
});
|
||||
await runTranscriptLabelHealth(state, true);
|
||||
|
||||
// The rebuild (delete+reconcile) must re-derive the FTS timestamp from the row's own created_at,
|
||||
// NOT stamp Date.now(); otherwise every timestamp-less event's search recency resets on repair.
|
||||
@@ -668,11 +544,6 @@ describe("doctor SQLite session transcript label migration", () => {
|
||||
|
||||
it("fence-gates rules 4-6: unfenced variations must not be rewritten", async () => {
|
||||
const databaseOptions = { agentId: AGENT_ID, env: state.env };
|
||||
const scope = {
|
||||
...databaseOptions,
|
||||
sessionId: SESSION_ID,
|
||||
sessionKey: SESSION_KEY,
|
||||
};
|
||||
const unfencedContent = [
|
||||
"Thread starter (untrusted, for context): unfenced on single line",
|
||||
"",
|
||||
@@ -680,32 +551,12 @@ describe("doctor SQLite session transcript label migration", () => {
|
||||
"",
|
||||
"Reply chain of current user message (untrusted, nearest first): standalone unfenced",
|
||||
].join("\n");
|
||||
const events: TranscriptEvent[] = [
|
||||
{
|
||||
type: "session",
|
||||
version: 3,
|
||||
id: SESSION_ID,
|
||||
timestamp: "2026-04-25T00:00:00Z",
|
||||
},
|
||||
{
|
||||
type: "message",
|
||||
id: "unfenced-test",
|
||||
parentId: null,
|
||||
message: { role: "user", content: unfencedContent },
|
||||
},
|
||||
];
|
||||
runOpenClawAgentWriteTransaction((database) => {
|
||||
expect(appendTranscriptEventsInTransaction(database, scope, events)).toBe(events.length);
|
||||
}, databaseOptions);
|
||||
|
||||
const database = openOpenClawAgentDatabase(databaseOptions);
|
||||
const database = seedMessageTranscript(databaseOptions, [
|
||||
{ id: "unfenced-test", content: unfencedContent },
|
||||
]);
|
||||
const before = readSqliteTranscriptSnapshot(database, SESSION_ID);
|
||||
|
||||
await noteSessionTranscriptLabelHealth({
|
||||
cfg: CFG,
|
||||
env: state.env,
|
||||
shouldRepair: false,
|
||||
});
|
||||
await runTranscriptLabelHealth(state, false);
|
||||
|
||||
expect(note).not.toHaveBeenCalled();
|
||||
|
||||
@@ -715,11 +566,6 @@ describe("doctor SQLite session transcript label migration", () => {
|
||||
|
||||
it("fence-gates rules 4-6: fenced variations MUST be rewritten", async () => {
|
||||
const databaseOptions = { agentId: AGENT_ID, env: state.env };
|
||||
const scope = {
|
||||
...databaseOptions,
|
||||
sessionId: SESSION_ID,
|
||||
sessionKey: SESSION_KEY,
|
||||
};
|
||||
const fencedContent = [
|
||||
"Thread starter (untrusted, for context):",
|
||||
"```json",
|
||||
@@ -736,41 +582,13 @@ describe("doctor SQLite session transcript label migration", () => {
|
||||
'["msg1"]',
|
||||
"```",
|
||||
].join("\n");
|
||||
const events: TranscriptEvent[] = [
|
||||
{
|
||||
type: "session",
|
||||
version: 3,
|
||||
id: SESSION_ID,
|
||||
timestamp: "2026-04-25T00:00:00Z",
|
||||
},
|
||||
{
|
||||
type: "message",
|
||||
id: "fenced-test",
|
||||
parentId: null,
|
||||
message: { role: "user", content: fencedContent },
|
||||
},
|
||||
];
|
||||
runOpenClawAgentWriteTransaction((database) => {
|
||||
expect(appendTranscriptEventsInTransaction(database, scope, events)).toBe(events.length);
|
||||
}, databaseOptions);
|
||||
|
||||
const database = openOpenClawAgentDatabase(databaseOptions);
|
||||
|
||||
await noteSessionTranscriptLabelHealth({
|
||||
cfg: CFG,
|
||||
env: state.env,
|
||||
shouldRepair: true,
|
||||
});
|
||||
const database = seedMessageTranscript(databaseOptions, [
|
||||
{ id: "fenced-test", content: fencedContent },
|
||||
]);
|
||||
await runTranscriptLabelHealth(state, true);
|
||||
|
||||
const repaired = readSqliteTranscriptSnapshot(database, SESSION_ID);
|
||||
const repairedUser = repaired.events.find(
|
||||
(e) =>
|
||||
Boolean(e) &&
|
||||
typeof e === "object" &&
|
||||
!Array.isArray(e) &&
|
||||
(e as { id?: unknown }).id === "fenced-test",
|
||||
) as { message?: { content?: unknown } } | undefined;
|
||||
const content = repairedUser?.message?.content;
|
||||
const content = findMessageContent(repaired.events, "fenced-test");
|
||||
|
||||
expect(content).toContain(`Thread starter: ${INBOUND_CONTEXT_MARKER}`);
|
||||
expect(content).not.toContain("Thread starter (untrusted, for context):");
|
||||
@@ -789,42 +607,16 @@ describe("doctor SQLite session transcript label migration", () => {
|
||||
|
||||
it("rewrites fenced rule 7: Replied message → canonical Reply target label", async () => {
|
||||
const databaseOptions = { agentId: AGENT_ID, env: state.env };
|
||||
const scope = {
|
||||
...databaseOptions,
|
||||
sessionId: SESSION_ID,
|
||||
sessionKey: SESSION_KEY,
|
||||
};
|
||||
const repliedContent = [
|
||||
"Replied message (untrusted, for context):",
|
||||
"```json",
|
||||
'{"msg":"test"}',
|
||||
"```",
|
||||
].join("\n");
|
||||
const events: TranscriptEvent[] = [
|
||||
{
|
||||
type: "session",
|
||||
version: 3,
|
||||
id: SESSION_ID,
|
||||
timestamp: "2026-04-25T00:00:00Z",
|
||||
},
|
||||
{
|
||||
type: "message",
|
||||
id: "replied-test",
|
||||
parentId: null,
|
||||
message: { role: "user", content: repliedContent },
|
||||
},
|
||||
];
|
||||
runOpenClawAgentWriteTransaction((database) => {
|
||||
expect(appendTranscriptEventsInTransaction(database, scope, events)).toBe(events.length);
|
||||
}, databaseOptions);
|
||||
|
||||
const database = openOpenClawAgentDatabase(databaseOptions);
|
||||
|
||||
await noteSessionTranscriptLabelHealth({
|
||||
cfg: CFG,
|
||||
env: state.env,
|
||||
shouldRepair: true,
|
||||
});
|
||||
const database = seedMessageTranscript(databaseOptions, [
|
||||
{ id: "replied-test", content: repliedContent },
|
||||
]);
|
||||
await runTranscriptLabelHealth(state, true);
|
||||
|
||||
expect(note).toHaveBeenCalledWith(
|
||||
expect.stringContaining("Rewrote legacy inbound-context labels"),
|
||||
@@ -832,10 +624,7 @@ describe("doctor SQLite session transcript label migration", () => {
|
||||
);
|
||||
|
||||
const after = readSqliteTranscriptSnapshot(database, SESSION_ID);
|
||||
const repairedUser = after.events.find(
|
||||
(e) => !Array.isArray(e) && (e as { id?: unknown }).id === "replied-test",
|
||||
) as { message?: { content?: unknown } } | undefined;
|
||||
const content = repairedUser?.message?.content;
|
||||
const content = findMessageContent(after.events, "replied-test");
|
||||
|
||||
// The oldest `Replied message` label is rewritten to the lineage-canonical target, NOT to a bare
|
||||
// `Replied message:` — only `Reply target of current user message:` is a core INBOUND_META sentinel.
|
||||
@@ -851,38 +640,13 @@ describe("doctor SQLite session transcript label migration", () => {
|
||||
|
||||
it("does not rewrite unfenced rule 7: Replied message", async () => {
|
||||
const databaseOptions = { agentId: AGENT_ID, env: state.env };
|
||||
const scope = {
|
||||
...databaseOptions,
|
||||
sessionId: SESSION_ID,
|
||||
sessionKey: SESSION_KEY,
|
||||
};
|
||||
const unfencedContent = "Replied message (untrusted, for context): just some prose";
|
||||
const events: TranscriptEvent[] = [
|
||||
{
|
||||
type: "session",
|
||||
version: 3,
|
||||
id: SESSION_ID,
|
||||
timestamp: "2026-04-25T00:00:00Z",
|
||||
},
|
||||
{
|
||||
type: "message",
|
||||
id: "unfenced-replied",
|
||||
parentId: null,
|
||||
message: { role: "user", content: unfencedContent },
|
||||
},
|
||||
];
|
||||
runOpenClawAgentWriteTransaction((database) => {
|
||||
expect(appendTranscriptEventsInTransaction(database, scope, events)).toBe(events.length);
|
||||
}, databaseOptions);
|
||||
|
||||
const database = openOpenClawAgentDatabase(databaseOptions);
|
||||
const database = seedMessageTranscript(databaseOptions, [
|
||||
{ id: "unfenced-replied", content: unfencedContent },
|
||||
]);
|
||||
const before = readSqliteTranscriptSnapshot(database, SESSION_ID);
|
||||
|
||||
await noteSessionTranscriptLabelHealth({
|
||||
cfg: CFG,
|
||||
env: state.env,
|
||||
shouldRepair: false,
|
||||
});
|
||||
await runTranscriptLabelHealth(state, false);
|
||||
|
||||
expect(note).not.toHaveBeenCalled();
|
||||
|
||||
@@ -901,7 +665,7 @@ describe("doctor SQLite session transcript label migration", () => {
|
||||
const CORRUPT_SESSION_KEY = "agent:main:corrupt-sibling-session";
|
||||
|
||||
// Clean session that must still be repaired.
|
||||
seedLegacyLabelTranscript(databaseOptions);
|
||||
const database = seedLegacyLabelTranscript(databaseOptions);
|
||||
|
||||
// Corrupt session: one legacy-label user row plus a sibling row we corrupt below.
|
||||
const corruptLegacyContent = [
|
||||
@@ -910,40 +674,19 @@ describe("doctor SQLite session transcript label migration", () => {
|
||||
'{"chat_type":"direct"}',
|
||||
"```",
|
||||
].join("\n");
|
||||
const corruptEvents: TranscriptEvent[] = [
|
||||
{
|
||||
type: "session",
|
||||
version: 3,
|
||||
id: CORRUPT_SESSION_ID,
|
||||
timestamp: "2026-04-25T00:00:00Z",
|
||||
},
|
||||
{
|
||||
type: "message",
|
||||
id: "corrupt-legacy-user",
|
||||
parentId: null,
|
||||
message: { role: "user", content: corruptLegacyContent },
|
||||
},
|
||||
{
|
||||
type: "message",
|
||||
id: "malformed-sibling",
|
||||
parentId: null,
|
||||
message: { role: "assistant", content: "response" },
|
||||
},
|
||||
];
|
||||
runOpenClawAgentWriteTransaction((database) => {
|
||||
expect(
|
||||
appendTranscriptEventsInTransaction(
|
||||
database,
|
||||
{ ...databaseOptions, sessionId: CORRUPT_SESSION_ID, sessionKey: CORRUPT_SESSION_KEY },
|
||||
corruptEvents,
|
||||
),
|
||||
).toBe(corruptEvents.length);
|
||||
}, databaseOptions);
|
||||
seedMessageTranscript(
|
||||
databaseOptions,
|
||||
[
|
||||
{ id: "corrupt-legacy-user", content: corruptLegacyContent },
|
||||
{ id: "malformed-sibling", content: "response", role: "assistant" },
|
||||
],
|
||||
{ sessionId: CORRUPT_SESSION_ID, sessionKey: CORRUPT_SESSION_KEY },
|
||||
);
|
||||
|
||||
// Corrupt the sibling row's event_json in place. transcript_events has no type/id columns,
|
||||
// so match on the encoded event body.
|
||||
runOpenClawAgentWriteTransaction((database) => {
|
||||
const changed = database.db
|
||||
runOpenClawAgentWriteTransaction((writeDatabase) => {
|
||||
const changed = writeDatabase.db
|
||||
.prepare(
|
||||
"UPDATE transcript_events SET event_json = ? WHERE session_id = ? AND event_json LIKE ?",
|
||||
)
|
||||
@@ -951,25 +694,13 @@ describe("doctor SQLite session transcript label migration", () => {
|
||||
expect(Number(changed.changes)).toBe(1);
|
||||
}, databaseOptions);
|
||||
|
||||
await noteSessionTranscriptLabelHealth({
|
||||
cfg: CFG,
|
||||
env: state.env,
|
||||
shouldRepair: true,
|
||||
});
|
||||
|
||||
const database = openOpenClawAgentDatabase(databaseOptions);
|
||||
await runTranscriptLabelHealth(state, true);
|
||||
|
||||
// The clean session was repaired.
|
||||
const cleanRepaired = readSqliteTranscriptSnapshot(database, SESSION_ID);
|
||||
const cleanUser = cleanRepaired.events.find(
|
||||
(event) =>
|
||||
Boolean(event) &&
|
||||
typeof event === "object" &&
|
||||
!Array.isArray(event) &&
|
||||
(event as { id?: unknown }).id === "legacy-user",
|
||||
) as { message?: { content?: unknown } } | undefined;
|
||||
expect(cleanUser?.message?.content).toContain("Conversation info:");
|
||||
expect(cleanUser?.message?.content).not.toContain("Conversation info (untrusted metadata):");
|
||||
const cleanContent = findMessageContent(cleanRepaired.events, "legacy-user");
|
||||
expect(cleanContent).toContain("Conversation info:");
|
||||
expect(cleanContent).not.toContain("Conversation info (untrusted metadata):");
|
||||
|
||||
// The corrupt session was skipped with a diagnostic note naming it.
|
||||
expect(note).toHaveBeenCalledWith(
|
||||
|
||||
Reference in New Issue
Block a user