fix: parse cron task run ids strictly

This commit is contained in:
Peter Steinberger
2026-05-28 13:17:53 -04:00
parent 202ccf4cf7
commit 3bf86877c2
2 changed files with 32 additions and 2 deletions
@@ -420,6 +420,35 @@ describe("task-registry maintenance issue #60299", () => {
expect(storedTask.terminalSummary).toBe("done");
});
it("does not recover cron tasks from malformed run id timestamps", async () => {
const task = makeStaleTask({
runtime: "cron",
sourceId: "cron-job-run-log-ok",
runId: "cron:cron-job-run-log-ok:1e3",
});
const { currentTasks } = createTaskRegistryMaintenanceHarness({
tasks: [task],
cronRunLogEntries: {
"cron-job-run-log-ok": [
{
ts: 1250,
jobId: "cron-job-run-log-ok",
action: "finished",
status: "ok",
summary: "done",
runAtMs: 1000,
durationMs: 250,
},
],
},
});
expectMaintenanceCounts(previewTaskRegistryMaintenance(), { reconciled: 1, recovered: 0 });
expectMaintenanceCounts(await runTaskRegistryMaintenance(), { reconciled: 1, recovered: 0 });
expectTaskStatus(currentTasks, task.taskId, "lost");
});
it("recovers interrupted cron tasks from durable cron job state when run logs are absent", async () => {
const startedAt = Date.now() - GRACE_EXPIRED_MS;
const task = makeStaleTask({
+3 -2
View File
@@ -18,6 +18,7 @@ import { loadCronStoreSync, resolveCronStorePath } from "../cron/store.js";
import type { CronJob, CronStoreFile } from "../cron/types.js";
import { getAgentRunContext } from "../infra/agent-events.js";
import { getSessionBindingService } from "../infra/outbound/session-binding-service.js";
import { parseStrictNonNegativeInteger } from "../infra/parse-finite-number.js";
import { createSubsystemLogger } from "../logging/subsystem.js";
import {
isPluginStateDatabaseOpen,
@@ -337,8 +338,8 @@ function parseCronExecutionId(task: TaskRecord): CronExecutionId | undefined {
if (separator <= "cron:".length) {
return undefined;
}
const startedAt = Number(runId.slice(separator + 1));
if (!Number.isFinite(startedAt)) {
const startedAt = parseStrictNonNegativeInteger(runId.slice(separator + 1));
if (startedAt === undefined) {
return undefined;
}
const jobId = runId.slice("cron:".length, separator).trim();