fix(android): explicitly target notification intents (#127055)

This commit is contained in:
Vincent Koc
2026-08-20 23:48:16 -07:00
committed by GitHub
parent 8ec5ae0693
commit 2405b98b05
2 changed files with 12 additions and 2 deletions
@@ -109,7 +109,8 @@ internal fun conversationNotificationLaunchIntent(
context: Context,
target: ConversationNotificationTarget,
): Intent =
Intent(context, ConversationNotificationLaunchActivity::class.java)
Intent()
.setClass(context, ConversationNotificationLaunchActivity::class.java)
.setAction(actionOpenConversationNotification)
.setData(conversationNotificationIntentData(notificationIntentOpenPath, target))
.putConversationTarget(target)
@@ -142,7 +143,8 @@ internal fun conversationNotificationReplyIntent(
context: Context,
target: ConversationNotificationTarget,
): Intent =
Intent(context, ConversationReplyReceiver::class.java)
Intent()
.setClass(context, ConversationReplyReceiver::class.java)
.setAction(actionReplyConversationNotification)
.setData(conversationNotificationIntentData(notificationIntentReplyPath, target))
.putConversationTarget(target)
@@ -57,6 +57,14 @@ class ConversationNotificationsTest {
assertNotEquals(MainActivity::class.java.name, component.className)
}
@Test
fun replyIntentTargetsPrivateReceiver() {
val intent = conversationNotificationReplyIntent(context, target)
val component = requireNotNull(intent.component)
assertEquals(ConversationReplyReceiver::class.java.name, component.className)
}
@Test
fun launchIntentIdentityDiffersAcrossConversationTargets() {
val first = conversationNotificationLaunchIntent(context, target)