ewilliams28/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-08-26 04:15:48 -06:00
Code Issues Packages Projects Releases Wiki Activity

fix(state): read live WAL ownership safely

Browse Source 
Use WAL-aware read-only access when SQLite journal sidecars are live, while retaining immutable inspection for quiescent database families. This prevents false corruption during concurrent state initialization without mutating cold databases or changing the schema.
This commit is contained in:
Peter Steinberger
2026-08-09 22:56:02 -07:00
parent c68606b812
commit 1e95c471a0
1 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/state/openclaw-state-ownership.ts
+10 -5
View File
@@ -4,6 +4,7 @@ import type { DatabaseSync } from "node:sqlite";
import { isRecord } from "@openclaw/normalization-core/record-coerce";
import { isGatewayExternallySupervised } from "../infra/gateway-supervision.js";
import { openNodeSqliteDatabase, resolveImmutableSqliteFileUri } from "../infra/node-sqlite.js";
import { OPENCLAW_SQLITE_BUSY_TIMEOUT_MS } from "./openclaw-state-db-contract.js";
import { tableExists } from "./openclaw-state-db-schema-helpers.js";
export const STATE_SUPERVISION_KEY = "gateway.supervision";
@@ -113,7 +114,7 @@ export function inspectOpenClawStateOwnershipFromDatabase(
return parseExternalOwnership(row.value_json, databasePath);
}
/** Inspect one resolved state database path through a read-only connection. */
/** Inspect one resolved state database path without mutating a quiescent SQLite family. */
export function inspectOpenClawStateOwnershipAtPath(
databasePath: string,
): OpenClawExternalStateOwnership | null {
@@ -121,11 +122,15 @@ export function inspectOpenClawStateOwnershipAtPath(
if (!existsSync(resolvedPath)) {
return null;
}
const database = openNodeSqliteDatabase(resolveImmutableSqliteFileUri(resolvedPath), {
readOnly: true,
});
const hasLiveJournal = ["-journal", "-shm", "-wal"].some((suffix) =>
existsSync(`${resolvedPath}${suffix}`),
);
const location = hasLiveJournal ? resolvedPath : resolveImmutableSqliteFileUri(resolvedPath);
const database = openNodeSqliteDatabase(location, { readOnly: true });
try {
database.exec("PRAGMA query_only = ON; PRAGMA trusted_schema = OFF;");
database.exec(
`${hasLiveJournal ? `PRAGMA busy_timeout = ${OPENCLAW_SQLITE_BUSY_TIMEOUT_MS}; ` : ""}PRAGMA query_only = ON; PRAGMA trusted_schema = OFF;`,
);
return inspectOpenClawStateOwnershipFromDatabase(database, resolvedPath);
} finally {
database.close();