fix(telegram): show typing for accepted topic messages (#99965)

Co-authored-by: Moeed Ahmed <5780040+moeedahmed@users.noreply.github.com>

extensions/telegram/src/bot-message-context.ts

@@ -481,12 +481,12 @@ export const buildTelegramMessageContext = async ({
     return null;
   }
 
-  // Direct chats are now reply-eligible; send the first typing cue before
-  // expensive context/session construction without showing typing for dropped turns.
-  if (!isGroup) {
+  // Send the first typing cue before expensive context/session construction,
+  // but only after intake has accepted the message as a non-room-event turn.
+  if (bodyResult.inboundEventKind !== "room_event") {
     initialTypingCueSent = true;
     void sendTyping().catch((err: unknown) => {
-      logVerbose(`telegram early direct typing cue failed for chat ${chatId}: ${String(err)}`);
+      logVerbose(`telegram early typing cue failed for chat ${chatId}: ${String(err)}`);
     });
   }
 

extensions/telegram/src/bot-message-context.typing.test.ts

@@ -82,4 +82,87 @@ describe("buildTelegramMessageContext typing", () => {
 
     expect(sendChatActionHandler.sendChatAction).not.toHaveBeenCalled();
   });
+
+  it("sends forum topic typing after accepted user-request classification and before context construction", async () => {
+    const buildInboundContext = vi.fn(
+      (params: Parameters<typeof buildChannelInboundEventContext>[0]) =>
+        buildChannelInboundEventContext(params as never),
+    );
+    const sendChatActionHandler = createSendChatActionHandler();
+
+    const ctx = await buildTelegramMessageContextForTest({
+      message: {
+        chat: { id: -1001234567890, type: "supergroup", title: "Forum", is_forum: true },
+        from: { id: 42, first_name: "Pat" },
+        message_thread_id: 99,
+        text: "hello topic",
+      },
+      resolveGroupRequireMention: () => false,
+      resolveTelegramGroupConfig: () => ({
+        groupConfig: { requireMention: false },
+        topicConfig: undefined,
+      }),
+      sendChatActionHandler,
+      sessionRuntime: {
+        buildChannelInboundEventContext:
+          buildInboundContext as unknown as typeof buildChannelInboundEventContext,
+      },
+    });
+
+    expect(ctx?.ctxPayload.InboundEventKind).toBe("user_request");
+    expect(ctx?.initialTypingCueSent).toBe(true);
+    expect(sendChatActionHandler.sendChatAction).toHaveBeenCalledWith(-1001234567890, "typing", {
+      message_thread_id: 99,
+    });
+    expect(sendChatActionHandler.sendChatAction.mock.invocationCallOrder[0]).toBeLessThan(
+      buildInboundContext.mock.invocationCallOrder[0],
+    );
+  });
+
+  it("does not send forum topic typing for room events", async () => {
+    const sendChatActionHandler = createSendChatActionHandler();
+
+    const ctx = await buildTelegramMessageContextForTest({
+      cfg: { messages: { groupChat: { unmentionedInbound: "room_event", mentionPatterns: [] } } },
+      message: {
+        chat: { id: -1001234567890, type: "supergroup", title: "Forum", is_forum: true },
+        from: { id: 42, first_name: "Pat" },
+        message_thread_id: 99,
+        text: "ambient chatter",
+      },
+      resolveGroupRequireMention: () => false,
+      resolveTelegramGroupConfig: () => ({
+        groupConfig: { requireMention: false },
+        topicConfig: undefined,
+      }),
+      sendChatActionHandler,
+    });
+
+    expect(ctx?.ctxPayload.InboundEventKind).toBe("room_event");
+    expect(ctx?.initialTypingCueSent).toBe(false);
+    expect(sendChatActionHandler.sendChatAction).not.toHaveBeenCalled();
+  });
+
+  it("does not send forum topic typing for unaddressed require-mention messages", async () => {
+    const sendChatActionHandler = createSendChatActionHandler();
+
+    await expect(
+      buildTelegramMessageContextForTest({
+        message: {
+          chat: { id: -1001234567890, type: "supergroup", title: "Forum", is_forum: true },
+          from: { id: 42, first_name: "Pat" },
+          message_thread_id: 99,
+          text: "ambient chatter",
+        },
+        resolveGroupRequireMention: () => true,
+        resolveTelegramGroupConfig: () => ({
+          groupConfig: { requireMention: true },
+          topicConfig: undefined,
+        }),
+        sendChatActionHandler,
+      }),
+    ).resolves.toBeNull();
+
+    expect(sendChatActionHandler.sendChatAction).not.toHaveBeenCalled();
+  });
 });