fix(gateway): align policy acknowledgement contracts

This commit is contained in:
jesse-merhi
2026-08-11 12:10:58 +10:00
parent c82732e707
commit 0d97bca40a
4 changed files with 8 additions and 9 deletions
@@ -48,6 +48,7 @@ describe("resolveInstallPolicyWarningAcknowledgementCliOptions", () => {
targetName: "demo\npkg",
targetType: "plugin",
requestMode: fixture.requestMode,
warningFingerprint: "review-required",
scan: {
requestKind: "plugin-npm",
originType: "plugin-npm",
@@ -78,6 +79,7 @@ describe("resolveInstallPolicyWarningAcknowledgementCliOptions", () => {
targetName: "demo",
targetType: "skill",
requestMode: "install",
warningFingerprint: "review-required",
scan: {
requestKind: "skill-install",
originType: "skill-managed-install",
+1
View File
@@ -17,6 +17,7 @@ describe("installPluginDirectoryIntoExtensions", () => {
fs.mkdirSync(sourceDir, { recursive: true });
fs.writeFileSync(path.join(sourceDir, "index.js"), "export default {};\n");
const installPolicyWarning = {
warningFingerprint: "review-installed-dependency-tree",
scan: {
requestKind: "plugin-archive" as const,
originType: "plugin-dependency-tree",
@@ -1,8 +1,8 @@
import { expectDefined } from "@openclaw/normalization-core";
import { beforeEach, describe, expect, it, vi } from "vitest";
import type {
InstallSafetyOverrides,
InstallPolicyWarningAcknowledgementRequest,
InstallPolicyWarningAcknowledgementResult,
InstallPolicyWarningOccurrence,
} from "./install-security-scan.types.js";
import {
@@ -248,9 +248,7 @@ describe("plugin management install-policy acknowledgements", () => {
const acknowledge = expectDefined(
(
call[0] as {
onInstallPolicyWarning?: (
request: InstallPolicyWarningAcknowledgementRequest,
) => Promise<InstallPolicyWarningAcknowledgementResult>;
onInstallPolicyWarning?: InstallSafetyOverrides["onInstallPolicyWarning"];
}
).onInstallPolicyWarning,
"install-policy acknowledgement callback",
@@ -1,12 +1,12 @@
import { expectDefined } from "@openclaw/normalization-core";
import { expect } from "vitest";
import type {
InstallSafetyOverrides,
InstallPolicyWarningAcknowledgementRequest,
InstallPolicyWarningAcknowledgementResult,
InstallPolicyWarningOccurrence,
} from "../install-security-scan.types.js";
export const officialDiffsWarningOccurrence: InstallPolicyWarningOccurrence = {
const officialDiffsWarningOccurrence: InstallPolicyWarningOccurrence = {
warningFingerprint: "review-diffs-warning",
scan: {
requestKind: "plugin-archive",
@@ -22,9 +22,7 @@ export const officialDiffsWarningOccurrence: InstallPolicyWarningOccurrence = {
};
type InstallPolicyWarningCall = {
onInstallPolicyWarning?: (
request: InstallPolicyWarningAcknowledgementRequest,
) => Promise<InstallPolicyWarningAcknowledgementResult>;
onInstallPolicyWarning?: InstallSafetyOverrides["onInstallPolicyWarning"];
};
export const officialDiffsWarningRequest = {