ewilliams28/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-08-12 21:53:00 -06:00
Code Issues Packages Projects Releases Wiki Activity

refactor(qa): share live scenario reply assertion

Browse Source
This commit is contained in:
Vincent Koc
2026-06-20 10:42:48 +08:00
parent 13e76544e5
commit 0479da9bfb
3 changed files with 23 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files
extensions/qa-lab/src/live-transports/discord/discord-live.runtime.ts
+1 -16
View File
@@ -34,6 +34,7 @@ import {
redactQaLiveLaneIssues,
} from "../shared/live-artifacts.js";
import { startQaLiveLaneGateway } from "../shared/live-gateway.runtime.js";
import { assertLiveScenarioReply as assertDiscordScenarioReply } from "../shared/live-scenario-reply.js";
import {
collectLiveTransportStandardScenarioCoverage,
selectLiveTransportScenarios,
@@ -1478,22 +1479,6 @@ function matchesDiscordScenarioReply(params: {
);
}
function assertDiscordScenarioReply(params: {
expectedTextIncludes?: string[];
message: DiscordObservedMessage;
}) {
if (!params.message.text.trim()) {
throw new Error(`reply message ${params.message.messageId} was empty`);
}
for (const expected of params.expectedTextIncludes ?? []) {
if (!params.message.text.includes(expected)) {
throw new Error(
`reply message ${params.message.messageId} missing expected text: ${expected}`,
);
}
}
}
async function assertDiscordApplicationCommandsRegistered(params: {
applicationId: string;
expectedCommandNames: string[];
extensions/qa-lab/src/live-transports/shared/live-scenario-reply.ts
+21
View File
@@ -0,0 +1,21 @@
type LiveScenarioReplyMessage = {
messageId: string | number;
text: string;
[key: string]: unknown;
};
export function assertLiveScenarioReply(params: {
expectedTextIncludes?: string[];
message: LiveScenarioReplyMessage;
}) {
if (!params.message.text.trim()) {
throw new Error(`reply message ${params.message.messageId} was empty`);
}
for (const expected of params.expectedTextIncludes ?? []) {
if (!params.message.text.includes(expected)) {
throw new Error(
`reply message ${params.message.messageId} missing expected text: ${expected}`,
);
}
}
}
extensions/qa-lab/src/live-transports/telegram/telegram-live.runtime.ts
+1 -16
View File
@@ -39,6 +39,7 @@ import {
redactQaLiveLaneIssues,
} from "../shared/live-artifacts.js";
import { startQaLiveLaneGateway } from "../shared/live-gateway.runtime.js";
import { assertLiveScenarioReply as assertTelegramScenarioReply } from "../shared/live-scenario-reply.js";
import type { LiveTransportCheckResult } from "../shared/live-transport-result.js";
import {
normalizeLiveTransportRttOptions,
@@ -1442,22 +1443,6 @@ function matchesTelegramScenarioReply(params: {
);
}
function assertTelegramScenarioReply(params: {
expectedTextIncludes?: string[];
message: TelegramObservedMessage;
}) {
if (!params.message.text.trim()) {
throw new Error(`reply message ${params.message.messageId} was empty`);
}
for (const expected of params.expectedTextIncludes ?? []) {
if (!params.message.text.includes(expected)) {
throw new Error(
`reply message ${params.message.messageId} missing expected text: ${expected}`,
);
}
}
}
function assertTelegramCanaryPresenceReply(message: TelegramObservedMessage) {
if (!message.senderIsBot) {
throw new Error(`canary reply message ${message.messageId} was not sent by a bot`);