Patrick Buckley 1b40ae79f9 fix(storage): address PR #457 review feedback ...

Three issues from the Copilot review on PR #457:

1. SQLite race in bulk_close_stale_orphans (Copilot): the SELECT-then-
   UPDATE flow doesn't re-apply the eligibility predicates on the
   UPDATE, so a row that gets touch_workstream-bumped (or set_state-
   transitioned) between the two statements would still be flipped
   to closed.  Postgres dodges this via UPDATE...RETURNING (one atomic
   statement); SQLite needs the explicit re-application.  Fix: rebuild
   the WHERE conditions list once, apply on both SELECT and UPDATE,
   then SELECT-back by ``state='closed' AND updated=now`` to get the
   accurate closed-id list.  A row that became fresh between the two
   statements skips the UPDATE entirely.

2. SQLite IN-clause bind-parameter limit (Copilot): default 999 cap
   could be exceeded on a backlog reap (e.g. after a long outage).
   Chunked the candidate id list at 500 — same chunk size
   prune_workstreams (line 453) uses for the same reason.

3. Wall-clock-dependent test asserts (Copilot, two locations): the
   tests asserted ``updated > '2024-01-01T00:00:00'`` which is fragile
   on systems with skewed clocks or pre-2024 dates.  Replaced with
   ``updated != stale_seed`` — captures the same intent (the value
   was bumped) without depending on wall-clock date.

Two ``...``-as-no-op flags from github-code-quality were false
positives — ``...`` is the standard Python idiom for Protocol method
bodies and matches every other method in _protocol.py.  No code change.

2026-04-30 13:34:15 -07:00

..

__init__.py

Initial commit — turnstone multi-node AI orchestration platform.

2026-03-02 00:33:37 -08:00

_coord_test_helpers.py

feat(console): per-call model + judge_model on coord composer (#440)

2026-04-28 09:37:54 -07:00

_replay_helpers.py

feat(coord): per-coordinator status bar + richer history replay

2026-04-28 10:27:26 -07:00

conftest.py

refactor(core): unify approve_tools across both kinds (#436)

2026-04-27 21:52:57 -07:00

test_admin_model_registry_refresh.py

fix(coord): tighten coord_registry refresh logging + comments per round-2 review

2026-04-29 20:20:38 -07:00

test_api_versioning.py

chore(tests): refresh fixtures for path-keyed URL family

2026-04-26 22:14:22 -07:00

test_app_js.py

fix(ui): preserve approval pill when tool errors (#432)

2026-04-27 19:37:26 -07:00

test_audit.py

refactor(coordinator): rename task_list → tasks, doc/prompt sweep (#437)

2026-04-27 22:51:31 -07:00

test_auth_identity.py

chore(tests): refresh fixtures for path-keyed URL family

2026-04-26 22:14:22 -07:00

test_auth.py

fix: apply /review feedback on legacy URL cleanup

2026-04-26 22:14:22 -07:00

test_bm25.py

feat: structured memory system — typed/scoped memories with BM25 rele… (#53)

2026-03-13 21:21:09 -07:00

test_bootstrap.py

fix: bundle production compose.yaml for pipx users (#293) (#294)

2026-04-04 12:26:10 -07:00

test_cancel.py

fix(coord): close gaps an operator's harness shakedown surfaced (#444)

2026-04-28 12:52:36 -07:00

test_channel_discord.py

refactor(channels): backfill review of Slack/Discord adapters (#382)

2026-04-18 05:49:54 -07:00

test_channel_protocol.py

refactor(channels): backfill review of Slack/Discord adapters (#382)

2026-04-18 05:49:54 -07:00

test_channel_routing.py

refactor: channel router + scheduler use SDK clients

2026-03-30 20:30:05 -07:00

test_channel_slack.py

refactor(channels): backfill review of Slack/Discord adapters (#382)

2026-04-18 05:49:54 -07:00

test_channel_sse.py

refactor(channels): backfill review of Slack/Discord adapters (#382)

2026-04-18 05:49:54 -07:00

test_channel_storage.py

feat: add PostgreSQL CI integration tests (#156)

2026-03-23 11:11:40 -07:00

test_close_reason_persistence.py

chore(tests): refresh fixtures for path-keyed URL family

2026-04-26 22:14:22 -07:00

test_config_store.py

feat: ConfigStore + admin UI for plan/task agent model and effort (#360)

2026-04-16 11:08:26 -07:00

test_config.py

fix: resolve CodeQL double-import findings in test files (#331)

2026-04-06 14:18:02 -07:00

test_console_idle_cleanup.py

fix(console): periodic idle cleanup for the coordinator pool

2026-04-30 13:34:15 -07:00

test_console_metrics.py

refactor(core): unify approve_tools across both kinds (#436)

2026-04-27 21:52:57 -07:00

test_console_route_attachments.py

feat: workstream attachments at creation time + SDK + UI parity (#362)

2026-04-16 13:30:25 -07:00

test_console_router.py

refactor(routing): replace hash-ring rebalancer with rendezvous (HRW)… (#384)

2026-04-18 19:02:52 -07:00

test_console_routing_proxy.py

chore(tests): refresh fixtures for path-keyed URL family

2026-04-26 22:14:22 -07:00

test_console.py

feat(coord): pass pending_approval_detail on child_ws_state SSE events

2026-04-29 20:20:38 -07:00

test_coord_rich_ws_state_payload.py

feat(console): coord rich ws_state payload + live activity broadcast (#420)

2026-04-26 17:32:44 -07:00

test_coord_ui_approve_tools.py

refactor(core): unify approve_tools across both kinds (#436)

2026-04-27 21:52:57 -07:00

test_coordinator_adapter.py

feat(coord): pass pending_approval_detail on child_ws_state SSE events

2026-04-29 20:20:38 -07:00

test_coordinator_client.py

fix(coord): close gaps an operator's harness shakedown surfaced (#444)

2026-04-28 12:52:36 -07:00

test_coordinator_close_all_children.py

refactor(server): delete legacy /v1/api/coordinator/ URL tree

2026-04-24 16:56:06 -07:00

test_coordinator_end_to_end.py

fix(coord): align coord client routes with post-#422 path-keyed mounts

2026-04-27 11:41:14 -07:00

test_coordinator_endpoints.py

feat(coord): per-coordinator status bar + richer history replay

2026-04-28 10:27:26 -07:00

test_coordinator_governance.py

refactor(server): delete legacy /v1/api/coordinator/ URL tree

2026-04-24 16:56:06 -07:00

test_coordinator_page.py

feat(coord): pass pending_approval_detail on child_ws_state SSE events

2026-04-29 20:20:38 -07:00

test_coordinator_proxy_auth.py

feat(coordinator): coordinator workstream kind — phase 1 (#368)

2026-04-16 21:40:50 -07:00

test_coordinator_tools.py

fix(coord): close three copilot review gaps on PR 446

2026-04-28 14:23:32 -07:00

test_db.py

feat: structured memory system — typed/scoped memories with BM25 rele… (#53)

2026-03-13 21:21:09 -07:00

test_edit_file.py

Fix/codeql quality findings (#299)

2026-04-04 17:53:20 -07:00

test_edit.py

Initial commit — turnstone multi-node AI orchestration platform.

2026-03-02 00:33:37 -08:00

test_env_scrub.py

review: fix mypy, tighten env scrub, bridge storage safety

2026-03-23 14:55:14 -07:00

test_fts5.py

Add pluggable storage backend (SQLite + PostgreSQL) and deployment packaging (#20)

2026-03-03 22:57:34 -08:00

test_governance_endpoints.py

fix: add admin.prompt_policies to valid permissions and builtin-admin role (#303)

2026-04-04 22:19:03 -07:00

test_governance_storage.py

feat: add PostgreSQL CI integration tests (#156)

2026-03-23 11:11:40 -07:00

test_healthcheck.py

feat: multi-model health tracking with runtime default and DB-only st… (#304)

2026-04-04 23:44:29 -07:00

test_html.py

Fix/web fetch reliability (#290)

2026-04-03 15:36:20 -07:00

test_interactive_adapter.py

refactor(core): split SessionKindAdapter Protocol into construction +… (#412)

2026-04-25 22:52:39 -07:00

test_judge_heuristic.py

Worktree feat configurable output guard (#305)

2026-04-05 01:53:33 -07:00

test_judge_rules_storage.py

Worktree feat configurable output guard (#305)

2026-04-05 01:53:33 -07:00

test_judge_storage.py

refactor(core): unify approve_tools across both kinds (#436)

2026-04-27 21:52:57 -07:00

test_judge.py

feat(coordinator): phase 5 — harness-test polish + wait_for_workstrea… (#378)

2026-04-17 23:56:10 -07:00

test_load_skill.py

perf(session): split metacognitive nudges out of the system message

2026-04-28 19:51:00 -07:00

test_logging.py

Add structured logging with structlog and context propagation

2026-03-04 06:47:30 -08:00

test_markdown.py

Quality overhaul: code tooling, CI/CD, architecture diagrams, UI rede… (#1)

2026-03-02 16:55:12 -08:00

test_mcp_admin_api.py

review: address copilot feedback on user_id trust check

2026-03-24 03:13:23 -07:00

test_mcp_client.py

feat(coordinator): coordinator workstream kind — phase 1 (#368)

2026-04-16 21:40:50 -07:00

test_mcp_hot_reload.py

fix: surface MCP server errors in admin UI instead of silent logging (#100)

2026-03-15 17:12:13 -07:00

test_mcp_integration.py

fix: MCP resource template URI expansion via prefix matching (#46)

2026-03-12 15:46:00 -07:00

test_mcp_prompt_sync.py

feat: wire prompt templates into session startup with full creation-p… (#47)

2026-03-12 16:57:31 -07:00

test_mcp_registry_api.py

fix: align ConfigStore implementation with spec (#153)

2026-03-21 16:12:50 -07:00

test_mcp_registry.py

fix: validate URL scheme after MCP registry template substitution (#133)

2026-03-20 20:01:26 -07:00

test_mcp_server_storage.py

feat: add PostgreSQL CI integration tests (#156)

2026-03-23 11:11:40 -07:00

test_memory_api.py

fix: validate scope_id requires scope in memory API (#80)

2026-03-15 14:28:03 -07:00

test_memory_relevance.py

feat: structured memory system — typed/scoped memories with BM25 rele… (#53)

2026-03-13 21:21:09 -07:00

test_metacognition.py

fix(metacog): N>=3 streak detector + drop redundant error-prefix list

2026-04-30 03:15:22 -07:00

test_model_definition_storage.py

feat: per-model sampling parameters (temperature, max_tokens, reasoni… (#350)

2026-04-13 17:14:58 -07:00

test_model_probe.py

fix: detect context window from vLLM max_model_len field (#252)

2026-03-30 04:19:24 -07:00

test_model_registry.py

refactor(coord): hygiene pass on coord_registry refresh — async + selective teardown + test cleanup

2026-04-29 20:20:38 -07:00

test_node_info.py

feat(node): auto-detect node capabilities via kernel interfaces (#445)

2026-04-28 13:49:31 -07:00

test_node_metadata_storage.py

feat: add per-node metadata with auto-collection, admin API, and cons… (#318)

2026-04-06 03:08:19 -07:00

test_notify_completion.py

fix: scheduled task notifications not delivered on cancellation

2026-04-06 09:54:03 -07:00

test_notify_http.py

feat: deliver scheduled workstream results to Discord on completion (#308)

2026-04-05 17:18:26 -07:00

test_notify_tool.py

Normalize session_id into ws_id as sole persistent identity (#29)

2026-03-07 12:49:07 -08:00

test_oidc_handlers.py

chore: remove dead code and fix noisy JWT test warnings

2026-03-17 17:02:25 -07:00

test_oidc_storage.py

feat: add PostgreSQL CI integration tests (#156)

2026-03-23 11:11:40 -07:00

test_oidc.py

fix: validate OIDC issuer URLs against SSRF before discovery fetch (#140)

2026-03-21 00:14:46 -07:00

test_openapi.py

chore(tests): refresh fixtures for path-keyed URL family

2026-04-26 22:14:22 -07:00

test_output_assessment_storage.py

feat: add PostgreSQL CI integration tests (#156)

2026-03-23 11:11:40 -07:00

test_output_guard.py

Worktree feat configurable output guard (#305)

2026-04-05 01:53:33 -07:00

test_phase6_endpoints.py

feat(approve): pass pending_approval_detail through cluster live-bulk

2026-04-27 11:41:14 -07:00

test_prompt_templates_runtime.py

refactor(core): split SessionKindAdapter Protocol into construction +… (#412)

2026-04-25 22:52:39 -07:00

test_prompts.py

perf(session): split metacognitive nudges out of the system message

2026-04-28 19:51:00 -07:00

test_providers_document_parts.py

feat: workstream attachments (images + text documents) (#356)

2026-04-15 13:30:22 -07:00

test_providers.py

fix(session): metacog reminders ride a side-channel, not user content

2026-04-30 03:15:22 -07:00

test_ratelimit.py

fix: apply /review feedback on legacy URL cleanup

2026-04-26 22:14:22 -07:00

test_reconstruct_messages.py

feat: workstream attachments (images + text documents) (#356)

2026-04-15 13:30:22 -07:00

test_renderer_js.py

feat(renderer): progressive mermaid rendering during streaming (#426)

2026-04-27 12:47:21 -07:00

test_rendezvous.py

refactor(routing): replace hash-ring rebalancer with rendezvous (HRW)… (#384)

2026-04-18 19:02:52 -07:00

test_resume_flow.py

feat: replace Redis MQ with direct HTTP transport (Phase 1)

2026-03-30 20:30:05 -07:00

test_rewind_retry.py

Feat/rewind retry (#221)

2026-03-29 14:18:39 -07:00

test_route_proxy_audit.py

chore(tests): refresh fixtures for path-keyed URL family

2026-04-26 22:14:22 -07:00

test_rule_registry.py

Worktree feat configurable output guard (#305)

2026-04-05 01:53:33 -07:00

test_safety.py

Initial commit — turnstone multi-node AI orchestration platform.

2026-03-02 00:33:37 -08:00

test_sandbox.py

Quality overhaul: code tooling, CI/CD, architecture diagrams, UI rede… (#1)

2026-03-02 16:55:12 -08:00

test_schedule_api.py

feat: governance — RBAC, tool policies, prompt templates, usage track… (#39)

2026-03-10 19:32:37 -07:00

test_scheduled_tasks_storage.py

feat: add PostgreSQL CI integration tests (#156)

2026-03-23 11:11:40 -07:00

test_scheduler.py

refactor: channel router + scheduler use SDK clients

2026-03-30 20:30:05 -07:00

test_scoring.py

Quality overhaul: code tooling, CI/CD, architecture diagrams, UI rede… (#1)

2026-03-02 16:55:12 -08:00

test_sdk_console.py

chore(tests): refresh fixtures for path-keyed URL family

2026-04-26 22:14:22 -07:00

test_sdk_events.py

fix: broadcast plan_resolved SSE so other clients dismiss in sync

2026-04-16 09:56:17 -07:00

test_sdk_governance.py

fix: add admin.prompt_policies to valid permissions and builtin-admin role (#303)

2026-04-04 22:19:03 -07:00

test_sdk_server_attachments.py

feat: workstream attachments at creation time + SDK + UI parity (#362)

2026-04-16 13:30:25 -07:00

test_sdk_server.py

fix(close): require non-empty body, restore CloseWorkstreamRequest

2026-04-26 22:14:22 -07:00

test_sdk_sse.py

docs: mark 1.5.0 legacy URL surface removal

2026-04-26 22:14:22 -07:00

test_sdk_sync.py

refactor(core): lift list + saved verb bodies across both kinds (Stage 2 verb lift)

2026-04-26 13:11:07 -07:00

test_server_attachments_endpoints.py

chore(tests): refresh fixtures for path-keyed URL family

2026-04-26 22:14:22 -07:00

test_server_attachments_on_create.py

fix(core,console): coord create-time attachments coordination + Copilot review feedback on PR #416

2026-04-26 04:07:39 -07:00

test_server_authz.py

feat(coord): per-coordinator status bar + richer history replay

2026-04-28 10:27:26 -07:00

test_server_compat.py

feat: pass resolved capabilities through to providers, add server com… (#352)

2026-04-14 11:05:51 -07:00

test_server_live.py

feat(core): Stage 1 SessionManager unification (#408)

2026-04-24 14:28:51 -07:00

test_service_auth_boundary.py

refactor(server): rename dashboard row id → ws_id for v1 row-shape consistency

2026-04-26 20:00:45 -07:00

test_services_storage.py

refactor: channel router + scheduler use SDK clients

2026-03-30 20:30:05 -07:00

test_session_attachments.py

feat: workstream attachments (images + text documents) (#356)

2026-04-15 13:30:22 -07:00

test_session_manager.py

fix(session_manager): scope orphan reaper by services.last_heartbeat

2026-04-30 13:34:15 -07:00

test_session_routes.py

chore(tests): refresh fixtures for path-keyed URL family

2026-04-26 22:14:22 -07:00

test_session_ui_base.py

fix(approve): visibility for child tool calls bypassing operator gate (#430)

2026-04-27 15:51:01 -07:00

test_session_worker.py

fix: apply /review feedback on legacy URL cleanup

2026-04-26 22:14:22 -07:00

test_session.py

fix(metacog): drop duplicate [repeat: tool()] info line

2026-04-30 03:15:22 -07:00

test_sessions.py

feat: workstream management — fork, rename, delete, open, interface settings

2026-04-06 08:14:18 +02:00

test_settings_api.py

Add tavily api key to config store and change is_secret tests

2026-04-05 13:09:36 -07:00

test_settings_registry.py

feat: ConfigStore + admin UI for plan/task agent model and effort (#360)

2026-04-16 11:08:26 -07:00

test_skill_discovery_api.py

fix: normalize install response + review fixes

2026-03-17 01:26:44 -07:00

test_skill_parser.py

fix: PR #118 round 2 — null-safe parser, docs, consistency

2026-03-17 16:09:06 -07:00

test_skill_resource_materialization.py

fix: materialize skill resources to disk for subprocess access (#271)

2026-03-31 22:34:24 -07:00

test_skill_resources_api.py

feat: skill resources — API, admin UI, runtime injection, and SDK

2026-03-17 01:26:44 -07:00

test_skill_resources_storage.py

feat: add PostgreSQL CI integration tests (#156)

2026-03-23 11:11:40 -07:00

test_skill_scanner.py

feat: skill scanner — evaluate SKILL.md content at install time

2026-03-16 15:45:21 -07:00

test_skill_sources.py

fix: update test_skill_sources for 5-tuple _parse_github_url

2026-03-17 01:26:44 -07:00

test_skills.py

refactor(core): lift create verb body across both kinds (Stage 2 verb lift)

2026-04-26 04:07:39 -07:00

test_state_writer.py

fix(server): apply Copilot + code-quality review feedback

2026-04-25 20:11:47 -07:00

test_storage_attachments.py

Feat/attachment followups (#363)

2026-04-16 13:39:32 -07:00

test_storage_registry.py

Fix/codeql quality findings (#299)

2026-04-04 17:53:20 -07:00

test_storage_skills_filtered.py

feat(coordinator): phase 7 — governance + skill metadata + cross-cutt… (#383)

2026-04-18 10:20:19 -07:00

test_storage_sqlite.py

fix(storage): address PR #457 review feedback

2026-04-30 13:34:15 -07:00

test_structured_memory_storage.py

feat: add PostgreSQL CI integration tests (#156)

2026-03-23 11:11:40 -07:00

test_structured_memory.py

feat(coord): surface child errors, isolate tool exceptions, add memory tool (#443)

2026-04-28 12:19:34 -07:00

test_tls_admin.py

fix: remove non-auth support from bootstrap wizard (#274)

2026-04-01 19:38:24 -07:00

test_tls_client.py

feat: replace console HTTP polling with persistent SSE streams (#266)

2026-03-31 11:28:39 -07:00

test_tls_manager.py

fix: remove non-auth support from bootstrap wizard (#274)

2026-04-01 19:38:24 -07:00

test_tls_storage.py

feat: TLS storage backend + config for lacme integration (#178)

2026-03-25 16:07:05 -07:00

test_tool_advisory.py

perf(session): split metacognitive nudges out of the system message

2026-04-28 19:51:00 -07:00

test_tool_policies_enforcement.py

feat: replace Redis MQ with direct HTTP transport (Phase 1)

2026-03-30 20:30:05 -07:00

test_tool_policy.py

feat: MCP resource and prompt discovery with read_resource tool (#44)

2026-03-12 14:49:58 -07:00

test_tool_search.py

chore: remove dead code and fix noisy JWT test warnings

2026-03-17 17:02:25 -07:00

test_tool_truncation.py

fix: capacity-aware tool output truncation and context overflow recovery (#301)

2026-04-04 19:11:07 -07:00

test_tools_schema.py

feat(coord): surface child errors, isolate tool exceptions, add memory tool (#443)

2026-04-28 12:19:34 -07:00

test_user_storage.py

feat: add PostgreSQL CI integration tests (#156)

2026-03-23 11:11:40 -07:00

test_watch_dispatch.py

refactor(server): swap interactive workers to session_worker.send

2026-04-25 20:11:47 -07:00

test_watch_storage.py

feat: add PostgreSQL CI integration tests (#156)

2026-03-23 11:11:40 -07:00

test_watch.py

feat: watch tool — periodic command polling within workstreams (#36)

2026-03-10 08:18:28 -07:00

test_web_helpers.py

feat: auto-invalidate JWT and static assets on version upgrade (#307)

2026-04-05 16:25:53 -07:00

test_web_search.py

review: update stale duckduckgo-search references to ddgs

2026-03-23 16:09:03 -07:00

test_webui_auto_approve_visibility.py

fix(approve): visibility for child tool calls bypassing operator gate (#430)

2026-04-27 15:51:01 -07:00

test_webui_content.py

feat(coord): pass pending_approval_detail on child_ws_state SSE events

2026-04-29 20:20:38 -07:00

test_workstream_endpoints.py

fix(session): metacog reminders ride a side-channel, not user content

2026-04-30 03:15:22 -07:00

test_workstream_kind.py

feat(coord): surface child errors, isolate tool exceptions, add memory tool (#443)

2026-04-28 12:19:34 -07:00