Patrick Buckley
53cabe7e20
fix(session): trim tombstone refs + WHAT-narration in apply-pass comments
...
Closes round-2 review findings q-1 (minor), q-3 (nit), q-4 (nit), q-5
(nit).
* **q-1:** Drop the ``post-migration 050`` clause from the fork-block
comment — the apply-pass relocated rather than removed the
tombstone-style temporal reference round-1 q-2 was supposed to fix.
The bulk-row dict shape and ``_encode_reminders`` are
self-explanatory; the WHY is pinned by
``test_fork_preserves_source_and_reminders``.
* **q-3:** Replace ``DOES persist now`` framing on the wake-row save
comment with a present-tense invariant. The ``now`` implies the
reader knows the prior state, same family as the temporal
tombstones.
* **q-4:** Trim the 12-line WHAT-narration block above the
resume-time ``_reminders_delivered = True`` loop to two lines
stating the WHY only. The new regression test pins the contract.
* **q-5:** Reframe ``test_fork_preserves_source_and_reminders``
docstring as a forward-looking invariant; drop the
``Dropping them was the original bug`` and ``post-migration 050``
fix-narration.
Project convention: invariant statements, present tense; don't
reference the current task / fix / migration number.
(cherry picked from commit b120ee2fd7 )
2026-05-07 17:35:22 -07:00
..
2026-03-02 00:33:37 -08:00
2026-04-30 23:48:53 -07:00
2026-05-07 17:35:22 -07:00
2026-04-28 10:27:26 -07:00
2026-05-07 17:35:20 -07:00
2026-05-07 17:35:20 -07:00
2026-05-07 17:35:22 -07:00
2026-04-26 22:14:22 -07:00
2026-05-01 14:06:08 -07:00
2026-04-27 22:51:31 -07:00
2026-04-26 22:14:22 -07:00
2026-05-07 17:35:20 -07:00
2026-03-13 21:21:09 -07:00
2026-04-04 12:26:10 -07:00
2026-05-07 17:35:22 -07:00
2026-04-28 12:52:36 -07:00
2026-04-18 05:49:54 -07:00
2026-04-18 05:49:54 -07:00
2026-03-30 20:30:05 -07:00
2026-04-18 05:49:54 -07:00
2026-04-18 05:49:54 -07:00
2026-03-23 11:11:40 -07:00
2026-04-30 23:48:53 -07:00
2026-04-30 23:48:53 -07:00
2026-05-03 13:40:29 -07:00
2026-04-16 11:08:26 -07:00
2026-04-06 14:18:02 -07:00
2026-04-30 13:34:15 -07:00
2026-04-27 21:52:57 -07:00
2026-04-16 13:30:25 -07:00
2026-04-18 19:02:52 -07:00
2026-04-26 22:14:22 -07:00
2026-05-04 02:59:35 -07:00
2026-04-26 17:32:44 -07:00
2026-04-30 23:48:53 -07:00
2026-04-30 23:48:53 -07:00
2026-05-03 13:40:29 -07:00
2026-04-24 16:56:06 -07:00
2026-04-27 11:41:14 -07:00
2026-04-28 10:27:26 -07:00
2026-04-24 16:56:06 -07:00
2026-05-07 17:35:21 -07:00
2026-05-03 13:40:29 -07:00
2026-04-16 21:40:50 -07:00
2026-04-28 14:23:32 -07:00
2026-03-13 21:21:09 -07:00
2026-04-04 17:53:20 -07:00
2026-03-02 00:33:37 -08:00
2026-05-04 02:59:35 -07:00
2026-03-03 22:57:34 -08:00
2026-04-04 22:19:03 -07:00
2026-03-23 11:11:40 -07:00
2026-04-04 23:44:29 -07:00
2026-05-01 14:06:08 -07:00
2026-04-03 15:36:20 -07:00
2026-05-07 17:35:22 -07:00
2026-05-07 17:35:21 -07:00
2026-04-25 22:52:39 -07:00
2026-04-05 01:53:33 -07:00
2026-04-05 01:53:33 -07:00
2026-04-27 21:52:57 -07:00
2026-04-17 23:56:10 -07:00
2026-05-07 17:35:21 -07:00
2026-03-04 06:47:30 -08:00
2026-03-02 16:55:12 -08:00
2026-05-07 17:35:21 -07:00
2026-05-07 17:35:21 -07:00
2026-05-07 17:35:20 -07:00
2026-05-07 17:35:20 -07:00
2026-05-07 17:35:21 -07:00
2026-05-07 17:35:20 -07:00
2026-05-07 17:35:20 -07:00
2026-05-07 17:35:20 -07:00
2026-05-07 17:35:20 -07:00
2026-05-07 17:35:20 -07:00
2026-05-07 17:35:21 -07:00
2026-05-07 17:35:20 -07:00
2026-05-07 17:35:21 -07:00
2026-05-07 17:35:21 -07:00
2026-05-07 17:35:22 -07:00
2026-05-07 17:35:22 -07:00
2026-03-12 16:57:31 -07:00
2026-03-21 16:12:50 -07:00
2026-03-20 20:01:26 -07:00
2026-03-23 11:11:40 -07:00
2026-05-07 17:35:20 -07:00
2026-05-07 17:35:22 -07:00
2026-05-07 17:35:22 -07:00
2026-03-15 14:28:03 -07:00
2026-05-03 13:40:30 -07:00
2026-05-07 17:35:22 -07:00
2026-05-07 17:35:20 -07:00
2026-04-13 17:14:58 -07:00
2026-03-30 04:19:24 -07:00
2026-05-03 13:40:30 -07:00
2026-05-03 13:40:29 -07:00
2026-04-28 13:49:31 -07:00
2026-04-06 03:08:19 -07:00
2026-04-06 09:54:03 -07:00
2026-04-05 17:18:26 -07:00
2026-03-07 12:49:07 -08:00
2026-05-07 17:35:22 -07:00
2026-05-07 17:35:20 -07:00
2026-05-07 17:35:20 -07:00
2026-05-07 17:35:20 -07:00
2026-05-07 17:35:20 -07:00
2026-04-26 22:14:22 -07:00
2026-03-23 11:11:40 -07:00
2026-04-05 01:53:33 -07:00
2026-04-27 11:41:14 -07:00
2026-04-25 22:52:39 -07:00
2026-04-28 19:51:00 -07:00
2026-04-15 13:30:22 -07:00
2026-05-03 13:40:30 -07:00
2026-04-26 22:14:22 -07:00
2026-05-07 17:35:22 -07:00
2026-04-27 12:47:21 -07:00
2026-04-18 19:02:52 -07:00
2026-03-30 20:30:05 -07:00
2026-03-29 14:18:39 -07:00
2026-04-26 22:14:22 -07:00
2026-04-05 01:53:33 -07:00
2026-03-02 00:33:37 -08:00
2026-03-02 16:55:12 -08:00
2026-03-10 19:32:37 -07:00
2026-03-23 11:11:40 -07:00
2026-03-30 20:30:05 -07:00
2026-03-02 16:55:12 -08:00
2026-04-26 22:14:22 -07:00
2026-04-16 09:56:17 -07:00
2026-04-04 22:19:03 -07:00
2026-04-16 13:30:25 -07:00
2026-04-26 22:14:22 -07:00
2026-04-26 22:14:22 -07:00
2026-04-26 13:11:07 -07:00
2026-05-04 02:59:35 -07:00
2026-04-26 04:07:39 -07:00
2026-04-28 10:27:26 -07:00
2026-05-03 13:40:30 -07:00
2026-05-07 17:35:20 -07:00
2026-04-24 14:28:51 -07:00
2026-05-03 13:40:29 -07:00
2026-04-26 20:00:45 -07:00
2026-03-30 20:30:05 -07:00
2026-05-04 02:59:35 -07:00
2026-05-07 17:35:21 -07:00
2026-04-26 22:14:22 -07:00
2026-04-27 15:51:01 -07:00
2026-04-26 22:14:22 -07:00
2026-05-07 17:35:22 -07:00
2026-05-07 17:35:22 -07:00
2026-04-05 13:09:36 -07:00
2026-04-16 11:08:26 -07:00
2026-03-17 01:26:44 -07:00
2026-05-07 17:35:20 -07:00
2026-03-17 16:09:06 -07:00
2026-03-31 22:34:24 -07:00
2026-03-17 01:26:44 -07:00
2026-03-23 11:11:40 -07:00
2026-03-16 15:45:21 -07:00
2026-03-17 01:26:44 -07:00
2026-04-26 04:07:39 -07:00
2026-04-25 20:11:47 -07:00
2026-04-16 13:39:32 -07:00
2026-04-04 17:53:20 -07:00
2026-04-18 10:20:19 -07:00
2026-05-07 17:35:22 -07:00
2026-05-07 17:35:20 -07:00
2026-05-03 13:40:30 -07:00
2026-05-03 13:40:30 -07:00
2026-04-01 19:38:24 -07:00
2026-03-31 11:28:39 -07:00
2026-04-01 19:38:24 -07:00
2026-03-25 16:07:05 -07:00
2026-04-28 19:51:00 -07:00
2026-03-30 20:30:05 -07:00
2026-03-12 14:49:58 -07:00
2026-03-17 17:02:25 -07:00
2026-04-04 19:11:07 -07:00
2026-04-28 12:19:34 -07:00
2026-03-23 11:11:40 -07:00
2026-05-07 17:35:22 -07:00
2026-05-07 17:35:22 -07:00
2026-05-07 17:35:22 -07:00
2026-05-07 17:35:22 -07:00
2026-04-05 16:25:53 -07:00
2026-05-07 17:35:21 -07:00
2026-04-27 15:51:01 -07:00
2026-04-30 23:48:53 -07:00
2026-04-30 03:15:22 -07:00
2026-04-28 12:19:34 -07:00