Files
turnstone/tests/test_output_assessment_storage.py
Patrick Buckley ab1a71c86c feat: add PostgreSQL CI integration tests (#156)
* feat: add PostgreSQL CI integration tests

Add --storage-backend pytest option and shared storage_backend fixture
in conftest.py that creates SQLiteBackend or PostgreSQLBackend based
on the flag. Migrate 13 storage test files to use shared fixture
instead of local SQLiteBackend fixtures.

Add test-postgres CI job with PostgreSQL 17 service container that
runs the full test suite against real PostgreSQL.

* fix: use TRUNCATE CASCADE for PG cleanup, wrap in try/finally

TRUNCATE is faster than per-table DELETE and resets autoincrement
sequences. try/except ensures reset_storage() always runs even if
cleanup fails due to a corrupted connection from a failing test.

* fix: document _engine coupling in PG cleanup comment
2026-03-23 11:11:40 -07:00

127 lines
5.2 KiB
Python

"""Tests for output assessment storage operations."""
from __future__ import annotations
from datetime import UTC, datetime, timedelta
def _make_assessment_kwargs(**overrides):
"""Build default kwargs for record_output_assessment."""
defaults = {
"assessment_id": "oa_001",
"ws_id": "ws-abc",
"call_id": "tc_001",
"func_name": "bash",
"flags": '["credential_leak"]',
"risk_level": "high",
"annotations": "[]",
"output_length": 256,
"redacted": False,
}
defaults.update(overrides)
return defaults
# ---------------------------------------------------------------------------
# CRUD Operations
# ---------------------------------------------------------------------------
class TestOutputAssessmentCRUD:
def test_record_and_list(self, db):
db.record_output_assessment(**_make_assessment_kwargs())
results = db.list_output_assessments()
assert len(results) == 1
assert results[0]["assessment_id"] == "oa_001"
assert results[0]["ws_id"] == "ws-abc"
assert results[0]["func_name"] == "bash"
assert results[0]["risk_level"] == "high"
# ---------------------------------------------------------------------------
# Count queries
# ---------------------------------------------------------------------------
class TestOutputAssessmentCount:
def test_count_basic(self, db):
db.record_output_assessment(**_make_assessment_kwargs(assessment_id="oa1"))
db.record_output_assessment(**_make_assessment_kwargs(assessment_id="oa2"))
db.record_output_assessment(**_make_assessment_kwargs(assessment_id="oa3"))
assert db.count_output_assessments() == 3
def test_count_empty(self, db):
assert db.count_output_assessments() == 0
def test_count_with_ws_id(self, db):
db.record_output_assessment(**_make_assessment_kwargs(assessment_id="oa1", ws_id="ws-1"))
db.record_output_assessment(**_make_assessment_kwargs(assessment_id="oa2", ws_id="ws-1"))
db.record_output_assessment(**_make_assessment_kwargs(assessment_id="oa3", ws_id="ws-2"))
assert db.count_output_assessments(ws_id="ws-1") == 2
def test_count_with_risk_level(self, db):
db.record_output_assessment(
**_make_assessment_kwargs(assessment_id="oa1", risk_level="low")
)
db.record_output_assessment(
**_make_assessment_kwargs(assessment_id="oa2", risk_level="high")
)
db.record_output_assessment(
**_make_assessment_kwargs(assessment_id="oa3", risk_level="high")
)
assert db.count_output_assessments(risk_level="high") == 2
def test_count_with_since(self, db):
db.record_output_assessment(**_make_assessment_kwargs(assessment_id="oa1"))
db.record_output_assessment(**_make_assessment_kwargs(assessment_id="oa2"))
future = (datetime.now(UTC) + timedelta(minutes=5)).strftime("%Y-%m-%dT%H:%M:%S")
assert db.count_output_assessments(since=future) == 0
def test_count_with_until(self, db):
db.record_output_assessment(**_make_assessment_kwargs(assessment_id="oa1"))
db.record_output_assessment(**_make_assessment_kwargs(assessment_id="oa2"))
past = "2020-01-01T00:00:00"
assert db.count_output_assessments(until=past) == 0
def test_count_with_date_range(self, db):
now = datetime.now(UTC)
db.record_output_assessment(**_make_assessment_kwargs(assessment_id="oa1"))
db.record_output_assessment(**_make_assessment_kwargs(assessment_id="oa2"))
db.record_output_assessment(**_make_assessment_kwargs(assessment_id="oa3"))
one_minute_ago = (now - timedelta(minutes=1)).strftime("%Y-%m-%dT%H:%M:%S")
one_minute_later = (now + timedelta(minutes=1)).strftime("%Y-%m-%dT%H:%M:%S")
assert db.count_output_assessments(since=one_minute_ago, until=one_minute_later) == 3
def test_count_matches_list_length(self, db):
"""Count with filters matches the length of list with same filters."""
db.record_output_assessment(
**_make_assessment_kwargs(assessment_id="oa1", ws_id="ws-1", risk_level="high")
)
db.record_output_assessment(
**_make_assessment_kwargs(assessment_id="oa2", ws_id="ws-1", risk_level="low")
)
db.record_output_assessment(
**_make_assessment_kwargs(assessment_id="oa3", ws_id="ws-2", risk_level="high")
)
now = datetime.now(UTC)
one_minute_ago = (now - timedelta(minutes=1)).strftime("%Y-%m-%dT%H:%M:%S")
one_minute_later = (now + timedelta(minutes=1)).strftime("%Y-%m-%dT%H:%M:%S")
for ws, rl, s, u in [
("ws-1", "", "", ""),
("", "high", "", ""),
("ws-1", "high", "", ""),
("ws-2", "low", "", ""),
("", "", one_minute_ago, one_minute_later),
("ws-1", "high", one_minute_ago, one_minute_later),
]:
count = db.count_output_assessments(ws_id=ws, risk_level=rl, since=s, until=u)
listed = db.list_output_assessments(ws_id=ws, risk_level=rl, since=s, until=u)
assert count == len(listed), (
f"Mismatch for ws_id={ws!r}, risk_level={rl!r}, since={s!r}, until={u!r}"
)