2 Commits

Author	SHA1	Message	Date
Patrick Buckley	fb190f8977	Normalize session_id into ws_id as sole persistent identity (#29) ... * Normalize session_id into ws_id as sole persistent identity Eliminate the separate session_id concept. The workstream ID (ws_id) is now the single identity used for both real-time routing and conversation persistence, removing a layer of indirection that was 1:1 in practice and buggy on resume (stale pointers, orphaned rows). Schema changes (migration 006): - Drop sessions table; add alias/title columns to workstreams - Rename conversations.session_id → ws_id - Rename session_config table → workstream_config (ws_id column) - Data migration remaps existing conversations to ws_id Storage/API renames: - register_session → register_workstream (already existed, merged) - save_message/load_messages now keyed by ws_id - resolve_session → resolve_workstream - ChatSession.session_id property → ws_id - ChatSession.resume_session() → resume() - resume_session field → resume_ws - SessionResumedEvent → WorkstreamResumedEvent - /api/sessions → /api/workstreams/saved - /sessions slash command → /workstreams - --session-retention-days → --retention-days Channel eviction recovery simplified: reuses old ws_id directly instead of get_session_id_by_ws() reverse lookup. * Fix Copilot review feedback: stale session wording in docs, regenerate OpenAPI spec - docs/channels.md: "resumes the session" → "resumes the workstream", "Session resumed:" → "Resumed:", "old session was pruned" → "old workstream was pruned" - docs/api-reference.md: "Each session object" → "Each saved workstream object", field descriptions updated, removed stale node_id field - sdk/typescript/openapi-server.json: fully regenerated from Python models — removes all stale session_id properties from WorkstreamInfo, DashboardWorkstream, CreateWorkstreamResponse schemas	2026-03-07 12:49:07 -08:00
Patrick Buckley	62a4ceac96	Dev/api versioning openapi (#18) ... * Add API versioning under /v1/ prefix with OpenAPI 3.1 spec All API endpoints move to /v1/api/* (clean break, no unversioned aliases). Non-API routes (/, /health, /metrics, /static, /shared, /node proxy) stay unversioned. New turnstone/api/ package: - Pydantic v2 models for all request/response schemas (server + console) used for OpenAPI spec generation - Programmatic OpenAPI 3.1 spec builder with EndpointSpec catalog - /openapi.json serves machine-readable spec, /docs serves Swagger UI Route changes: - Both servers use Mount("/v1", routes=[...API routes...]) - Auth middleware strips /v1/ prefix before path classification (PUBLIC_PATHS/WRITE_PATHS stay unversioned internally) - Console proxy handles /node/{id}/v1/api/ upstream forwarding - Bridge and CLI HTTP clients updated to /v1/api/ paths - /openapi.json and /docs added to PUBLIC_PATHS and rate limiter EXEMPT_PATHS Security fix from review: required_role() now correctly handles /node/{id}/v1/api/{path} proxy routes (previously the v1 segment caused write-path detection to fail, allowing read-only token escalation). 42 new tests (830 total). All frontend JS, docs, and diagrams updated. * Fix mypy type errors in turnstone/api/ package - Add generic type params to dict fields in console_schemas.py - Add return type annotations to docs.py handler factories - Move type-only imports (BaseModel, Callable, Awaitable) into TYPE_CHECKING blocks to satisfy TC002/TC003 ruff rules * Address PR #18 review feedback + fix mypy errors Review fixes: - Add pydantic>=2.0 as explicit dependency in pyproject.toml (was only transitively available via openai/mcp) - Auto-detect path parameters from {param} segments in OpenAPI spec builder (fixes missing required path params) - Use startswith() with concrete prefix for proxy version detection instead of fragile substring check - Make Swagger UI base URL configurable via swagger_ui_base_url parameter for air-gapped deployments Mypy fixes: - Add generic type params to dict fields in console_schemas - Add return type annotations to docs.py handler factories - Move type-only imports into TYPE_CHECKING blocks	2026-03-03 20:28:49 -08:00