From 76036b23645db29ef3e01ec7e24c90c2382f0e82 Mon Sep 17 00:00:00 2001
From: Patrick Buckley <eous@users.noreply.github.com>
Date: Sun, 7 Jun 2026 14:26:16 -0700
Subject: [PATCH] =?UTF-8?q?chore(ui):=20L-shell=20step=207=20=E2=80=94=20r?=
 =?UTF-8?q?etire=20the=20dead=20#settings-overlay=20cruft=20(designer=20P3?=
 =?UTF-8?q?)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The settings MODAL backdrop (#settings-overlay) died when MCP connections moved to
the Manage > Connections pane (step 6) — the #settings-mcp-* content rules are
reused there, but the overlay wrapper is gone.  Remove the closed loop of dead-but-
mutually-alive references: the CSS rule, the stale "settings-overlay" modal-id
array entry, and the guarded getElementById no-op in the settings-close path.

The other fork-collapse dead-code (the getFocusedPane stub + its null-gated
branches, the partially-retired settings-gear) is woven into still-live handlers —
deferred to the merge-gate /review for a systematic sweep with the review findings.

Verified: 0 settings-overlay refs remain; node + prettier clean; CSS audit at
baseline; standalone harness errs:[].
---
 turnstone/ui/static/app.js    |  3 ---
 turnstone/ui/static/style.css | 12 +++---------
 2 files changed, 3 insertions(+), 12 deletions(-)

diff --git a/turnstone/ui/static/app.js b/turnstone/ui/static/app.js
index cb891db4..559c650c 100644
--- a/turnstone/ui/static/app.js
+++ b/turnstone/ui/static/app.js
@@ -1908,8 +1908,6 @@ function closeSettingsPanel() {
   if (inner && inner.style.display !== "none") {
     cancelRevokeMcp();
   }
-  const overlay = document.getElementById("settings-overlay");
-  if (overlay) overlay.style.display = "none";
   if (_settingsTrap) {
     document.removeEventListener("keydown", _settingsTrap);
     _settingsTrap = null;
@@ -2153,7 +2151,6 @@ document.addEventListener("keydown", function (e) {
     "edit-title-overlay",
     "delete-ws-overlay",
     "ws-delete-overlay",
-    "settings-overlay",
     "revoke-mcp-overlay",
   ];
   for (let mi = 0; mi < modalIds.length; mi++) {
diff --git a/turnstone/ui/static/style.css b/turnstone/ui/static/style.css
index dabbf266..5f847654 100644
--- a/turnstone/ui/static/style.css
+++ b/turnstone/ui/static/style.css
@@ -2146,15 +2146,9 @@ audio.media-player {
 /* ==========================================================================
    Settings: MCP server connections
    ========================================================================== */
-#settings-overlay {
-  position: fixed;
-  inset: 0;
-  background: rgba(0, 0, 0, 0.6);
-  display: flex;
-  align-items: center;
-  justify-content: center;
-  z-index: 1000;
-}
+/* (#settings-overlay — the old settings MODAL backdrop — retired: MCP connections
+   moved to the Manage > Connections pane, which provides its own container; the
+   #settings-mcp-* content rules below are reused live in that pane.) */
 #settings-mcp-loading,
 #settings-mcp-empty {
   color: var(--fg-dim);