mirror of
https://github.com/open-policy-agent/opa.git
synced 2026-08-12 19:32:48 -06:00
afb30d3f9d
Brace yourselves! For there are many touched files here. No changes in semantics however. Spent a long time trying out the various optional rules gocritic provides, and settled for a few of them. There are more I really like, but that would take many hours to address across the codebase. Perhaps others find gocritic too pedantic? If so, we can merge the fixes without enabling the rule. Signed-off-by: Anders Eknert <anders@styra.com>
306 lines
7.8 KiB
Go
306 lines
7.8 KiB
Go
// Copyright 2018 The OPA Authors. All rights reserved.
|
|
// Use of this source code is governed by an Apache2
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// Package cover reports coverage on modules.
|
|
package cover
|
|
|
|
import (
|
|
"bytes"
|
|
"fmt"
|
|
"slices"
|
|
|
|
"github.com/open-policy-agent/opa/v1/ast"
|
|
"github.com/open-policy-agent/opa/v1/topdown"
|
|
"github.com/open-policy-agent/opa/v1/util"
|
|
)
|
|
|
|
// Cover computes and reports on coverage.
|
|
type Cover struct {
|
|
hits map[string]map[Position]struct{}
|
|
}
|
|
|
|
// New returns a new Cover object.
|
|
func New() *Cover {
|
|
return &Cover{
|
|
hits: map[string]map[Position]struct{}{},
|
|
}
|
|
}
|
|
|
|
// Enabled returns true if coverage is enabled.
|
|
func (c *Cover) Enabled() bool {
|
|
return true
|
|
}
|
|
|
|
// Config returns the standard Tracer configuration for the Cover tracer
|
|
func (c *Cover) Config() topdown.TraceConfig {
|
|
return topdown.TraceConfig{
|
|
PlugLocalVars: false, // Event variable metadata is not required for the Coverage report
|
|
}
|
|
}
|
|
|
|
// Report returns a coverage Report for the given modules.
|
|
func (c *Cover) Report(modules map[string]*ast.Module) (report Report) {
|
|
report.Files = map[string]*FileReport{}
|
|
for file, hits := range c.hits {
|
|
covered := make(PositionSlice, 0, len(hits))
|
|
for pos := range hits {
|
|
covered = append(covered, pos)
|
|
}
|
|
covered.Sort()
|
|
fr, ok := report.Files[file]
|
|
if !ok {
|
|
fr = &FileReport{}
|
|
report.Files[file] = fr
|
|
}
|
|
fr.Covered = sortedPositionSliceToRangeSlice(covered)
|
|
}
|
|
for file, module := range modules {
|
|
notCovered := PositionSlice{}
|
|
ast.WalkRules(module, func(x *ast.Rule) bool {
|
|
if hasFileLocation(x.Head.Location) {
|
|
if !report.IsCovered(x.Location.File, x.Location.Row) {
|
|
notCovered = append(notCovered, Position{x.Head.Location.Row})
|
|
}
|
|
}
|
|
return false
|
|
})
|
|
ast.WalkExprs(module, func(x *ast.Expr) bool {
|
|
if includeExprInCoverage(x) {
|
|
if !report.IsCovered(x.Location.File, x.Location.Row) {
|
|
notCovered = append(notCovered, Position{x.Location.Row})
|
|
}
|
|
}
|
|
return false
|
|
})
|
|
notCovered.Sort()
|
|
fr, ok := report.Files[file]
|
|
if !ok {
|
|
fr = &FileReport{}
|
|
report.Files[file] = fr
|
|
}
|
|
fr.NotCovered = sortedPositionSliceToRangeSlice(notCovered)
|
|
}
|
|
|
|
var coveredLoc, notCoveredLoc int
|
|
var overallCoverage float64
|
|
|
|
for _, fr := range report.Files {
|
|
fr.Coverage = fr.computeCoveragePercentage()
|
|
fr.CoveredLines = fr.locCovered()
|
|
fr.NotCoveredLines = fr.locNotCovered()
|
|
coveredLoc += fr.CoveredLines
|
|
notCoveredLoc += fr.NotCoveredLines
|
|
}
|
|
totalLoc := coveredLoc + notCoveredLoc
|
|
|
|
if totalLoc != 0 {
|
|
overallCoverage = 100.0 * float64(coveredLoc) / float64(totalLoc)
|
|
}
|
|
report.CoveredLines = coveredLoc
|
|
report.NotCoveredLines = notCoveredLoc
|
|
report.Coverage = overallCoverage
|
|
|
|
return
|
|
}
|
|
|
|
// Trace updates the coverage state.
|
|
// Deprecated: Use TraceEvent instead.
|
|
func (c *Cover) Trace(event *topdown.Event) {
|
|
c.TraceEvent(*event)
|
|
}
|
|
|
|
// TraceEvent updates the coverage state.
|
|
func (c *Cover) TraceEvent(event topdown.Event) {
|
|
switch event.Op {
|
|
case topdown.ExitOp:
|
|
if rule, ok := event.Node.(*ast.Rule); ok {
|
|
c.setHit(rule.Head.Location)
|
|
}
|
|
case topdown.EvalOp:
|
|
if expr := event.Node.(*ast.Expr); expr != nil {
|
|
c.setHit(expr.Location)
|
|
}
|
|
}
|
|
}
|
|
|
|
func (c *Cover) setHit(loc *ast.Location) {
|
|
if hasFileLocation(loc) {
|
|
hits, ok := c.hits[loc.File]
|
|
if !ok {
|
|
hits = map[Position]struct{}{}
|
|
c.hits[loc.File] = hits
|
|
}
|
|
hits[Position{loc.Row}] = struct{}{}
|
|
}
|
|
}
|
|
|
|
// Position represents a file location.
|
|
type Position struct {
|
|
Row int `json:"row"`
|
|
}
|
|
|
|
// PositionSlice is a collection of position that can be sorted.
|
|
type PositionSlice []Position
|
|
|
|
// Sort sorts the slice by line number.
|
|
func (sl PositionSlice) Sort() {
|
|
slices.SortFunc(sl, func(a, b Position) int {
|
|
return a.Row - b.Row
|
|
})
|
|
}
|
|
|
|
// Range represents a range of positions in a file.
|
|
type Range struct {
|
|
Start Position `json:"start"`
|
|
End Position `json:"end"`
|
|
}
|
|
|
|
// In returns true if the row is inside the range.
|
|
func (r Range) In(row int) bool {
|
|
return row >= r.Start.Row && row <= r.End.Row
|
|
}
|
|
|
|
// FileReport represents a coverage report for a single file.
|
|
type FileReport struct {
|
|
Covered []Range `json:"covered,omitempty"`
|
|
NotCovered []Range `json:"not_covered,omitempty"`
|
|
CoveredLines int `json:"covered_lines,omitempty"`
|
|
NotCoveredLines int `json:"not_covered_lines,omitempty"`
|
|
Coverage float64 `json:"coverage,omitempty"`
|
|
}
|
|
|
|
// IsCovered returns true if the row is marked as covered in the report.
|
|
func (fr *FileReport) IsCovered(row int) bool {
|
|
if fr == nil {
|
|
return false
|
|
}
|
|
for _, r := range fr.Covered {
|
|
if r.In(row) {
|
|
return true
|
|
}
|
|
}
|
|
return false
|
|
}
|
|
|
|
// IsNotCovered returns true if the row is marked as NOT covered in the report.
|
|
// This is not the same as simply not being reported. For example, certain
|
|
// statements like imports are not included in the report.
|
|
func (fr *FileReport) IsNotCovered(row int) bool {
|
|
if fr == nil {
|
|
return false
|
|
}
|
|
for _, r := range fr.NotCovered {
|
|
if r.In(row) {
|
|
return true
|
|
}
|
|
}
|
|
return false
|
|
}
|
|
|
|
// locCovered returns the number of lines of code covered by tests
|
|
func (fr *FileReport) locCovered() (loc int) {
|
|
for _, r := range fr.Covered {
|
|
loc += r.End.Row - r.Start.Row + 1
|
|
}
|
|
return
|
|
}
|
|
|
|
// locNotCovered returns the number of lines of code not covered by tests
|
|
func (fr *FileReport) locNotCovered() (loc int) {
|
|
for _, r := range fr.NotCovered {
|
|
loc += r.End.Row - r.Start.Row + 1
|
|
}
|
|
return
|
|
}
|
|
|
|
// computeCoveragePercentage returns the code coverage percentage of the file
|
|
func (fr *FileReport) computeCoveragePercentage() float64 {
|
|
coveredLoc := fr.locCovered()
|
|
notCoveredLoc := fr.locNotCovered()
|
|
totalLoc := coveredLoc + notCoveredLoc
|
|
|
|
if totalLoc == 0 {
|
|
return 0.0
|
|
}
|
|
|
|
return 100.0 * float64(coveredLoc) / float64(totalLoc)
|
|
}
|
|
|
|
// Report represents a coverage report for a set of files.
|
|
type Report struct {
|
|
Files map[string]*FileReport `json:"files"`
|
|
CoveredLines int `json:"covered_lines"`
|
|
NotCoveredLines int `json:"not_covered_lines"`
|
|
Coverage float64 `json:"coverage"`
|
|
}
|
|
|
|
// IsCovered returns true if the row in the given file is covered.
|
|
func (r Report) IsCovered(file string, row int) bool {
|
|
return r.Files[file].IsCovered(row)
|
|
}
|
|
|
|
// CoverageThresholdError represents an error raised when the global
|
|
// code coverage percentage is lower than the specified threshold.
|
|
type CoverageThresholdError struct {
|
|
Coverage float64
|
|
Threshold float64
|
|
Report *Report
|
|
}
|
|
|
|
func (e *CoverageThresholdError) Error() string {
|
|
var buffer bytes.Buffer
|
|
buffer.WriteString(fmt.Sprintf(
|
|
"Code coverage threshold not met: got %.2f instead of %.2f",
|
|
e.Coverage,
|
|
e.Threshold))
|
|
|
|
if e.Report != nil && len(e.Report.Files) > 0 {
|
|
buffer.WriteString("\nLines not covered:")
|
|
|
|
for _, file := range util.KeysSorted(e.Report.Files) {
|
|
report := e.Report.Files[file]
|
|
for _, r := range report.NotCovered {
|
|
if r.Start.Row == r.End.Row {
|
|
buffer.WriteString(fmt.Sprintf("\n\t%s:%d", file, r.Start.Row))
|
|
} else {
|
|
buffer.WriteString(fmt.Sprintf("\n\t%s:%d-%d", file, r.Start.Row, r.End.Row))
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
return buffer.String()
|
|
}
|
|
|
|
func sortedPositionSliceToRangeSlice(sorted []Position) (result []Range) {
|
|
if len(sorted) == 0 {
|
|
return
|
|
}
|
|
start, end := sorted[0], sorted[0]
|
|
for i := 1; i < len(sorted); i++ {
|
|
curr := sorted[i]
|
|
switch {
|
|
case curr.Row == end.Row: // skip
|
|
case curr.Row == end.Row+1:
|
|
end = curr
|
|
default:
|
|
result = append(result, Range{start, end})
|
|
start, end = curr, curr
|
|
}
|
|
}
|
|
result = append(result, Range{start, end})
|
|
return
|
|
}
|
|
|
|
func hasFileLocation(loc *ast.Location) bool {
|
|
return loc != nil && loc.File != ""
|
|
}
|
|
|
|
// Check the expression and return true if it should be included in the coverage report
|
|
func includeExprInCoverage(x *ast.Expr) bool {
|
|
_, excludeExprType := x.Terms.(*ast.SomeDecl)
|
|
|
|
return !excludeExprType && hasFileLocation(x.Location)
|
|
}
|