Stephan Renatus
4ab2ac0c61
* server: port compile API Also adds e2e tests: These include coverage for ucast in the prisma setting, and thus require some JS runtime. * e2e: selectively skip e2e Compile API tests ...for macos runs, and for the go-compat suites. * server: accept timer_rego_external_resolve_ns metrics with value 0 When running the tests in a loop for a while, I would see values of 0ns for this metric. However, comparing with its non-zero values, which are often 41 or 42ns, it seems like this is just not happening in this code path. So if "almost nothing" actually goes below 1ns, it's OK. * e2e: split dep-heavy e2e tests into their own go module * Makefile: export DOCKER_RUNNING (make e2e read it) --------- Co-authored-by: Philip Conrad <philip@chariot-chaser.net> Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
1.4 KiB
Contributing
Thanks for your contribution in advance. No matter what you will contribute to this project, pull request or bug report or feature discussion, it's always highly appreciated.
New API or feature
I want to speak more about how to add new functions to this package.
Package xstring is a collection of useful string functions which should be implemented in Go. It's a bit subject to say which function should be included and which should not. I set up following rules in order to make it clear and as objective as possible.
- Rule 1: Only string algorithm, which takes string as input, can be included.
- Rule 2: If a function has been implemented in package
string, it must not be included. - Rule 3: If a function is not language neutral, it must not be included.
- Rule 4: If a function is a part of standard library in other languages, it can be included.
- Rule 5: If a function is quite useful in some famous framework or library, it can be included.
New function must be discussed in project issues before submitting any code. If a pull request with new functions is sent without any ref issue, it will be rejected.
Pull request
Pull request is always welcome. Just make sure you have run go fmt and all test cases passed before submit.
If the pull request is to add a new API or feature, don't forget to update README.md and add new API in function list.