mirror of
https://github.com/open-policy-agent/opa.git
synced 2026-08-24 01:04:49 -06:00
Stephan Renatus
1a4227b7dc
* runtime_test: avoid race condition This had been flagged by our nightly race deteector run. Now, we'll wait for the server to have stopped before checking its log output. * plugins: avoid races, bump github.com/sirupsen/logrus To fix that other one, I've first tried updating logrus (there was a mention of fixed races in the changelog), but to no avail. Setting up the hook before any plugin would log from that test resolved the issue. No harm in updating logrus, though, let's keep that: 1.6.0 -> 1.8.1 * plugins/bundle: fix race Golang for-range loops need special care when using a reference to the second variable (v in `for k, v := range m`). We had been copying the value of m[k], which is a pointer to Status, we had not been -- as was intended -- copying the values of the struct that the pointer had been pointing to. Tests needed to be adapted for this, the s4 update will NOT contain any bundle-activation-related metrics, as no bundle was activated, and its status is a fresh copy. * workflow: add race detector to PR checks When run from nightly, we use ubuntu-latest; whereas the other checks in the pull-request workflow use ubuntu-18.04. I don't think it matters at all for the race detector, since that one runs only from another docker container, using the golang image. Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>