mirror of
https://github.com/open-policy-agent/opa.git
synced 2026-08-14 12:22:51 -06:00
Torin Sandall
7db82e7aa3
Shared library loading was removed in v0.14.0. This commit removes the deprecated code and moves the test coverage for plugin registration via the runtime package global into the runtime package. Fixes #2049 Signed-off-by: Torin Sandall <torinsandall@gmail.com>
147 lines
2.9 KiB
Go
147 lines
2.9 KiB
Go
// Copyright 2018 The OPA Authors. All rights reserved.
|
|
// Use of this source code is governed by an Apache2
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package runtime_test
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"path/filepath"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/open-policy-agent/opa/plugins"
|
|
"github.com/open-policy-agent/opa/runtime"
|
|
"github.com/open-policy-agent/opa/util"
|
|
"github.com/open-policy-agent/opa/util/test"
|
|
)
|
|
|
|
type Tester struct {
|
|
startErr error
|
|
}
|
|
|
|
func (t *Tester) Start(ctx context.Context) error {
|
|
return t.startErr
|
|
}
|
|
|
|
func (t *Tester) Stop(ctx context.Context) {
|
|
return
|
|
}
|
|
|
|
func (t *Tester) Reconfigure(ctx context.Context, config interface{}) {
|
|
return
|
|
}
|
|
|
|
type Config struct {
|
|
ConfigErr bool `json:"configerr"`
|
|
}
|
|
|
|
type Factory struct{}
|
|
|
|
func (f Factory) Validate(_ *plugins.Manager, config []byte) (interface{}, error) {
|
|
|
|
test := Config{}
|
|
|
|
if err := util.Unmarshal(config, &test); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
if test.ConfigErr {
|
|
return nil, fmt.Errorf("test error")
|
|
}
|
|
|
|
return test, nil
|
|
}
|
|
|
|
func (f Factory) New(_ *plugins.Manager, config interface{}) plugins.Plugin {
|
|
return &Tester{}
|
|
}
|
|
|
|
func TestRegisterPlugin(t *testing.T) {
|
|
|
|
params := runtime.NewParams()
|
|
|
|
fs := map[string]string{
|
|
"/config.yaml": `{"plugins": {"test": {}}}`,
|
|
}
|
|
|
|
test.WithTempFS(fs, func(testDirRoot string) {
|
|
|
|
runtime.RegisterPlugin("test", Factory{})
|
|
|
|
params.ConfigFile = filepath.Join(testDirRoot, "/config.yaml")
|
|
|
|
rt, err := runtime.NewRuntime(context.Background(), params)
|
|
if err != nil {
|
|
t.Fatalf(err.Error())
|
|
}
|
|
|
|
if err := rt.Manager.Start(context.Background()); err != nil {
|
|
t.Fatalf("Unable to initialize plugins: %v", err.Error())
|
|
}
|
|
|
|
p := rt.Manager.Plugin("test")
|
|
if p == nil {
|
|
t.Fatal("expected plugin to be registered")
|
|
}
|
|
|
|
})
|
|
|
|
}
|
|
|
|
func TestRegisterPluginNotStartedWithoutConfig(t *testing.T) {
|
|
|
|
params := runtime.NewParams()
|
|
|
|
fs := map[string]string{
|
|
"/config.yaml": `{"plugins": {}}`,
|
|
}
|
|
|
|
test.WithTempFS(fs, func(testDirRoot string) {
|
|
|
|
runtime.RegisterPlugin("test", Factory{})
|
|
|
|
params.ConfigFile = filepath.Join(testDirRoot, "/config.yaml")
|
|
|
|
rt, err := runtime.NewRuntime(context.Background(), params)
|
|
if err != nil {
|
|
t.Fatalf(err.Error())
|
|
}
|
|
|
|
if err := rt.Manager.Start(context.Background()); err != nil {
|
|
t.Fatalf("Unable to initialize plugins: %v", err.Error())
|
|
}
|
|
|
|
p := rt.Manager.Plugin("test")
|
|
if p != nil {
|
|
t.Fatal("expected plugin to be missing")
|
|
}
|
|
|
|
})
|
|
|
|
}
|
|
|
|
func TestRegisterPluginBadBootConfig(t *testing.T) {
|
|
|
|
params := runtime.NewParams()
|
|
|
|
fs := map[string]string{
|
|
"/config.yaml": `{"plugins": {"test": {"configerr": true}}}`,
|
|
}
|
|
|
|
test.WithTempFS(fs, func(testDirRoot string) {
|
|
|
|
runtime.RegisterPlugin("test", Factory{})
|
|
|
|
params.ConfigFile = filepath.Join(testDirRoot, "/config.yaml")
|
|
|
|
_, err := runtime.NewRuntime(context.Background(), params)
|
|
if err == nil || !strings.Contains(err.Error(), "config error: test") {
|
|
t.Fatal("expected config error but got:", err)
|
|
}
|
|
|
|
})
|
|
|
|
}
|