mirror of
https://github.com/open-policy-agent/opa.git
synced 2026-08-12 19:32:48 -06:00
Anders Eknert
db035b09fc
Makes OPA build and pass its tests on Go 1.27, while keeping Go 1.25 and 1.26 working. JSON output is unchanged on every supported version. Go 1.27 json package honours `encoding.TextAppender`. Many v1 ast types implement AppendText to build their Rego string cheaply, so on 1.27 they would have marshalled as Rego text. Files built only with 1.27 now implement MarshalJSONTo. Library users should keep using `json.Marshal` etc. The MarshalJSONTo methods are implementation details, are absent from 1.25 and 1.26 builds, and may change. --------- Signed-off-by: Anders Eknert <anders.eknert@apple.com> Signed-off-by: Charlie Egan <charlie_egan@apple.com> Co-authored-by: Charlie Egan <charlie_egan@apple.com>
59 lines
1.5 KiB
Go
59 lines
1.5 KiB
Go
// Copyright 2026 The OPA Authors. All rights reserved.
|
|
// Use of this source code is governed by an Apache2
|
|
// license that can be found in the LICENSE file.
|
|
|
|
//go:build go1.27
|
|
|
|
package jsonv2
|
|
|
|
import (
|
|
"bytes"
|
|
"encoding/json/jsontext"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
// widget's MarshalJSONTo assumes a non-nil receiver, mirroring the ast
|
|
// package's marshalers, to check that WriteField only calls it when v is
|
|
// non-nil.
|
|
type widget struct {
|
|
Name string
|
|
}
|
|
|
|
func (w *widget) MarshalJSONTo(e *jsontext.Encoder) error {
|
|
e.WriteToken(jsontext.BeginObject)
|
|
e.WriteToken(jsontext.String("name"))
|
|
e.WriteToken(jsontext.String(w.Name))
|
|
return e.WriteToken(jsontext.EndObject)
|
|
}
|
|
|
|
func TestWriteFieldNilPointer(t *testing.T) {
|
|
var buf bytes.Buffer
|
|
enc := jsontext.NewEncoder(&buf)
|
|
|
|
enc.WriteToken(jsontext.BeginObject)
|
|
if err := WriteField(enc, "widget", (*widget)(nil)); err != nil {
|
|
t.Fatalf("WriteField with nil pointer panicked or errored: %v", err)
|
|
}
|
|
enc.WriteToken(jsontext.EndObject)
|
|
|
|
if got, want := strings.TrimSpace(buf.String()), `{"widget":null}`; got != want {
|
|
t.Fatalf("expected %q, got %q", want, got)
|
|
}
|
|
}
|
|
|
|
func TestWriteFieldNonNilPointer(t *testing.T) {
|
|
var buf bytes.Buffer
|
|
enc := jsontext.NewEncoder(&buf)
|
|
|
|
enc.WriteToken(jsontext.BeginObject)
|
|
if err := WriteField(enc, "widget", &widget{Name: "foo"}); err != nil {
|
|
t.Fatalf("WriteField: %v", err)
|
|
}
|
|
enc.WriteToken(jsontext.EndObject)
|
|
|
|
if got, want := strings.TrimSpace(buf.String()), `{"widget":{"name":"foo"}}`; got != want {
|
|
t.Fatalf("expected %s, got %s", want, got)
|
|
}
|
|
}
|