This commit adds a config for yamllint, mass-reformats all of
the existing Yaml testcases to pass linting, and adds a Yaml
linting job to the pull-request Github Actions workflow. A few
careful exceptions and ignores were added to the linter's
config to allow keeping our existing Yaml files with minimal
reformatting.
Signed-off-by: Philip Conrad <philipaconrad@gmail.com>
Earlier the trie's scalar used map[ast.Value]trieNode.
This resulted in unexpected key comparison results such
as 1 != 1.0 when key types were ast.Number for example.
This change updates the scalar to use a util.HashMap instead
that will utilize ast.Compare to perfom key comparisons.
Fixes: #5585
Signed-off-by: Ashutosh Narkar <anarkar4387@gmail.com>
* wasm-e2e: fix test runner, adapt and include jsonpatch tests
The `sort_bindings` key now is interpreted a little differently now: it's
no longer sorting and comparing, but building two sets and compares them.
From the test author's perspective, nothing has changed, except that it
now actually compares them.
Fixes#2949.
* exported tests: don't sort test expectations
This leads to very weird situations, and seems to only be a convenience
for the test authors. So, instead, we'll have the test authors pin down
whatever the sorted bindings are, and assert that the sorted bindings of
the returned result set match.
* wasm: fix regex.find_all_string_submatch_n with n != -1
Fixes#3352.
* wasm: unify objects that contain vars
Unification only happens by the reused existing code path, but we still
have to assert equality of the rest.
Fixes#3351.
Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
Philip Conrad