From bc0e04851dcd4f8a86d8e410e8a04b0fdccf336d Mon Sep 17 00:00:00 2001 From: Stephan Renatus Date: Wed, 6 Jun 2018 10:39:49 +0200 Subject: [PATCH] fix ineffassign This actually revealed a missing error check. Since we've started a transaction at this point, I guessed that `s.abortAuto` is what we want there. Signed-off-by: Stephan Renatus --- server/server.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/server/server.go b/server/server.go index 5954d382f0..8bf61bec73 100644 --- a/server/server.go +++ b/server/server.go @@ -936,6 +936,10 @@ func (s *Server) v1DataDelete(w http.ResponseWriter, r *http.Request) { } _, err = s.store.Read(ctx, txn, path) + if err != nil { + s.abortAuto(ctx, txn, w, err) + return + } if err := s.store.Write(ctx, txn, storage.RemoveOp, path, nil); err != nil { s.abortAuto(ctx, txn, w, err)