From b55fc2e80d1a224f5744bfbec61384cf1cd3df83 Mon Sep 17 00:00:00 2001 From: Torin Sandall Date: Fri, 19 Jul 2019 09:58:58 -0400 Subject: [PATCH] server: Update server to support fails explanations mode Signed-off-by: Torin Sandall --- server/server.go | 10 ++++++++-- server/types/types.go | 1 + 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/server/server.go b/server/server.go index 3abb98695c..73ef7189a8 100644 --- a/server/server.go +++ b/server/server.go @@ -38,7 +38,7 @@ import ( "github.com/open-policy-agent/opa/server/writer" "github.com/open-policy-agent/opa/storage" "github.com/open-policy-agent/opa/topdown" - "github.com/open-policy-agent/opa/topdown/notes" + "github.com/open-policy-agent/opa/topdown/lineage" "github.com/open-policy-agent/opa/util" "github.com/open-policy-agent/opa/version" "github.com/open-policy-agent/opa/watch" @@ -1965,7 +1965,13 @@ func (s *Server) getExplainResponse(explainMode types.ExplainModeV1, trace []*to switch explainMode { case types.ExplainNotesV1: var err error - explanation, err = types.NewTraceV1(notes.Filter(trace), pretty) + explanation, err = types.NewTraceV1(lineage.Notes(trace), pretty) + if err != nil { + break + } + case types.ExplainFailsV1: + var err error + explanation, err = types.NewTraceV1(lineage.Fails(trace), pretty) if err != nil { break } diff --git a/server/types/types.go b/server/types/types.go index 019462c586..b0b9de57da 100644 --- a/server/types/types.go +++ b/server/types/types.go @@ -199,6 +199,7 @@ const ( ExplainOffV1 ExplainModeV1 = "off" ExplainFullV1 ExplainModeV1 = "full" ExplainNotesV1 ExplainModeV1 = "notes" + ExplainFailsV1 ExplainModeV1 = "fails" ) // TraceV1 models the trace result returned for queries that include the