diff --git a/go.mod b/go.mod index 96feefa859..d89662d5eb 100644 --- a/go.mod +++ b/go.mod @@ -46,7 +46,6 @@ require ( go.opentelemetry.io/otel/sdk/metric v1.43.0 go.opentelemetry.io/otel/trace v1.43.0 go.opentelemetry.io/proto/otlp v1.10.0 - go.uber.org/automaxprocs v1.6.0 go.yaml.in/yaml/v3 v3.0.4 golang.org/x/sync v0.20.0 golang.org/x/text v0.37.0 diff --git a/go.sum b/go.sum index 92e65153ea..c61b213a95 100644 --- a/go.sum +++ b/go.sum @@ -141,8 +141,6 @@ github.com/pkg/diff v0.0.0-20210226163009-20ebb0f2a09e/go.mod h1:pJLUxLENpZxwdsK github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4= github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 h1:Jamvg5psRIccs7FGNTlIRMkT8wgtp5eCXdBlqhYGL6U= github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4= -github.com/prashantv/gostub v1.1.0 h1:BTyx3RfQjRHnUWaGF9oQos79AlQ5k8WNktv7VGvVH4g= -github.com/prashantv/gostub v1.1.0/go.mod h1:A5zLQHz7ieHGG7is6LLXLz7I8+3LZzsrV0P1IAHhP5U= github.com/prometheus/client_golang v1.23.2 h1:Je96obch5RDVy3FDMndoUsjAhG5Edi49h0RJWRi/o0o= github.com/prometheus/client_golang v1.23.2/go.mod h1:Tb1a6LWHB3/SPIzCoaDXI4I8UHKeFTEQ1YCr+0Gyqmg= github.com/prometheus/client_model v0.6.2 h1:oBsgwpGs7iVziMvrGhE53c/GrLUsZdHnqNwqPLxwZyk= @@ -234,8 +232,6 @@ go.opentelemetry.io/otel/trace v1.43.0 h1:BkNrHpup+4k4w+ZZ86CZoHHEkohws8AY+WTX09 go.opentelemetry.io/otel/trace v1.43.0/go.mod h1:/QJhyVBUUswCphDVxq+8mld+AvhXZLhe+8WVFxiFff0= go.opentelemetry.io/proto/otlp v1.10.0 h1:IQRWgT5srOCYfiWnpqUYz9CVmbO8bFmKcwYxpuCSL2g= go.opentelemetry.io/proto/otlp v1.10.0/go.mod h1:/CV4QoCR/S9yaPj8utp3lvQPoqMtxXdzn7ozvvozVqk= -go.uber.org/automaxprocs v1.6.0 h1:O3y2/QNTOdbF+e/dpXNNW7Rx2hZ4sTIPyybbxyNqTUs= -go.uber.org/automaxprocs v1.6.0/go.mod h1:ifeIMSnPZuznNm6jmdzmU3/bfk01Fe2fotchwEFJ8r8= go.uber.org/goleak v1.3.0 h1:2K3zAYmnTNqV73imy9J1T3WC+gmCePx2hEGkimedGto= go.uber.org/goleak v1.3.0/go.mod h1:CoHD4mav9JJNrW/WLlf7HGZPjdw8EucARQHekz1X6bE= go.yaml.in/yaml/v2 v2.4.4 h1:tuyd0P+2Ont/d6e2rl3be67goVK4R6deVxCUX5vyPaQ= diff --git a/v1/runtime/runtime.go b/v1/runtime/runtime.go index fde2159def..a8ae263244 100644 --- a/v1/runtime/runtime.go +++ b/v1/runtime/runtime.go @@ -29,7 +29,6 @@ import ( "go.opentelemetry.io/otel/exporters/otlp/otlptrace" "go.opentelemetry.io/otel/propagation" sdkmetric "go.opentelemetry.io/otel/sdk/metric" - "go.uber.org/automaxprocs/maxprocs" "github.com/open-policy-agent/opa/internal/compiler" "github.com/open-policy-agent/opa/internal/config" @@ -625,7 +624,7 @@ func (rt *Runtime) StartServer(ctx context.Context) { // Serve will start a new REST API server and listen for requests. This // will block until either: an error occurs, the context is canceled, or // a SIGTERM or SIGKILL signal is sent. -func (rt *Runtime) Serve(ctx context.Context) error { +func (rt *Runtime) Serve(ctx context.Context) (err error) { if rt.Params.Addrs == nil { return errors.New("at least one address must be configured in runtime parameters") } @@ -650,18 +649,6 @@ func (rt *Runtime) Serve(ctx context.Context) error { checkUserPrivileges(rt.logger) - // NOTE(tsandall): at some point, hopefully we can remove this because the - // Go runtime will just do the right thing. Until then, try to set - // GOMAXPROCS based on the CPU quota applied to the process. - undo, err := maxprocs.Set(maxprocs.Logger(func(f string, a ...any) { - rt.logger.Debug(f, a...) - })) - if err != nil { - rt.logger.WithFields(map[string]any{"err": err}).Debug("Failed to set GOMAXPROCS from CPU quota.") - } - - defer undo() - if err := rt.Manager.Start(ctx); err != nil { rt.logger.WithFields(map[string]any{"err": err}).Error("Failed to start plugins.") return err