Files
openclaw/src/cli/completion-runtime.ts
T
Peter Steinberger 6b40ad6a66 fix(cli): honor shell-owned completion profile locations (#117002)
* fix(cli): honor shell-owned completion profile locations

* test(cli): isolate completion profiles across platforms

* fix(wizard): reuse canonical completion profile hints

---------

Co-authored-by: Peter Steinberger <steipete@macos.shared>
2026-07-31 15:41:08 -07:00

442 lines
16 KiB
TypeScript

// Shell completion runtime: cache paths, profile installation, and shell detection.
import { existsSync } from "node:fs";
import fs from "node:fs/promises";
import os from "node:os";
import path from "node:path";
import {
normalizeLowercaseStringOrEmpty,
normalizeOptionalString,
} from "@openclaw/normalization-core/string-coerce";
import { resolveStateDir } from "../config/paths.js";
import { pathExists } from "../utils.js";
export const COMPLETION_SHELLS = ["zsh", "bash", "powershell", "fish"] as const;
export type CompletionShell = (typeof COMPLETION_SHELLS)[number];
export const COMPLETION_SKIP_PLUGIN_COMMANDS_ENV = "OPENCLAW_COMPLETION_SKIP_PLUGIN_COMMANDS";
/** Narrows an arbitrary shell label to a completion shell supported by installer logic. */
export function isCompletionShell(value: string): value is CompletionShell {
return COMPLETION_SHELLS.includes(value as CompletionShell);
}
function resolveShellBasename(
shellPath: string,
platform: NodeJS.Platform = process.platform,
): string {
const platformBasename =
platform === "win32" ? path.win32.basename(shellPath) : path.basename(shellPath);
const winBasename = path.win32.basename(shellPath);
const basename = winBasename.length < platformBasename.length ? winBasename : platformBasename;
return normalizeLowercaseStringOrEmpty(basename.replace(/\.(?:exe|cmd|bat)$/i, ""));
}
/** Resolves the active shell from environment paths, defaulting to zsh for unknown shells. */
export function resolveShellFromEnv(env: NodeJS.ProcessEnv = process.env): CompletionShell {
const shellPath = normalizeOptionalString(env.SHELL) ?? "";
const shellName = shellPath ? resolveShellBasename(shellPath) : "";
if (shellName === "zsh") {
return "zsh";
}
if (shellName === "bash") {
return "bash";
}
if (shellName === "fish") {
return "fish";
}
if (shellName === "pwsh" || shellName === "powershell") {
return "powershell";
}
return "zsh";
}
function sanitizeCompletionBasename(value: string): string {
const trimmed = value.trim();
if (!trimmed) {
return "openclaw";
}
return trimmed.replace(/[^a-zA-Z0-9._-]/g, "-");
}
function resolveCompletionCacheDir(env: NodeJS.ProcessEnv = process.env): string {
const stateDir = resolveStateDir(env, os.homedir);
return path.join(stateDir, "completions");
}
function completionShellExtension(shell: CompletionShell): string {
return shell === "powershell" ? "ps1" : shell;
}
/** Returns the per-shell cached completion script path for a sanitized CLI binary name. */
export function resolveCompletionCachePath(shell: CompletionShell, binName: string): string {
const basename = sanitizeCompletionBasename(binName);
return path.join(resolveCompletionCacheDir(), `${basename}.${completionShellExtension(shell)}`);
}
/** Check if the completion cache file exists for the given shell. */
export async function completionCacheExists(
shell: CompletionShell,
binName = "openclaw",
): Promise<boolean> {
const cachePath = resolveCompletionCachePath(shell, binName);
return pathExists(cachePath);
}
function escapePowerShellSingleQuotedString(value: string): string {
return value.replace(/'/g, "''");
}
function formatCompletionSourceLine(shell: CompletionShell, cachePath: string): string {
if (shell === "powershell") {
return `. '${escapePowerShellSingleQuotedString(cachePath)}'`;
}
if (shell === "fish") {
return `test -f "${cachePath}"; and source "${cachePath}"`;
}
return `[ -f "${cachePath}" ] && source "${cachePath}"`;
}
function appendCompletionProfilePath(
directory: string,
pathApi: typeof path.posix,
...segments: string[]
): string {
// Shell startup resolves symlinks before `..`; path.join would select a different profile.
const nativeDirectory = pathApi.sep === "\\" ? directory.replaceAll("/", pathApi.sep) : directory;
const separator = nativeDirectory.endsWith(pathApi.sep) ? "" : pathApi.sep;
return `${nativeDirectory}${separator}${segments.join(pathApi.sep)}`;
}
/** Formats the command users can run to reload the shell profile after installation. */
export function formatCompletionReloadCommand(shell: CompletionShell, profilePath: string): string {
if (shell === "powershell") {
return `. '${escapePowerShellSingleQuotedString(profilePath)}'`;
}
if (/^[a-zA-Z0-9_./~+-]+$/u.test(profilePath)) {
return `source ${profilePath}`;
}
const homePrefix = profilePath.startsWith("~/") ? "~/" : "";
const value = profilePath.slice(homePrefix.length);
const escapedPath =
shell === "fish" ? value.replace(/[\\']/gu, "\\$&") : value.replaceAll("'", "'\\''");
return `source ${homePrefix}'${escapedPath}'`;
}
function isCompletionProfileHeader(line: string): boolean {
return line.trim() === "# OpenClaw Completion";
}
function isCompletionProfileLine(line: string, binName: string, cachePath: string | null): boolean {
if (isSlowDynamicCompletionLine(line, binName)) {
return true;
}
if (!cachePath) {
return false;
}
const trimmed = line.trim();
return (
trimmed === `source "${cachePath}"` ||
COMPLETION_SHELLS.some((shell) => trimmed === formatCompletionSourceLine(shell, cachePath))
);
}
function isPreviousCompletionSourceLine(line: string, currentCachePath: string | null): boolean {
if (!currentCachePath) {
return false;
}
const trimmed = line.trim();
const guarded =
/^(?:\[\s+-f|test\s+-f)\s+"([^"]+)"\s*(?:\]\s*&&|;\s*and)\s+source\s+"([^"]+)"$/u.exec(trimmed);
const direct = /^source\s+"([^"]+)"$/u.exec(trimmed);
const powershell = /^\.\s+'((?:[^']|'')+)'$/u.exec(trimmed);
let sourcePath: string | undefined;
if (guarded && guarded[1] === guarded[2]) {
sourcePath = guarded[1];
} else if (direct) {
sourcePath = direct[1];
} else if (powershell) {
sourcePath = powershell[1]?.replace(/''/g, "'");
}
if (!sourcePath) {
return false;
}
const sourcePaths = sourcePath.includes("\\") ? path.win32 : path;
if (sourcePaths.basename(sourcePaths.dirname(sourcePath)) !== "completions") {
return false;
}
return sourcePaths.basename(sourcePath) === path.basename(currentCachePath);
}
function isOwnedCompletionInvocation(invocation: string, binName: string): boolean {
const [command, action, ...args] = invocation.trim().split(/\s+/u);
if (command !== binName || action !== "completion") {
return false;
}
if (args.length === 0) {
return true;
}
if (args.length === 1) {
const argument = args[0] ?? "";
const shell = argument.startsWith("--shell=")
? argument.slice("--shell=".length)
: argument.startsWith("-s") && argument.length > 2
? argument.slice(2).replace(/^=/u, "")
: argument;
return isCompletionShell(shell);
}
return (
args.length === 2 &&
(args[0] === "--shell" || args[0] === "-s") &&
isCompletionShell(args[1] ?? "")
);
}
/** Check if a line uses an owned slow dynamic completion pattern (source <(...)). */
function isSlowDynamicCompletionLine(line: string, binName: string): boolean {
const trimmed = line.trim();
const dynamicMarker = `<(${binName} completion`;
const markerIndex = trimmed.indexOf(dynamicMarker);
if (markerIndex >= 0) {
const expression = trimmed.slice(markerIndex);
// Compound profile statements are user-owned; deleting the entire line loses their commands.
return (
/^(?:(?:\[\s+-f\s+[^\]]+\]\s*&&\s*)?(?:source|\.))\s*$/u.test(
trimmed.slice(0, markerIndex).trimEnd(),
) &&
expression.endsWith(")") &&
isOwnedCompletionInvocation(expression.slice(2, -1), binName)
);
}
const invocationIndex = trimmed.indexOf(`${binName} completion`);
if (invocationIndex < 0) {
return false;
}
const invocationPrefix = trimmed.slice(0, invocationIndex).trimEnd();
const evalPrefix = /^eval\s+(["']?)\$\($/u.exec(invocationPrefix);
if (evalPrefix) {
const invocation = trimmed.slice(invocationIndex);
const closing = `)${evalPrefix[1] ?? ""}`;
return (
invocation.endsWith(closing) &&
isOwnedCompletionInvocation(invocation.slice(0, -closing.length), binName)
);
}
if (invocationIndex !== 0 || /[;&]/u.test(trimmed)) {
return false;
}
const pipeline = trimmed.split("|").map((stage) => stage.trim());
const terminal = pipeline.at(-1) ?? "";
// Only the documented optional Out-String stage is owned by completion migration.
return (
isOwnedCompletionInvocation(pipeline[0] ?? "", binName) &&
/^(?:source|Invoke-Expression|iex)$/iu.test(terminal) &&
(pipeline.length === 2 || (pipeline.length === 3 && /^Out-String$/iu.test(pipeline[1] ?? "")))
);
}
function updateCompletionProfile(
content: string,
binName: string,
cachePath: string | null,
sourceLine: string,
): { next: string; changed: boolean; hadExisting: boolean } {
// Remove both cached and old dynamic blocks so installs converge to one fast source line.
const lines = content.split("\n");
const filtered: string[] = [];
let hadExisting = false;
for (let i = 0; i < lines.length; i += 1) {
const line = lines[i] ?? "";
if (isCompletionProfileHeader(line)) {
hadExisting = true;
// An orphaned marker owns no following user line; remove only a recognized source line.
const following = lines[i + 1] ?? "";
if (
isCompletionProfileLine(following, binName, cachePath) ||
isPreviousCompletionSourceLine(following, cachePath)
) {
i += 1;
}
continue;
}
if (isCompletionProfileLine(line, binName, cachePath)) {
hadExisting = true;
continue;
}
filtered.push(line);
}
const trimmed = filtered.join("\n").trimEnd();
const block = `# OpenClaw Completion\n${sourceLine}`;
const next = trimmed ? `${trimmed}\n\n${block}\n` : `${block}\n`;
return { next, changed: next !== content, hadExisting };
}
/** Resolves the shell startup profile path that should contain the OpenClaw completion block. */
export function resolveCompletionProfilePath(
shell: CompletionShell,
options: {
env?: NodeJS.ProcessEnv;
homeDir?: () => string;
platform?: NodeJS.Platform;
} = {},
): string {
const env = options.env ?? process.env;
const homeDir = options.homeDir ?? os.homedir;
const platform = options.platform ?? process.platform;
const pathApi = platform === "win32" ? path.win32 : path.posix;
const home = env.HOME || homeDir();
if (shell === "zsh") {
const profileDirectory = env.ZDOTDIR === undefined ? home : env.ZDOTDIR || pathApi.sep;
return appendCompletionProfilePath(profileDirectory, pathApi, ".zshrc");
}
if (shell === "bash") {
// Installation, status, and repairs must inspect the same real Bash profile.
const bashrc = appendCompletionProfilePath(home, pathApi, ".bashrc");
return existsSync(bashrc)
? bashrc
: appendCompletionProfilePath(home, pathApi, ".bash_profile");
}
if (shell === "fish") {
const configuredHome = env.XDG_CONFIG_HOME;
const configHome =
configuredHome && pathApi.isAbsolute(configuredHome)
? configuredHome
: appendCompletionProfilePath(home, pathApi, ".config");
return appendCompletionProfilePath(configHome, pathApi, "fish", "config.fish");
}
if (platform === "win32") {
const shellPath = normalizeOptionalString(env.SHELL) ?? "";
const shellName = shellPath ? resolveShellBasename(shellPath, platform) : "";
const profileDirectory = shellName === "powershell" ? "WindowsPowerShell" : "PowerShell";
return appendCompletionProfilePath(
env.USERPROFILE || home,
pathApi,
"Documents",
profileDirectory,
"Microsoft.PowerShell_profile.ps1",
);
}
return appendCompletionProfilePath(
home,
pathApi,
".config",
"powershell",
"Microsoft.PowerShell_profile.ps1",
);
}
/** Formats the resolved startup profile relative to HOME when that preserves its actual location. */
export function resolveCompletionProfileHint(shell: CompletionShell): string {
const profilePath = resolveCompletionProfilePath(shell);
if (shell === "powershell") {
return profilePath;
}
if (!path.isAbsolute(profilePath)) {
return profilePath.startsWith(`.${path.sep}`) || profilePath.startsWith(`..${path.sep}`)
? profilePath
: `.${path.sep}${profilePath}`;
}
const home = process.env.HOME;
// Keep lexical parent components so reload follows the same symlink path as installation.
return home && profilePath.startsWith(`${home}${path.sep}`)
? `~/${profilePath.slice(home.length + 1)}`
: profilePath;
}
/** Returns whether a shell profile already contains an OpenClaw completion block or source line. */
export async function isCompletionInstalled(
shell: CompletionShell,
binName = "openclaw",
): Promise<boolean> {
const profilePath = resolveCompletionProfilePath(shell);
if (!(await pathExists(profilePath))) {
return false;
}
const cachePath = resolveCompletionCachePath(shell, binName);
const content = await fs.readFile(profilePath, "utf-8");
const lines = content.split("\n");
// A marker does not install completion; retain missing-cache source lines for doctor repair.
return lines.some((line) => isCompletionProfileLine(line, binName, cachePath));
}
/**
* Check if the profile uses the slow dynamic completion pattern.
* Returns true if profile has `source <(openclaw completion ...)` instead of cached file.
*/
export async function usesSlowDynamicCompletion(
shell: CompletionShell,
binName = "openclaw",
): Promise<boolean> {
const profilePath = resolveCompletionProfilePath(shell);
if (!(await pathExists(profilePath))) {
return false;
}
const cachePath = resolveCompletionCachePath(shell, binName);
const content = await fs.readFile(profilePath, "utf-8");
const lines = content.split("\n");
for (const line of lines) {
if (isSlowDynamicCompletionLine(line, binName) && !line.includes(cachePath)) {
return true;
}
}
return false;
}
export async function installCompletion(shell: string, yes: boolean, binName = "openclaw") {
const isShellSupported = isCompletionShell(shell);
if (!isShellSupported) {
throw new Error(`Automated installation not supported for ${shell} yet.`);
}
const cachePath = resolveCompletionCachePath(shell, binName);
const cacheExists = await pathExists(cachePath);
if (!cacheExists) {
throw new Error(
`Completion cache not found at ${cachePath}. Run \`${binName} completion --write-state\` first.`,
);
}
const profilePath = resolveCompletionProfilePath(shell);
const sourceLine = formatCompletionSourceLine(shell, cachePath);
try {
try {
await fs.access(profilePath);
} catch {
if (!yes) {
console.warn(`Profile not found at ${profilePath}. Created a new one.`);
}
await fs.mkdir(path.dirname(profilePath), { recursive: true });
await fs.writeFile(profilePath, "", "utf-8");
}
const content = await fs.readFile(profilePath, "utf-8");
const update = updateCompletionProfile(content, binName, cachePath, sourceLine);
if (!update.changed) {
if (!yes) {
console.log(`Completion already installed in ${profilePath}`);
}
return;
}
if (!yes) {
const action = update.hadExisting ? "Updating" : "Installing";
console.log(`${action} completion in ${profilePath}...`);
}
await fs.writeFile(profilePath, update.next, "utf-8");
if (!yes) {
console.log(
`Completion installed. Restart your shell or run: ${formatCompletionReloadCommand(shell, resolveCompletionProfileHint(shell))}`,
);
}
} catch (err) {
const message = err instanceof Error ? err.message : String(err);
throw new Error(`Failed to install completion: ${message}`, { cause: err });
}
}