Files
openclaw/packages/normalization-core/src/error-coercion.ts
T
Peter Steinberger b080dd1e76 refactor: consolidate coercion contracts (#122458)
* refactor: consolidate coercion contracts

Centralize exact string, record, numeric, date, Boolean, argument, and structured-error coercions while preserving call-site semantics.

Migrate canonical-name collisions and deprecated internal SDK bypasses, deleting 55 net production/tooling lines. Expand declaration ownership enforcement to 101 allowed helpers and add a narrow export-completeness audit.

* fix: preserve standalone script coercions

Keep copied Control UI tooling self-contained and retain the trusted release harness module-relative source seam when the harness runs against an old target cwd.
2026-08-11 23:26:37 -07:00

194 lines
6.1 KiB
TypeScript

// Structural formatting stays policy-free. Core and memory-host adapters intentionally inject
// owner-specific redactors; bypassing them would weaken redaction and break one-argument APIs.
export type FormatErrorMessageOptions = {
redact: (text: string) => string;
};
const STRUCTURED_ERROR_OWNED_FIELDS = new Set(["cause", "message", "name", "stack"]);
const STRUCTURED_ERROR_PROTOTYPE_FIELDS = new Set(["__proto__", "constructor", "prototype"]);
function readProperty(value: object, key: "cause" | "code" | "status"): unknown {
try {
return (value as Record<string, unknown>)[key];
} catch {
return undefined;
}
}
function formatStatusAndCode(value: unknown): string | undefined {
if ((typeof value !== "object" || value === null) && typeof value !== "function") {
return undefined;
}
try {
if (Object.keys(value).some((key) => key !== "status" && key !== "code")) {
return undefined;
}
} catch {
// Proxy enumeration can fail; retain the safe status/code fallback below.
}
const statusValue = readProperty(value, "status");
const codeValue = readProperty(value, "code");
if (statusValue === undefined && codeValue === undefined) {
return undefined;
}
const statusText =
typeof statusValue === "string" || typeof statusValue === "number"
? String(statusValue)
: "unknown";
const codeText =
typeof codeValue === "string" || typeof codeValue === "number" ? String(codeValue) : "unknown";
return `status=${statusText} code=${codeText}`;
}
function stringifyUnknown(value: unknown): string {
if (value === null) {
return "null";
}
if (value === undefined) {
return "undefined";
}
if (
typeof value === "string" ||
typeof value === "number" ||
typeof value === "boolean" ||
typeof value === "bigint" ||
typeof value === "symbol"
) {
return String(value);
}
try {
const json = JSON.stringify(value);
if (json !== undefined) {
return json;
}
} catch {
// Fall through to the stable object tag below.
}
try {
return Object.prototype.toString.call(value);
} catch {
return "Unknown error";
}
}
/** Formats unknown errors with cause details, structured codes, and secret redaction. */
export function formatErrorMessage(value: unknown, options: FormatErrorMessageOptions): string {
let formatted: string;
if (value instanceof Error) {
formatted = value.message || value.name || "Error";
let cause = readProperty(value, "cause");
const seen = new Set<unknown>([value]);
const seenMessages = new Set<string>([formatted]);
const appendCauseMessage = (message: string | undefined): void => {
if (!message || seenMessages.has(message)) {
return;
}
formatted += ` | ${message}`;
seenMessages.add(message);
};
while (cause && !seen.has(cause)) {
seen.add(cause);
if (cause instanceof Error) {
appendCauseMessage(cause.message);
const code = readProperty(cause, "code");
if (typeof code === "string" || typeof code === "number") {
appendCauseMessage(String(code));
}
cause = readProperty(cause, "cause");
} else if (typeof cause === "string") {
appendCauseMessage(cause);
break;
} else {
appendCauseMessage(formatStatusAndCode(cause));
break;
}
}
} else {
formatted = formatStatusAndCode(value) ?? stringifyUnknown(value);
}
return options.redact(formatted);
}
/**
* Normalizes an unknown thrown value into an Error. Non-Error objects become
* the `cause` and have their enumerable fields copied so structured details
* (codes, statuses) survive the coercion.
*/
export function toErrorObject(value: unknown, fallbackMessage: string): Error {
if (value instanceof Error) {
return value;
}
if (typeof value === "string") {
return new Error(value);
}
const error = new Error(fallbackMessage, { cause: value });
if ((typeof value === "object" && value !== null) || typeof value === "function") {
Object.assign(error, value);
}
return error;
}
/** Preserves structured details while isolating hostile object field access. */
export function toStructuredErrorObject(value: unknown): Error {
if (value instanceof Error) {
return value;
}
const message = String(value);
if ((typeof value !== "object" || value === null) && typeof value !== "function") {
return toErrorObject(value, message);
}
const error = new Error(message, { cause: value });
try {
const detailKeys = Reflect.ownKeys(value).filter(
(key) =>
(typeof key !== "string" ||
(!STRUCTURED_ERROR_OWNED_FIELDS.has(key) &&
!STRUCTURED_ERROR_PROTOTYPE_FIELDS.has(key))) &&
Reflect.getOwnPropertyDescriptor(value, key)?.enumerable,
);
for (const key of detailKeys) {
try {
Object.defineProperty(error, key, {
value: Reflect.get(value, key),
writable: true,
enumerable: true,
configurable: true,
});
} catch {
// Skip fields whose getters or property definitions reject access.
}
}
} catch {
// Opaque proxies may reject enumeration; preserve the original failure as the cause.
}
return error;
}
/** Preserves Error values and stringifies every other value into a new Error. */
export function toStringifiedError(value: unknown): Error {
return value instanceof Error ? value : new Error(String(value));
}
/** Reads Error messages unchanged and stringifies every other value. */
export function coerceErrorMessage(value: unknown): string {
return value instanceof Error ? value.message : String(value);
}
/** Renders a non-Error cause as useful text without throwing. */
export function stringifyNonErrorCause(value: unknown): string {
if (value === null) {
return "null";
}
if (typeof value === "string") {
return value;
}
if (typeof value === "number" || typeof value === "boolean" || typeof value === "bigint") {
return String(value);
}
try {
return JSON.stringify(value) ?? Object.prototype.toString.call(value);
} catch {
return Object.prototype.toString.call(value);
}
}