Files
openclaw/apps/macos/Sources/OpenClaw/CronJobsStore.swift
Peter Steinberger 887b9dd5e8 fix(macos): keep Cron run history matched to the selected job (#127266)
* fix(macos): own Cron history refreshes

* fix(macos): preserve Gateway recovery across cancellation
2026-08-21 11:13:54 -07:00

209 lines
6.8 KiB
Swift

import Foundation
import Observation
import OpenClawKit
import OpenClawProtocol
import OSLog
@MainActor
@Observable
final class CronJobsStore {
static let shared = CronJobsStore()
var jobs: [CronJob] = []
var selectedJobId: String?
var runEntries: [CronRunLogEntry] = []
var schedulerEnabled: Bool?
var schedulerStorePath: String?
var schedulerNextWakeAtMs: Int?
var isLoadingJobs = false
var isLoadingRuns = false
var lastError: String?
var statusMessage: String?
private let logger = Logger(subsystem: "ai.openclaw", category: "cron.ui")
private var refreshTask: Task<Void, Never>?
private var runsTask: Task<Void, Never>?
private var eventTask: Task<Void, Never>?
private var pollTask: Task<Void, Never>?
private var runsGeneration: UInt64 = 0
private let gateway: GatewayConnection
private let interval: TimeInterval = 30
private let isPreview: Bool
init(gateway: GatewayConnection = .shared, isPreview: Bool = ProcessInfo.processInfo.isPreview) {
self.gateway = gateway
self.isPreview = isPreview
}
func start() {
guard !self.isPreview, self.eventTask == nil else { return }
self.eventTask = Task { [weak self, gateway] in
for await push in await gateway.subscribe() {
guard !Task.isCancelled, let self else { return }
self.handle(push: push)
}
}
SimpleTaskSupport.startDetachedLoop(task: &self.pollTask, interval: self.interval) { [weak self] in
await self?.refreshJobs()
}
}
func stop() {
SimpleTaskSupport.stop(task: &self.refreshTask)
self.invalidateRuns()
SimpleTaskSupport.stop(task: &self.eventTask)
SimpleTaskSupport.stop(task: &self.pollTask)
}
func refreshJobs() async {
guard !self.isLoadingJobs else { return }
self.isLoadingJobs = true
self.lastError = nil
self.statusMessage = nil
defer { self.isLoadingJobs = false }
do {
if let status = try? await self.gateway.cronStatus() {
self.schedulerEnabled = status.enabled
self.schedulerStorePath = status.sqlitePath ?? status.storePath
self.schedulerNextWakeAtMs = status.nextWakeAtMs
}
self.jobs = try await self.gateway.cronList(includeDisabled: true)
if let selectedJobId = self.selectedJobId,
!self.jobs.contains(where: { $0.id == selectedJobId })
{
self.clearSelectedJob()
}
if self.jobs.isEmpty {
self.statusMessage = "No cron jobs yet."
}
} catch {
self.logger.error("cron.list failed \(error.localizedDescription, privacy: .public)")
self.lastError = error.localizedDescription
}
}
func selectJob(_ id: String) {
if self.selectedJobId != id {
self.selectedJobId = id
self.runEntries = []
}
self.refreshRuns(jobId: id)
}
func refreshRuns(jobId: String, limit: Int = 200, delay: TimeInterval = 0) {
guard self.selectedJobId == jobId else { return }
// Claim before scheduling so late completions cannot own a newer selection.
self.runsGeneration &+= 1
let generation = self.runsGeneration
self.isLoadingRuns = true
self.lastError = nil
SimpleTaskSupport.schedule(task: &self.runsTask, delay: delay) { [weak self] in
guard let self, self.ownsRunsRequest(generation, jobId: jobId) else { return }
do {
let entries = try await self.gateway.cronRuns(jobId: jobId, limit: limit)
guard self.ownsRunsRequest(generation, jobId: jobId) else { return }
self.runEntries = entries
} catch {
guard self.ownsRunsRequest(generation, jobId: jobId) else { return }
self.logger.error("cron.runs failed \(error.localizedDescription, privacy: .public)")
self.lastError = error.localizedDescription
}
self.isLoadingRuns = false
self.runsTask = nil
}
}
func runJob(id: String, force: Bool = true) async {
do {
try await self.gateway.cronRun(jobId: id, force: force)
} catch {
self.lastError = error.localizedDescription
}
}
func removeJob(id: String) async {
do {
try await self.gateway.cronRemove(jobId: id)
if self.selectedJobId == id {
self.clearSelectedJob()
}
await self.refreshJobs()
} catch {
self.lastError = error.localizedDescription
}
}
func setJobEnabled(id: String, enabled: Bool) async {
do {
try await self.gateway.cronUpdate(
jobId: id,
patch: ["enabled": AnyCodable(enabled)])
await self.refreshJobs()
} catch {
self.lastError = error.localizedDescription
}
}
func upsertJob(
id: String?,
payload: [String: AnyCodable]) async throws
{
if let id {
try await self.gateway.cronUpdate(jobId: id, patch: payload)
} else {
try await self.gateway.cronAdd(payload: payload)
}
await self.refreshJobs()
}
// MARK: - Gateway events
private func handle(push: GatewayPush) {
switch push {
case let .event(evt) where evt.event == "cron":
guard let payload = evt.payload else { return }
if let cronEvt = try? GatewayPayloadDecoding.decode(payload, as: CronEvent.self) {
self.handle(cronEvent: cronEvt)
}
case .seqGap:
self.scheduleRefresh()
default:
break
}
}
private func handle(cronEvent evt: CronEvent) {
// Keep UI in sync with the gateway scheduler.
self.scheduleRefresh(delayMs: 250)
if evt.action == "finished", let selected = self.selectedJobId, selected == evt.jobId {
self.refreshRuns(jobId: selected, delay: 0.2)
}
}
private func scheduleRefresh(delayMs: Int = 250) {
SimpleTaskSupport.schedule(task: &self.refreshTask, delay: TimeInterval(delayMs) / 1000) { [weak self] in
await self?.refreshJobs()
}
}
private func clearSelectedJob() {
self.invalidateRuns()
self.selectedJobId = nil
self.runEntries = []
}
private func ownsRunsRequest(_ generation: UInt64, jobId: String) -> Bool {
self.runsGeneration == generation && self.selectedJobId == jobId && !Task.isCancelled
}
private func invalidateRuns() {
self.runsGeneration &+= 1
SimpleTaskSupport.stop(task: &self.runsTask)
self.isLoadingRuns = false
}
}