Files
Peter Steinberger c2e7c819f5 perf(doctor): slim remaining heavy doctor contract closures (#120811)
* perf(doctor): slim remaining heavy doctor contract closures

Follow-up to #120698: several doctor closures still cold-loaded multi-second
kysely-bearing graphs through other broad barrels (session-store-runtime,
realtime-voice, channel-outbound, logging-core, memory-host-core/-events,
sqlite-runtime, persistent-dedupe, and plugin-local barrels).

- lazy-import heavy helpers inside async migration bodies (codex, msteams,
  zalouser, workboard, matrix inbound-dedupe, memory-core migrations)
- bypass plugin-local barrels to defining modules (reef protocol,
  memory-core short-term-promotion)
- move to lighter existing subpaths (slack -> channel-streaming, matrix
  logger -> security-runtime, memory-wiki -> agent-scope-runtime, which now
  also exports resolveSessionAgentId)
- add narrow openclaw/plugin-sdk/realtime-voice-activation for discord's
  sync wake-name doctor rules
- split src/infra/kysely-sync-cache-state.ts so sqlite-transaction clears
  Kysely caches without value-loading kysely; split the memory-host-sdk
  kysely bridge off the schema/transaction bridge
- guard: forbid the heavy barrels in doctor closures with per-kind scoping

Cold enumeration per plugin: discord 52.6s->0.3s, msteams 30.9s->0.5s,
codex 29.6s->2.6s, zalouser 28.8s->2.3s, matrix 27.2s->3.2s,
slack 17.5s->1.5s, reef 9.9s->0.7s, memory-core 6.4s->3.6s,
workboard 3.4s->0.25s; all kysely-free except llm-task (named follow-up).

* fix(plugins): route slack streaming compat through a focused streaming-config subpath

The channel-streaming compat barrel is deprecated for extension production
code (deprecated-api-usage guard + SDK package contract). Add the narrow
non-deprecated openclaw/plugin-sdk/channel-streaming-config subpath for the
pure streaming config readers, and drop the now consumer-less
short-term-promotion barrel re-exports knip flagged.

* test(plugins): register memory-host-sdk kysely bridge in package boundary inventory

* fix(plugins): classify realtime-voice-activation as private-local

ClawSweeper P2: the subpath exports only a default target, which is the
private-local shape; register it in plugin-sdk-private-local-only-subpaths,
the package-boundary d.ts alias maps, and correct the public surface budgets
(realtime-voice-activation no longer counts as public).

* fix(release): exclude realtime-voice-activation declarations from the published package

Private-local subpaths ship without d.ts; register the files negation the
release pack-path check requires.
2026-08-08 20:28:58 -07:00

293 lines
9.5 KiB
TypeScript

// Workboard API module exposes the plugin public contract.
import type {
PluginDoctorStateMigration,
PluginDoctorStateMigrationContext,
} from "openclaw/plugin-sdk/runtime-doctor-migrations";
import type {
PersistedWorkboardAttachment,
PersistedWorkboardBoard,
PersistedWorkboardCard,
PersistedWorkboardNotificationSubscription,
WorkboardKeyedStore,
} from "./src/persistence-types.js";
// Doctor enumeration cold-loads this closure; sqlite-store pulls the
// plugin-state-runtime/kysely graph, so it stays behind lazy imports below.
const MAX_CARDS = 2000;
function migrationEnv(params: { env: NodeJS.ProcessEnv; stateDir: string }): NodeJS.ProcessEnv {
return { ...params.env, OPENCLAW_STATE_DIR: params.stateDir };
}
function openLegacyStore<T>(params: {
context: PluginDoctorStateMigrationContext;
env: NodeJS.ProcessEnv;
namespace: string;
maxEntries: number;
}): WorkboardKeyedStore<T> {
return params.context.openPluginStateKeyedStore<T>({
namespace: params.namespace,
maxEntries: params.maxEntries,
env: params.env,
});
}
function isPersistedCard(value: unknown): value is PersistedWorkboardCard {
return Boolean(
value && typeof value === "object" && (value as PersistedWorkboardCard).version === 1,
);
}
function isPersistedBoard(value: unknown): value is PersistedWorkboardBoard {
return Boolean(
value && typeof value === "object" && (value as PersistedWorkboardBoard).version === 1,
);
}
function isPersistedSubscription(
value: unknown,
): value is PersistedWorkboardNotificationSubscription {
return Boolean(
value &&
typeof value === "object" &&
(value as PersistedWorkboardNotificationSubscription).version === 1,
);
}
function isPersistedAttachment(value: unknown): value is PersistedWorkboardAttachment {
if (!value || typeof value !== "object") {
return false;
}
const candidate = value as {
version?: unknown;
attachment?: Partial<PersistedWorkboardAttachment["attachment"]>;
contentBase64?: unknown;
};
const attachment = candidate.attachment;
return (
candidate.version === 1 &&
attachment !== undefined &&
typeof attachment === "object" &&
typeof attachment.id === "string" &&
typeof attachment.cardId === "string" &&
typeof attachment.fileName === "string" &&
typeof attachment.byteSize === "number" &&
typeof attachment.createdAt === "number" &&
typeof candidate.contentBase64 === "string"
);
}
async function migrateNamespace<T>(params: {
label: string;
legacy: WorkboardKeyedStore<T>;
target: WorkboardKeyedStore<T>;
isValid: (value: unknown) => value is T;
}): Promise<{ imported: number; warnings: string[] }> {
const warnings: string[] = [];
let imported = 0;
for (const entry of await params.legacy.entries()) {
if (!params.isValid(entry.value)) {
warnings.push(`Skipped malformed legacy Workboard ${params.label} entry ${entry.key}`);
continue;
}
try {
const targetEntry = await params.target.lookup(entry.key);
if (targetEntry) {
if (JSON.stringify(targetEntry) === JSON.stringify(entry.value)) {
await params.legacy.delete(entry.key);
imported++;
continue;
}
warnings.push(
`Skipped legacy Workboard ${params.label} entry ${entry.key} because the SQLite target already exists`,
);
continue;
}
await params.target.register(entry.key, entry.value);
await params.legacy.delete(entry.key);
imported++;
} catch (err) {
warnings.push(
`Failed migrating legacy Workboard ${params.label} entry ${entry.key}: ${String(err)}`,
);
}
}
return { imported, warnings };
}
async function targetCardReferencesAttachment(
cards: WorkboardKeyedStore,
attachment: PersistedWorkboardAttachment,
): Promise<boolean> {
const card = await cards.lookup(attachment.attachment.cardId);
return Boolean(
card?.version === 1 &&
card.card.metadata?.attachments?.some(
(entry) =>
entry.id === attachment.attachment.id && entry.cardId === attachment.attachment.cardId,
),
);
}
async function migrateAttachments(params: {
legacy: WorkboardKeyedStore<PersistedWorkboardAttachment>;
cards: WorkboardKeyedStore;
target: WorkboardKeyedStore<PersistedWorkboardAttachment>;
}): Promise<{ imported: number; warnings: string[] }> {
const warnings: string[] = [];
let imported = 0;
for (const entry of await params.legacy.entries()) {
if (!isPersistedAttachment(entry.value)) {
warnings.push(`Skipped malformed legacy Workboard attachment entry ${entry.key}`);
continue;
}
if (!(await targetCardReferencesAttachment(params.cards, entry.value))) {
warnings.push(
`Skipped legacy Workboard attachment entry ${entry.key} because its owning card was not migrated or does not reference the attachment`,
);
continue;
}
const targetEntry = await params.target.lookup(entry.key);
if (targetEntry) {
if (JSON.stringify(targetEntry) === JSON.stringify(entry.value)) {
await params.legacy.delete(entry.key);
imported++;
continue;
}
warnings.push(
`Skipped legacy Workboard attachment entry ${entry.key} because the SQLite target already exists`,
);
continue;
}
try {
await params.target.register(entry.key, entry.value);
await params.legacy.delete(entry.key);
imported++;
} catch (err) {
warnings.push(
`Failed migrating legacy Workboard attachment entry ${entry.key}: ${String(err)}`,
);
}
}
return { imported, warnings };
}
export const stateMigrations: PluginDoctorStateMigration[] = [
{
id: "workboard-28-kv-to-sqlite",
label: "Workboard .28 plugin-state KV",
async detectLegacyState(params) {
const { resolveWorkboardSqlitePath } = await import("./src/sqlite-store.js");
const env = migrationEnv(params);
const cards = await openLegacyStore<PersistedWorkboardCard>({
context: params.context,
env,
namespace: "workboard.cards",
maxEntries: MAX_CARDS,
}).entries();
const boards = await openLegacyStore<PersistedWorkboardBoard>({
context: params.context,
env,
namespace: "workboard.boards",
maxEntries: 200,
}).entries();
const subscriptions = await openLegacyStore<PersistedWorkboardNotificationSubscription>({
context: params.context,
env,
namespace: "workboard.notify",
maxEntries: 2000,
}).entries();
const attachments = await openLegacyStore<PersistedWorkboardAttachment>({
context: params.context,
env,
namespace: "workboard.attachments",
maxEntries: MAX_CARDS * 21,
}).entries();
const count = cards.length + boards.length + subscriptions.length + attachments.length;
if (count === 0) {
return null;
}
return {
preview: [
`- Workboard: ${count} legacy .28 plugin-state KV ${count === 1 ? "entry" : "entries"}${resolveWorkboardSqlitePath(env)}`,
],
};
},
async migrateLegacyState(params) {
const { createWorkboardSqliteStores } = await import("./src/sqlite-store.js");
const env = migrationEnv(params);
const cards = openLegacyStore<PersistedWorkboardCard>({
context: params.context,
env,
namespace: "workboard.cards",
maxEntries: MAX_CARDS,
});
const boards = openLegacyStore<PersistedWorkboardBoard>({
context: params.context,
env,
namespace: "workboard.boards",
maxEntries: 200,
});
const subscriptions = openLegacyStore<PersistedWorkboardNotificationSubscription>({
context: params.context,
env,
namespace: "workboard.notify",
maxEntries: 2000,
});
const attachments = openLegacyStore<PersistedWorkboardAttachment>({
context: params.context,
env,
namespace: "workboard.attachments",
maxEntries: MAX_CARDS * 21,
});
const sqlite = createWorkboardSqliteStores({ env });
try {
const cardResult = await migrateNamespace({
label: "card",
legacy: cards,
target: sqlite.cards,
isValid: isPersistedCard,
});
const boardResult = await migrateNamespace({
label: "board",
legacy: boards,
target: sqlite.boards,
isValid: isPersistedBoard,
});
const subscriptionResult = await migrateNamespace({
label: "notification subscription",
legacy: subscriptions,
target: sqlite.subscriptions,
isValid: isPersistedSubscription,
});
const attachmentResult = await migrateAttachments({
legacy: attachments,
cards: sqlite.cards,
target: sqlite.attachments,
});
const imported =
cardResult.imported +
boardResult.imported +
subscriptionResult.imported +
attachmentResult.imported;
return {
changes:
imported > 0
? [
`Migrated ${imported} Workboard .28 plugin-state KV ${imported === 1 ? "entry" : "entries"} → relational SQLite`,
]
: [],
warnings: [
...cardResult.warnings,
...boardResult.warnings,
...subscriptionResult.warnings,
...attachmentResult.warnings,
],
};
} finally {
sqlite.close();
}
},
},
];