ewilliams28/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-08-28 05:16:23 -06:00
Code Issues Packages Projects Releases Wiki Activity

fix(cli): preserve completion profiles and option value contracts (#116906)

Browse Source 
Co-authored-by: Peter Steinberger <steipete@macos.shared>
This commit is contained in:
Peter Steinberger
2026-07-31 08:59:11 -07:00
committed by GitHub
parent 87d5cb9f67
commit f66fff57f3
9 changed files with 927 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/cli/completion-command-tree.test.ts
+54 -1
View File
@@ -1,4 +1,4 @@
import { Command } from "commander";
import { Command, Option } from "commander";
import { describe, expect, it } from "vitest";
import { collectShellCompletionCommandTree } from "./completion-command-tree.js";
@@ -63,6 +63,59 @@ describe("shell completion command tree", () => {
expect(tree.descendants[0]?.completions).toEqual(["--profile", "--force"]);
});
it("preserves inherited Commander option choices by their short and long aliases", () => {
const program = new Command()
.name("openclaw")
.addOption(new Option("-p, --profile <name>").choices(["work", "personal"]));
program
.command("completion")
.addOption(new Option("-s, --shell <shell>").choices(["zsh", "bash", "powershell", "fish"]));
const tree = collectShellCompletionCommandTree(program);
expect(tree.root.valueChoices).toEqual([
{ flags: ["-p", "--profile"], choices: ["work", "personal"], requiresValue: true },
]);
expect(tree.descendants[0]?.valueChoices).toEqual([
{ flags: ["-p", "--profile"], choices: ["work", "personal"], requiresValue: true },
{
flags: ["-s", "--shell"],
choices: ["zsh", "bash", "powershell", "fish"],
requiresValue: true,
},
]);
});
it("keeps unshadowed inherited aliases when a child reuses one option flag", () => {
const program = new Command()
.name("openclaw")
.addOption(new Option("-p, --profile <name>").choices(["work", "personal"]));
program.command("gateway").option("-p, --port <port>", "Gateway port");
const tree = collectShellCompletionCommandTree(program);
expect(tree.descendants[0]?.valueChoices).toEqual([
{ flags: ["--profile"], choices: ["work", "personal"], requiresValue: true },
]);
});
it("preserves the optional Commander argument contract for constrained choices", () => {
const program = new Command()
.name("openclaw")
.addOption(new Option("-c, --color [when]").choices(["always", "never"]));
program.command("gateway");
const tree = collectShellCompletionCommandTree(program);
const colorChoice = {
flags: ["-c", "--color"],
choices: ["always", "never"],
requiresValue: false,
};
expect(tree.root.valueChoices).toEqual([colorChoice]);
expect(tree.descendants[0]?.valueChoices).toEqual([colorChoice]);
});
it("keeps commandless roots valid for every shell", () => {
const tree = collectShellCompletionCommandTree(new Command().name("openclaw"));