From f1453c7c778c90cd347e2435bfb50d447391bd9d Mon Sep 17 00:00:00 2001 From: Peter Steinberger Date: Tue, 18 Aug 2026 05:06:05 -0700 Subject: [PATCH] fix(ci): heal red main - dialog reopen under isolation + startup baseline (#125800) Two landed-PR races left main red (run 32131816085): - #125692's rewritten markdown-tables dialog test drives every interaction through direct handler calls except the reopen, which used a raw expand.click() that only worked via a leaked cross-file document listener in the shared lane; #125766 moved the file to the isolated lane where no such listener exists. Reopen now uses the file's own handler idiom. - Accumulated startup-JS creep from landed features put main 50 B over its gzip budget (344395 B vs 343289 B baseline + 1056 B tolerance). Baseline updated to main's CI-measured bytes via the script's --update-baseline contract. --- config/control-ui-startup-budget-baseline.json | 4 ++-- ui/src/components/markdown-tables.test.ts | 5 ++++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/config/control-ui-startup-budget-baseline.json b/config/control-ui-startup-budget-baseline.json index 3327b1d3a967..8e9433329252 100644 --- a/config/control-ui-startup-budget-baseline.json +++ b/config/control-ui-startup-budget-baseline.json @@ -1,5 +1,5 @@ { - "startupJsGzipBytes": 343289, - "reason": "Typed update recovery state, failure projection, and sidebar review routing", + "startupJsGzipBytes": 344395, + "reason": "Absorb accumulated startup creep from landed PRs to current main CI bytes (main red at 344395 B vs 343289 B baseline; run 32131816085)", "updatedAt": "2026-08-18" } diff --git a/ui/src/components/markdown-tables.test.ts b/ui/src/components/markdown-tables.test.ts index 31c928a67647..5d7ca558d1a2 100644 --- a/ui/src/components/markdown-tables.test.ts +++ b/ui/src/components/markdown-tables.test.ts @@ -176,7 +176,10 @@ describe("Markdown table interactions", () => { expect(document.querySelector(".markdown-table-dialog")).toBeNull(); expect(document.activeElement).toBe(expand); - expand.click(); + // Reopen through the handler like every other interaction here: the file + // runs in the isolated lane, so no shared-graph document listener exists + // to service a raw click(). + handleMarkdownTableInteraction(markdownTableInteractionEvent(expand)); const reopenedDialog = document.querySelector(".markdown-table-dialog")!; reopenedDialog.querySelector(".markdown-table-dialog__close")!.click();