ewilliams28/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-08-27 04:47:03 -06:00
Code Issues Packages Projects Releases Wiki Activity

fix: clarify unstored exec approval defaults (#114417)

Browse Source
This commit is contained in:
Dallin Romney
2026-07-27 16:07:11 +08:00
committed by GitHub
parent 669db2968f
commit ec391edea7
4 changed files with 46 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/cli/exec-approvals-cli.test.ts
+14 -2
View File
@@ -169,6 +169,7 @@ function scopeByLabel(label: string, output: Record<string, unknown> = writtenJs
}
function resetLocalSnapshot() {
localSnapshot.exists = true;
localSnapshot.hash = "hash-local";
localSnapshot.file = { version: 1, agents: {} };
}
@@ -309,6 +310,17 @@ describe("exec approvals CLI", () => {
expect(runtimeErrors).toHaveLength(0);
});
it("renders an unstored fresh-install policy as defaults instead of absent", async () => {
localSnapshot.exists = false;
await runApprovalsCommand(["approvals", "get"]);
const output = defaultRuntime.log.mock.calls.map(([line]) => String(line ?? "")).join("\n");
expect(output).toContain("State");
expect(output).toContain("defaults (no stored overrides)");
expect(output).not.toContain("Exists");
});
it("adds effective policy to json output", async () => {
localSnapshot.file = {
version: 1,
@@ -329,7 +341,7 @@ describe("exec approvals CLI", () => {
expect(defaultRuntime.writeJson).toHaveBeenCalledWith(writtenJson(), 0);
const policy = effectivePolicy();
expect(String(policy.note)).toContain(
"Effective exec policy is the host approvals file intersected with requested tools.exec policy.",
"Effective exec policy is the host approvals policy intersected with requested tools.exec policy.",
);
expect(String(policy.note)).toContain(SESSION_EXEC_OVERRIDES_NOTE);
const scope = scopeByLabel("tools.exec");
@@ -430,7 +442,7 @@ describe("exec approvals CLI", () => {
expect(defaultRuntime.writeJson).toHaveBeenCalledWith(writtenJson(), 0);
const policy = effectivePolicy();
expect(String(policy.note)).toContain(
"Effective exec policy is the node host approvals file intersected with gateway tools.exec policy.",
"Effective exec policy is the node host approvals policy intersected with gateway tools.exec policy.",
);
expect(String(policy.note)).toContain(SESSION_EXEC_OVERRIDES_NOTE);
const scope = scopeByLabel("tools.exec");