From dae2bcf31bc96d5dd978f680fc10cc434556303a Mon Sep 17 00:00:00 2001 From: Ayaan Zaidi Date: Mon, 15 Jun 2026 12:57:15 +0530 Subject: [PATCH] style(openai): trim spark suppression comments --- .../model.forward-compat.errors-and-overrides.test.ts | 2 -- src/agents/embedded-agent-runner/model.ts | 4 ---- src/plugins/manifest-model-suppression.ts | 2 -- 3 files changed, 8 deletions(-) diff --git a/src/agents/embedded-agent-runner/model.forward-compat.errors-and-overrides.test.ts b/src/agents/embedded-agent-runner/model.forward-compat.errors-and-overrides.test.ts index 1c53ebb16ec0..e6f5c38e75bc 100644 --- a/src/agents/embedded-agent-runner/model.forward-compat.errors-and-overrides.test.ts +++ b/src/agents/embedded-agent-runner/model.forward-compat.errors-and-overrides.test.ts @@ -163,8 +163,6 @@ describe("resolveModel forward-compat errors and overrides", () => { }); it("rejects direct openai gpt-5.3-codex-spark with a codex-only hint", () => { - // Spark is intentionally suppressed from direct OpenAI routing; falling back - // would make a removed catalog row appear usable. const result = resolveModelForTest("openai", "gpt-5.3-codex-spark", "/tmp/agent"); expect(result.model).toBeUndefined(); diff --git a/src/agents/embedded-agent-runner/model.ts b/src/agents/embedded-agent-runner/model.ts index 3c6cb7bde580..bf5de3c7ba5d 100644 --- a/src/agents/embedded-agent-runner/model.ts +++ b/src/agents/embedded-agent-runner/model.ts @@ -880,8 +880,6 @@ function shouldSuppressInlineConfiguredModel(params: { ) { return false; } - // Spark is a ChatGPT/Codex OAuth-only OpenAI model. Inline custom endpoints - // may still opt in, but direct/default OpenAI API transports must fail here. return shouldSuppressBuiltInModel({ provider: params.provider, id: params.modelId, @@ -1213,8 +1211,6 @@ function resolveRuntimePreferredSuppressedModel(params: { ) { return undefined; } - // Runtime-preferred providers may restore an auth-bound model while the - // suppression still blocks stale static catalog rows for other auth modes. return resolvePluginDynamicModelWithRegistry({ ...params, runtimeHooks }); } diff --git a/src/plugins/manifest-model-suppression.ts b/src/plugins/manifest-model-suppression.ts index 0462f6826c01..b1cf4bc87930 100644 --- a/src/plugins/manifest-model-suppression.ts +++ b/src/plugins/manifest-model-suppression.ts @@ -105,8 +105,6 @@ function manifestSuppressionMatchesConditions(params: { } if (when.baseUrlHosts?.length) { const baseUrlHost = normalizeBaseUrlHost(params.baseUrl ?? configuredProvider?.baseUrl); - // Missing transport metadata usually means a stale/default catalog row. - // Suppress it unless config names a custom base URL to check. if (!baseUrlHost && !params.baseUrl && !configuredProvider?.baseUrl) { return true; }