From d6ee4c357015adb3364db1505e72cf7a8ea83d7d Mon Sep 17 00:00:00 2001 From: Peter Steinberger Date: Sun, 9 Aug 2026 22:10:40 -0700 Subject: [PATCH] fix(test): isolate gateway network proof ports (#121389) Amp-Thread-ID: https://ampcode.com/threads/T-019fe995-c7ec-74f2-aaa7-9c48fe9aa4ac Co-authored-by: Amp --- src/test-utils/ports.ts | 4 ++-- test/e2e/qa-lab/runtime/gateway-loopback-lan-access.ts | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/test-utils/ports.ts b/src/test-utils/ports.ts index 473278a81215..7d25cf90c7eb 100644 --- a/src/test-utils/ports.ts +++ b/src/test-utils/ports.ts @@ -15,11 +15,11 @@ export async function isPortFree(port: number): Promise { }); } -export async function getFreePort(): Promise { +export async function getFreePort(host = "127.0.0.1"): Promise { return await new Promise((resolve, reject) => { const server = createServer(); server.once("error", reject); - server.listen(0, "127.0.0.1", () => { + server.listen(0, host, () => { const addr = server.address(); if (!addr || typeof addr === "string") { server.close(); diff --git a/test/e2e/qa-lab/runtime/gateway-loopback-lan-access.ts b/test/e2e/qa-lab/runtime/gateway-loopback-lan-access.ts index 225612bdecb4..c4ffd1734e28 100644 --- a/test/e2e/qa-lab/runtime/gateway-loopback-lan-access.ts +++ b/test/e2e/qa-lab/runtime/gateway-loopback-lan-access.ts @@ -13,10 +13,10 @@ import { clearConfigCache, clearRuntimeConfigSnapshot } from "../../../../src/co import { clearSessionStoreCacheForTest } from "../../../../src/config/sessions/store-writer-state.js"; import { pickPrimaryLanIPv4 } from "../../../../src/gateway/net.js"; import { startGatewayServer, type GatewayServer } from "../../../../src/gateway/server.js"; -import { getFreeGatewayPort } from "../../../../src/gateway/test-helpers.e2e.js"; import { GATEWAY_STARTUP_MUTATED_ENV_KEYS } from "../../../../src/gateway/test-helpers.env.js"; import { resetAgentEventsForTest } from "../../../../src/infra/agent-events.js"; import { captureEnv, deleteTestEnvValue, setTestEnvValue } from "../../../../src/test-utils/env.js"; +import { getFreePort } from "../../../../src/test-utils/ports.js"; import { GATEWAY_CLIENT_MODES, GATEWAY_CLIENT_NAMES, @@ -365,7 +365,7 @@ export async function runGatewayLoopbackLanProof(): Promise