ewilliams28/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-08-25 20:05:46 -06:00
Code Issues Packages Projects Releases Wiki Activity

fix(subagents): hide private commentary from logs and completion announcements (#128584)

Browse Source 
* fix(subagents): hide commentary in logs and completion announcements

* refactor(agents): remove obsolete test-only history sanitizer export
This commit is contained in:
Peter Steinberger
2026-08-24 00:57:53 -07:00
committed by GitHub
parent 68ba1ef641
commit ccc4e69052
7 changed files with 96 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/auto-reply/reply/commands-subagents-text.ts
+3 -5
View File
@@ -1,5 +1,5 @@
/** Text extraction helpers for subagent command output. */
import { sanitizeTextContent } from "../../agents/tools/chat-history-text.js";
import { extractStoredAssistantText } from "../../agents/tools/chat-history-text.js";
import { extractTextFromChatContent } from "../../shared/chat-content.js";
/** Minimal chat message shape used by subagent text extraction. */
@@ -13,9 +13,7 @@ export function extractSubagentMessageText(
message: ChatMessage,
): { role: string; text: string } | null {
const role = typeof message.role === "string" ? message.role : "";
const shouldSanitize = role === "assistant";
const text = extractTextFromChatContent(message.content, {
sanitizeText: shouldSanitize ? sanitizeTextContent : undefined,
});
const content = role === "assistant" ? extractStoredAssistantText(message) : message.content;
const text = extractTextFromChatContent(content);
return text ? { role, text } : null;
}
src/auto-reply/reply/commands-subagents.test.ts
+73
View File
@@ -494,6 +494,79 @@ describe("subagents log", () => {
});
});
it.each([
{
name: "hides signed commentary while retaining the final answer",
messages: [
{
role: "assistant",
content: [
{
type: "text",
text: "PRIVATE_COMMENTARY",
textSignature: JSON.stringify({ v: 1, phase: "commentary" }),
},
{
type: "output_text",
text: "Visible final answer",
textSignature: JSON.stringify({ v: 1, phase: "final_answer" }),
},
],
},
],
expectedText: "Assistant: Visible final answer",
unexpectedText: "PRIVATE_COMMENTARY",
},
{
name: "omits commentary-only history messages",
messages: [{ role: "assistant", phase: "commentary", content: "PRIVATE_COMMENTARY" }],
expectedText: "(no messages)",
unexpectedText: "PRIVATE_COMMENTARY",
},
{
name: "does not revive legacy text when the signed final answer is empty",
messages: [
{
role: "assistant",
content: [
{ type: "text", text: "PRIVATE_LEGACY" },
{
type: "text",
text: " ",
textSignature: JSON.stringify({ v: 1, phase: "final_answer" }),
},
],
},
],
expectedText: "(no messages)",
unexpectedText: "PRIVATE_LEGACY",
},
{
name: "renders persisted Responses output text",
messages: [
{ role: "assistant", content: [{ type: "output_text", text: "Persisted output" }] },
],
expectedText: "Assistant: Persisted output",
unexpectedText: "(no messages)",
},
{
name: "renders persisted assistant input text",
messages: [
{ role: "assistant", content: [{ type: "input_text", text: "Persisted assistant input" }] },
],
expectedText: "Assistant: Persisted assistant input",
unexpectedText: "(no messages)",
},
])("$name", async ({ messages, expectedText, unexpectedText }) => {
callGatewayMock.mockResolvedValue({ messages });
const result = await handleSubagentsLogAction(buildLogContext(["1"], [makeRun()]));
const text = requireReplyText(result.reply);
expect(text).toContain(expectedText);
expect(text).not.toContain(unexpectedText);
});
it("uses the numeric token after the target as the history limit", async () => {
await handleSubagentsLogAction(buildLogContext(["1", "5"], [makeRun()]));