From bfa4ce296474c1450b9f4fe8f74b2974eace4feb Mon Sep 17 00:00:00 2001 From: Hannes Rudolph <49103247+hannesrudolph@users.noreply.github.com> Date: Wed, 12 Aug 2026 10:32:54 -0600 Subject: [PATCH] fix(xai): clarify X search reasoning default --- .../xai/src/web-search-provider.runtime.ts | 2 +- extensions/xai/web-search.test.ts | 19 ++++++++++++++++--- 2 files changed, 17 insertions(+), 4 deletions(-) diff --git a/extensions/xai/src/web-search-provider.runtime.ts b/extensions/xai/src/web-search-provider.runtime.ts index 7295f3022137..534d3dd89b90 100644 --- a/extensions/xai/src/web-search-provider.runtime.ts +++ b/extensions/xai/src/web-search-provider.runtime.ts @@ -45,7 +45,7 @@ const X_SEARCH_MODEL_OPTIONS = [ { value: XAI_DEFAULT_X_SEARCH_MODEL, label: XAI_DEFAULT_X_SEARCH_MODEL, - hint: "default · reasoning disabled", + hint: "default · low reasoning", }, ] as const; diff --git a/extensions/xai/web-search.test.ts b/extensions/xai/web-search.test.ts index 80a867aaa0ca..6569b948f1c1 100644 --- a/extensions/xai/web-search.test.ts +++ b/extensions/xai/web-search.test.ts @@ -559,9 +559,9 @@ describe("xai web search config resolution", () => { expect(fetchCallHeader(mockFetch, 1, "Authorization")).toBe("Bearer xai-env-fallback-key"); }); - it("offers plugin-owned xSearch setup after Grok is selected", async () => { + it("offers plugin-owned xSearch setup with an accurate default reasoning hint", async () => { const provider = createXaiWebSearchProvider(); - const select = vi.fn().mockResolvedValueOnce("yes").mockResolvedValueOnce("grok-4.3"); + const select = vi.fn().mockResolvedValueOnce("yes").mockResolvedValueOnce("grok-4.6"); const prompter = createTestWizardPrompter({ select: select as never, }); @@ -589,7 +589,20 @@ describe("xai web search config resolution", () => { | { enabled?: boolean; model?: string } | undefined; expect(xSearch?.enabled).toBe(true); - expect(xSearch?.model).toBe("grok-4.3"); + expect(xSearch?.model).toBe("grok-4.6"); + expect(select).toHaveBeenNthCalledWith( + 2, + expect.objectContaining({ + initialValue: "grok-4.6", + options: expect.arrayContaining([ + { + value: "grok-4.6", + label: "grok-4.6", + hint: "default · low reasoning", + }, + ]), + }), + ); }); it("keeps explicit xSearch disablement untouched during provider-owned setup", async () => {