ewilliams28/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-08-26 20:35:39 -06:00
Code Issues Packages Projects Releases Wiki Activity

fix(e2e): bound Docker stats sample lines (#109262)

Browse Source 
* fix(e2e): bound Docker stats sample lines

* fix(e2e): format Docker stats line cap proof

* fix docker stats CRLF line cap

---------

Co-authored-by: Peter Steinberger <steipete@gmail.com>
This commit is contained in:
qingminlong
2026-07-29 19:30:29 +08:00
committed by GitHub
parent 7b34145e44
commit ba26595aaa
2 changed files with 97 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/scripts/docker-stats-resource-ceiling.test.ts
+50
View File
@@ -6,6 +6,7 @@ import { join } from "node:path";
import { afterEach, describe, expect, it } from "vitest";
const SCRIPT_PATH = "scripts/e2e/lib/docker-stats/assert-resource-ceiling.mjs";
const MAX_STATS_SAMPLE_LINE_BYTES = 1024 * 1024;
const tempRoots: string[] = [];
function writeStats(contents: string): string {
@@ -26,6 +27,14 @@ function runAssert(statsFile: string, maxMemoryMiB = "512", maxCpuPercent = "100
);
}
function validStatsLineWithBytes(byteLength: number): string {
const prefix = '{"MemUsage":"128MiB / 2GiB","CPUPerc":"25.0%","padding":"';
const suffix = '"}';
const paddingLength = byteLength - Buffer.byteLength(prefix + suffix, "utf8");
expect(paddingLength).toBeGreaterThan(0);
return `${prefix}${"x".repeat(paddingLength)}${suffix}`;
}
afterEach(() => {
for (const root of tempRoots.splice(0)) {
rmSync(root, { force: true, recursive: true });
@@ -101,10 +110,51 @@ describe("scripts/e2e/lib/docker-stats/assert-resource-ceiling.mjs", () => {
const source = readFileSync(SCRIPT_PATH, "utf8");
expect(source).toContain("createReadStream");
expect(source).toContain("MAX_STATS_SAMPLE_LINE_BYTES");
expect(source).not.toContain("createInterface");
expect(source).not.toContain("readFileSync(statsFile");
expect(source).not.toContain("split(/\\r?\\n/u)");
});
it("rejects oversized stats sample lines before parsing JSON", () => {
const result = runAssert(writeStats(`{"padding":"${"x".repeat(1024 * 1024)}"}\n`));
expect(result.status).not.toBe(0);
expect(result.stderr).toContain("exceeded 1048576 bytes");
expect(result.stderr).not.toContain("was not valid JSON");
});
it("accepts large stats sample lines within the line cap", () => {
const padding = "x".repeat(1024);
const result = runAssert(
writeStats(`{"MemUsage":"128MiB / 2GiB","CPUPerc":"25.0%","padding":"${padding}"}\n`),
);
expect(result.status).toBe(0);
expect(result.stdout).toContain("samples=1");
});
it("accepts CRLF stats sample lines whose content exactly matches the line cap", () => {
const line = validStatsLineWithBytes(MAX_STATS_SAMPLE_LINE_BYTES);
const result = runAssert(writeStats(`${line}\r\n`));
expect(Buffer.byteLength(line, "utf8")).toBe(MAX_STATS_SAMPLE_LINE_BYTES);
expect(result.status).toBe(0);
expect(result.stdout).toContain("samples=1");
});
it("accepts stats sample lines separated by standalone carriage returns", () => {
const result = runAssert(
writeStats(
'{"MemUsage":"128MiB / 2GiB","CPUPerc":"25.0%"}\r{"MemUsage":"64MiB / 2GiB","CPUPerc":"15.0%"}\r',
),
);
expect(result.status).toBe(0);
expect(result.stdout).toContain("memory=128.0MiB");
expect(result.stdout).toContain("samples=2");
});
it("accepts byte-unit Docker memory samples", () => {
const result = runAssert(writeStats('{"MemUsage":"512B / 2GiB","CPUPerc":"0.5%"}\n'));