From ab99029b3bbc7dfb15936aacdc0784183dc3173c Mon Sep 17 00:00:00 2001 From: xingzhou Date: Sat, 18 Jul 2026 14:10:47 +0800 Subject: [PATCH] test(ui): stabilize browser initialization checks (#110403) --- ui/src/pages/chat/chat-responsive.browser.test.ts | 15 ++++++++++++--- .../chat-sidebar-file-view.browser.test.ts | 2 +- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/ui/src/pages/chat/chat-responsive.browser.test.ts b/ui/src/pages/chat/chat-responsive.browser.test.ts index 80e6ecb51556..87c9fc01ccd6 100644 --- a/ui/src/pages/chat/chat-responsive.browser.test.ts +++ b/ui/src/pages/chat/chat-responsive.browser.test.ts @@ -632,7 +632,10 @@ describeBrowserLayout.concurrent("chat responsive browser layout", () => { }, ], }); - await page.goto(`${realChatServer.baseUrl}chat`); + await page.goto(`${realChatServer.baseUrl}chat`, { + waitUntil: "domcontentloaded", + timeout: APP_FIRST_RENDER_TIMEOUT_MS, + }); await page .getByText("Context hover regression fixture.") .waitFor({ timeout: APP_FIRST_RENDER_TIMEOUT_MS }); @@ -711,7 +714,10 @@ describeBrowserLayout.concurrent("chat responsive browser layout", () => { }, ], }); - await page.goto(`${realChatServer.baseUrl}chat`); + await page.goto(`${realChatServer.baseUrl}chat`, { + waitUntil: "domcontentloaded", + timeout: APP_FIRST_RENDER_TIMEOUT_MS, + }); const image = page.locator("img.chat-message-image"); const video = page.locator("video"); @@ -1908,7 +1914,10 @@ describeBrowserLayout.concurrent("chat responsive browser layout", () => { }, ], }); - await page.goto(`${realChatServer.baseUrl}chat`); + await page.goto(`${realChatServer.baseUrl}chat`, { + waitUntil: "domcontentloaded", + timeout: APP_FIRST_RENDER_TIMEOUT_MS, + }); await page .getByText("Short landscape slash command keyboard regression fixture.") .waitFor({ timeout: APP_FIRST_RENDER_TIMEOUT_MS }); diff --git a/ui/src/pages/chat/components/chat-sidebar-file-view.browser.test.ts b/ui/src/pages/chat/components/chat-sidebar-file-view.browser.test.ts index 73ecbc4b7a23..d1dc06466b71 100644 --- a/ui/src/pages/chat/components/chat-sidebar-file-view.browser.test.ts +++ b/ui/src/pages/chat/components/chat-sidebar-file-view.browser.test.ts @@ -50,7 +50,7 @@ async function mountFile(content: FileSidebarContent): Promise { document.body.append(panel); mounted.push(panel); await panel.updateComplete; - await expect.poll(() => panel.querySelector(".cm-editor")).not.toBeNull(); + await expect.poll(() => panel.querySelector(".cm-editor"), { timeout: 5_000 }).not.toBeNull(); return panel; }