ewilliams28/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-08-27 21:07:01 -06:00
Code Issues Packages Projects Releases Wiki Activity

fix(update): support npm before lifecycle allowlists (#125452)

Browse Source
This commit is contained in:
Peter Steinberger
2026-08-17 17:01:23 -07:00
committed by GitHub
parent b228c83bfc
commit a996ea25d9
18 changed files with 56 additions and 144 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/cli/update-cli.test.ts
-54
View File
@@ -4717,34 +4717,6 @@ describe("update-cli", () => {
expect(defaultRuntime.exit).not.toHaveBeenCalledWith(1);
});
it.each(["11.13.0", "11.15.9"])(
"refuses npm %s before stopping the managed gateway or cleaning update backups",
async (npmVersion) => {
const tempDir = await createTrackedTempDir("openclaw-update-npm-policy-");
const { nodeModules, entryPath } = await setupInstalledPackageRoot(tempDir);
const backupDir = path.join(nodeModules, ".openclaw-interrupted");
await fs.mkdir(backupDir, { recursive: true });
mockRunningManagedGateway(["node", entryPath, "gateway", "run"]);
mockFileBackedPathExists();
vi.mocked(runCommandWithTimeout).mockImplementation(async (argv) => {
if (argv[0] === "npm" && argv[1] === "--version") {
return commandResult({ stdout: `${npmVersion}\n` });
}
if (argv[0] === "npm" && argv[1] === "root" && argv[2] === "-g") {
return commandResult({ stdout: `${nodeModules}\n` });
}
return commandResult();
});
await updateCommand({ yes: true });
expect(serviceStop).not.toHaveBeenCalled();
expect(packageInstallCommandCall()).toBeUndefined();
await expect(fs.access(backupDir)).resolves.toBeUndefined();
expect(getErrorOutput()).toContain(`npm ${npmVersion} cannot safely approve`);
},
);
it("stops a running managed gateway before package replacement", async () => {
const platformSpy = vi.spyOn(process, "platform", "get").mockReturnValue("win32");
const processOnSpy = vi.spyOn(process, "on");
@@ -6929,32 +6901,6 @@ describe("update-cli", () => {
expect(defaultRuntime.exit).not.toHaveBeenCalledWith(1);
});
it.each(["11.13.0", "11.15.9"])(
"refuses npm %s package-to-dev updates before checkout or install",
async (npmVersion) => {
const packageRoot = createCaseDir("openclaw-npm-transition");
mockPackageInstallStatus(packageRoot);
vi.mocked(runCommandWithTimeout).mockImplementation(async (argv) => {
if (argv[0] === "npm" && argv[1] === "--version") {
return commandResult({ stdout: `${npmVersion}\n` });
}
if (argv[0] === "npm" && argv[1] === "root" && argv[2] === "-g") {
return commandResult({ stdout: `${path.dirname(packageRoot)}\n` });
}
return commandResult();
});
await updateCommand({ channel: "dev", yes: true, restart: false });
expect(runGatewayUpdate).not.toHaveBeenCalled();
expect(commandCalls().some(([argv]) => argv[0] === "git")).toBe(false);
expect(
commandCalls().some(([argv]) => argv[0] === "npm" && argv[1] === "i" && argv[2] === "-g"),
).toBe(false);
expect(getErrorOutput()).toContain(`npm ${npmVersion} cannot safely approve`);
},
);
it("explains why git updates cannot run with edited files", async () => {
vi.mocked(defaultRuntime.log).mockClear();
vi.mocked(defaultRuntime.error).mockClear();