From 9a73ddc394850c134535682a639746766b4ceae4 Mon Sep 17 00:00:00 2001 From: Peter Steinberger Date: Sun, 24 May 2026 02:16:47 +0100 Subject: [PATCH] docs: clarify PR provenance roles --- .agents/skills/openclaw-pr-maintainer/SKILL.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.agents/skills/openclaw-pr-maintainer/SKILL.md b/.agents/skills/openclaw-pr-maintainer/SKILL.md index 34cd7548121e..13482c455ddf 100644 --- a/.agents/skills/openclaw-pr-maintainer/SKILL.md +++ b/.agents/skills/openclaw-pr-maintainer/SKILL.md @@ -169,8 +169,9 @@ Output only qualifying candidates, with: ref, surface, proof, cause, fix sketch, - Start every PR review with 1-3 plain sentences explaining what the change does and why it matters. Put this before `Findings`. - Then list findings first. If none, say `No blocking findings` or `No findings`. - Always answer: bug/behavior being fixed, PR/issue URL and affected surface, provenance for regressions when traceable, and best-fix verdict. -- For bug/regression fixes, include a compact `Provenance:` line after cause/root-cause when a bounded history pass can identify it. Use `git log -S/-G`, `git blame`, linked PRs/issues, and tests; separate author, committer/merger, and current PR author when they differ. -- For any confirmed bug, run `git blame` on the implicated line(s) after identifying the root cause. Report who broke it and when by naming the merging maintainer for the blamed PR, not the commit author. Include the PR number; if no PR is traceable, include the blamed commit SHA/date instead of guessing a merger. +- For bug/regression fixes, include a compact `Provenance:` line after cause/root-cause when a bounded history pass can identify it. Use `git log -S/-G`, `git blame`, linked PRs/issues, and tests. +- Provenance must separate roles when they differ: blamed code author username, blamed PR merger/committer username, current PR author username, PR number, and date. Do not collapse them into one "introduced by" actor. +- For any confirmed bug, run `git blame` on the implicated line(s) after identifying the root cause. Report who broke it as the blamed PR merger/committer, and also name the blamed code author. Include the PR number; if no PR is traceable, include the blamed commit SHA/date and author username instead of guessing a merger. - Phrase provenance as `introduced by`, `made visible by`, or `carried forward by`, with confidence (`clear`, `likely`, `unknown`). If unclear, say what evidence is missing instead of guessing. For features, docs, and refactors, use `Provenance: N/A` or omit it when no broken behavior is being fixed. - Keep summaries compact, but include enough proof that the verdict is auditable without rereading the PR.