From 9773cbafdbc03f5291a99f3cd23926508e3c8d8e Mon Sep 17 00:00:00 2001 From: ly-wang19 <94427531+ly-wang19@users.noreply.github.com> Date: Wed, 24 Jun 2026 15:39:38 +0800 Subject: [PATCH] fix(msteams): use valid PascalCase Adaptive Card enums for the welcome heading (#96290) * fix(msteams): use valid PascalCase Adaptive Card enums for the welcome heading The welcome card heading TextBlock used weight "bolder" and size "medium" (lowercase). Adaptive Card TextWeight/TextSize enums are case-sensitive PascalCase ("Bolder"/"Medium"); Teams falls back to Default for unrecognized values, so the "Hi! I'm ." greeting rendered unstyled. Use the correct casing, matching the sibling polls/presentation cards. Co-Authored-By: Claude Opus 4.8 (1M context) * fix(msteams): use valid PascalCase Adaptive Card enums for the welcome heading --------- Co-authored-by: ly-wang19 Co-authored-by: Claude Opus 4.8 (1M context) Co-authored-by: Vincent Koc --- extensions/msteams/src/welcome-card.test.ts | 9 +++++++++ extensions/msteams/src/welcome-card.ts | 6 ++++-- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/extensions/msteams/src/welcome-card.test.ts b/extensions/msteams/src/welcome-card.test.ts index b9e068be029c..3a7da92c7ec7 100644 --- a/extensions/msteams/src/welcome-card.test.ts +++ b/extensions/msteams/src/welcome-card.test.ts @@ -85,6 +85,15 @@ describe("buildWelcomeCard", () => { expect(actions[0]?.title).toBe("What can you do?"); }); + it("styles the heading with valid PascalCase Adaptive Card enum values", () => { + // Lowercase weight/size fall back to Default in the Teams renderer, so the heading must use the + // schema's PascalCase enums to render bold/medium. + const card = buildWelcomeCard(); + const heading = (card.body as Array<{ weight?: string; size?: string }>)[0]; + expect(heading?.weight).toBe("Bolder"); + expect(heading?.size).toBe("Medium"); + }); + it("uses custom bot name", () => { const card = buildWelcomeCard({ botName: "TestBot" }); const body = card.body as Array<{ text: string }>; diff --git a/extensions/msteams/src/welcome-card.ts b/extensions/msteams/src/welcome-card.ts index dcc29106139b..f9c934805889 100644 --- a/extensions/msteams/src/welcome-card.ts +++ b/extensions/msteams/src/welcome-card.ts @@ -31,8 +31,10 @@ export function buildWelcomeCard(options?: WelcomeCardOptions): Record